Bug 1392784 - Enable metrics by default
Summary: Enable metrics by default
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: ---
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: ovirt-4.1.0-alpha
: 4.19.2
Assignee: Yaniv Bronhaim
QA Contact: Jiri Belka
URL:
Whiteboard:
: 1414277 (view as bug list)
Depends On:
Blocks: 1405813
TreeView+ depends on / blocked
 
Reported: 2016-11-08 09:10 UTC by Yaniv Bronhaim
Modified: 2017-02-08 21:09 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:53:38 UTC
oVirt Team: Infra
rule-engine: ovirt-4.1+
bmcclain: priority_rfe_tracking+
ybronhei: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 66229 0 None None None 2016-11-14 07:56:37 UTC
oVirt gerrit 66257 0 master MERGED Enable metrics by default 2016-12-01 16:00:15 UTC

Description Yaniv Bronhaim 2016-11-08 09:10:51 UTC
Description of problem:
vdsm.conf contains configuration value to enable metrics report. Currently in 4.0 the default is set to false. In that case after deploying new host by engine we need to modify the conf file and restart the service. To do that host needs to enter to maintenance and migrate vms if it runs any. 
In 4.1 we want to enable metrics report always by default (we don't send too many value and it doesn't effect vdsm process too much anyway).

Comment 1 Sandro Bonazzola 2016-12-12 13:58:07 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 2 Jiri Belka 2017-01-11 18:02:23 UTC
ok

# sed -n '/metrics/,/^$/p' /usr/lib/python2.7/site-packages/vdsm/config.py ; rpm -qf /usr/lib/python2.7/site-packages/vdsm/config.py
    # Section: [metrics]
    ('metrics', [
        ('enabled', 'true',
            'Enable metrics collection (default true)'),

            'Number of metrics messages to queue if collector is not'
            ' responsive. When the queue is full, oldest messages are'
            ' dropped. Used only by hawkular-client collector (default 100)'),
    ]),

vdsm-python-4.19.1-29.git40ed539.el7.centos.noarch

Comment 3 Yaniv Bronhaim 2017-01-12 12:58:48 UTC
Jiri - you just validated that metrics enabled config is set to true by default. the point is to see if the metrics are actually being reported automatically once vdsm is starting (and the rest of the system is configured properly - with collectd running and forwarding it to somewhere that you can check). So in my testings I checked upgrade flow to see if vdsm starts to send metrics after update. new installation. installation without having collectd up - to see if it doesn't generate any issues or error logs anywhere and as stated before, if all set properly, checking if metrics arrive.

Comment 4 Jiri Belka 2017-01-12 14:13:49 UTC
vdsm sends data to port 8125 which is supposed to be statd. imo validation of metrics data should be supposed to be done in different BZ (iirc there's separate RFE for this) thus this BZ is OK for me. OK?

# tcpdump -i lo -n -ttt -A -c 5 port 8125
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on lo, link-type EN10MB (Ethernet), capture size 65535 bytes
00:00:00.000000 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 21
E..1..@.@.C................0hosts.cpu.load:0.00|g
00:00:00.000047 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 20
E..0..@.@.C................/hosts.cpu.sys:0.00|g
00:00:00.000013 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 19
E../..@.@.C.................hosts.vms.total:0|g
00:00:00.000021 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 35
E..?..@.@.C..............+.>hosts.memory.anon_huge_pages:0.00|g
00:00:00.000011 IP 127.0.0.1.57083 > 127.0.0.1.8125: UDP, length 26
E..6..@.@.C..............".5hosts.cpu.sys_vdsmd:0.00|g
5 packets captured
32 packets received by filter
0 packets dropped by kernel

Comment 5 Yedidyah Bar David 2017-01-22 11:18:14 UTC
*** Bug 1414277 has been marked as a duplicate of this bug. ***

Comment 6 Yaniv Bronhaim 2017-01-22 14:04:20 UTC
Yes this is prefect. Just wanted to see that the data is sent and not only configured to be sent. Thank you

Comment 7 Jiri Belka 2017-01-23 09:58:31 UTC
verification confirmed in #6


Note You need to log in before you can comment on or make changes to this bug.