Bug 1396781 - Create a new disk while creating new vm needs to press OK button twice.
Summary: Create a new disk while creating new vm needs to press OK button twice.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.0.5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.1.0-alpha
: ---
Assignee: Tomas Jelinek
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks: 1401576
TreeView+ depends on / blocked
 
Reported: 2016-11-20 05:53 UTC by Ulhas Surse
Modified: 2020-02-14 18:17 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1401576 (view as bug list)
Environment:
Last Closed: 2017-04-25 00:50:41 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot of error after trying to add a disk to a new VM (100% reproducible) (121.40 KB, image/png)
2016-12-08 18:33 UTC, Jason Woods
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:0997 0 normal SHIPPED_LIVE Red Hat Virtualization Manager (ovirt-engine) 4.1 GA 2017-04-18 20:11:26 UTC

Description Ulhas Surse 2016-11-20 05:53:01 UTC
Description of problem:
While creating new VM, select create disk option. After selecting all options and press OK, nothing changes and the configuration is not saved until you press OK again.


Version-Release number of selected component (if applicable):
RHV 4.0.5 admin portal

How reproducible:
Always


Steps to Reproduce:
1. Create New VM.
2. Create disk for this new VM.
3. Press OK to save configuration. 

Actual results:
Nothing happens. 

Expected results:
Configuration should be saved and navigate to create new VM screen. 

Additional info:

Comment 1 Tomas Jelinek 2016-11-21 15:23:00 UTC
I can not simulate this. What I can observe on the other hand is that there is a delay between pressing the OK and the dialog actually saving. Any chance this is a larger delay on your (I guess bigger) environment?

If not, could you please check if there are some error logs in the ui.log after the first pressing of the OK?

Comment 2 Ulhas Surse 2016-11-23 01:20:06 UTC
Hello,

It is not happening for every attempt now. sometime happens and at and other attempt not. I see following logs in ui.log when it fails:


Caused by: com.google.gwt.event.shared.UmbrellaException: Exception caught: (TypeError) 
 __gwt$exception: <skipped>: a is null
	at Unknown.Bv(Unknown Source)
	at Unknown.Jv(Unknown Source)
	at Unknown.L7(Unknown Source)
	at Unknown.O7(Unknown Source)
	at Unknown.Y6(Unknown Source)
	at Unknown.nq(Unknown Source)
	at Unknown.xq(Unknown Source)
	at Unknown.M6(Unknown Source)
	at Unknown.WDm(Unknown Source)
	at Unknown.z5r(Unknown Source)
	at Unknown.aFo(Unknown Source)
	at Unknown.qFo(Unknown Source)
	at Unknown.Ztr(Unknown Source)
	at Unknown.ZZq(Unknown Source)
	at Unknown.Lvl(Unknown Source)
	at Unknown.JJk(Unknown Source)
	at Unknown._2(Unknown Source)
	at Unknown.A2(Unknown Source)
	at Unknown.g7(Unknown Source)
	... 22 more
Caused by: com.google.gwt.core.client.JavaScriptException: (TypeError) 
 __gwt$exception: <skipped>: a is null

Comment 3 Ulhas Surse 2016-11-23 01:21:28 UTC
I was waiting for more than a minute to respond to create disk but it still is not saving the configuration.

Comment 4 Tomas Jelinek 2016-11-23 07:42:10 UTC
OK, so a null pointer - I would guess it to some race on async calls.

Could you please now provide the logs in an un-obfuscated way? E.g. install the ovirt-engine-webadmin-portal-debuginfo ovirt-engine-userportal-debuginfo, than restart the engine, simulate again and than take the logs.
Also please provide the exact version of the webadmin rpm.

thank you

Comment 5 Ulhas Surse 2016-11-28 01:08:28 UTC
Hi Tomas,
I have asked logs from customer environment who has reported the issues and able to reproduce the same in his environment. 

>>> exact version of the webadmin rpm.
~~~
rhevm-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-webadmin-portal-4.0.5.5-0.1.el7ev.noarch
~~~

$ cat installed-rpms | grep debuginfo
ovirt-engine-userportal-debuginfo-4.0.5.5-0.1.el7ev.noarch  Fri Nov 25 08:29:44 2016
ovirt-engine-webadmin-portal-debuginfo-4.0.5.5-0.1.el7ev.noarch Fri Nov 25 08:29:35 2016

Comment 9 Tomas Jelinek 2016-11-29 17:03:14 UTC
The problem is that the event about the fact that the button was clicked is published as an event. Therefore, the order in which the following two events happen are unpredictable:
1: close the disk dialog
2: show VM dialog
3: update values in VM dialog

In most cases it is 1, 2 and than 3, but in some cases it can be 3, 1, 2. This leads to trying to update the properties of a widget which is not visible leading to exceptions.

Coincidentally, there is a different bug (https://bugzilla.redhat.com/show_bug.cgi?id=1391466) which requires not to hide the VM dialog if the disk dialog is shown which will ensure that the VM dialog is always present and regardless of the order of the events, the widgets can be updated. The https://bugzilla.redhat.com/show_bug.cgi?id=1391466 is targeted to 4.0.6 so setting target of this also for 4.0.6 for independent verification.

Comment 10 Ulhas Surse 2016-11-30 01:28:29 UTC
Hello, 
Also there is this message appeared while creating disk:

~~~
Uncaught exception occurred. Please try reloading the page. Details: Exception caught: Exception caught: (TypeError) __gwt$exception: <skipped>: a is null
Please have your administrator check the UI logs
~~~

Will this be addressed here or should I create a new bugzilla report. 
The screenshot is already attached with this bugzilla.

Comment 11 Tomas Jelinek 2016-11-30 07:15:14 UTC
addressed here - that is the same issue reported in two different ways.

Comment 12 Ulhas Surse 2016-11-30 07:50:40 UTC
Great, thanks for the confirmation.

Comment 15 Jason Woods 2016-12-08 18:31:28 UTC
I found this bug on a new install of RHV 4.0.5.

There is a window that pops up in the GUI showing Uncaught exception occured, as stated in previous comments. Screenshot attached.

Again, this is on a brand new fresh install of RHV 4.0.5, and is completely up to date using RHSM repos.

# yum update 
Loaded plugins: product-id, search-disabled-repos, subscription-manager,
              : versionlock
No packages marked for update

# rpm -qa | grep rhev
rhevm-setup-plugins-4.0.0.3-1.el7ev.noarch
redhat-support-plugin-rhev-4.0.0-7.el7ev.noarch
rhevm-dependencies-4.0.0-1.el7ev.noarch
rhevm-branding-rhev-4.0.0-5.el7ev.noarch
rhevm-spice-client-x64-msi-4.0-3.el7ev.noarch
rhevm-doc-4.0.5-1.el7ev.noarch
rhev-guest-tools-iso-4.0-6.el7ev.noarch
rhevm-4.0.5.5-0.1.el7ev.noarch
rhevm-spice-client-x86-msi-4.0-3.el7ev.noarch

# rpm -qa | grep ovirt
ovirt-engine-extensions-api-impl-4.0.5.5-0.1.el7ev.noarch
ovirt-imageio-proxy-setup-0.4.0-0.el7ev.noarch
ovirt-engine-webadmin-portal-4.0.5.5-0.1.el7ev.noarch
python-ovirt-engine-sdk4-4.0.2-1.el7ev.x86_64
ovirt-iso-uploader-4.0.2-1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.0.5.5-0.1.el7ev.noarch
ovirt-vmconsole-1.0.4-1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-tools-backup-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-backend-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-cli-3.6.8.1-1.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch
ovirt-host-deploy-1.5.3-1.el7ev.noarch
ovirt-engine-lib-4.0.5.5-0.1.el7ev.noarch
ovirt-host-deploy-java-1.5.3-1.el7ev.noarch
ovirt-engine-dwh-4.0.5-1.el7ev.noarch
ovirt-engine-setup-plugin-websocket-proxy-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-setup-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-dbscripts-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-dashboard-1.0.5-1.el7ev.x86_64
ovirt-engine-vmconsole-proxy-helper-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-websocket-proxy-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-userportal-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-sdk-python-3.6.9.1-1.el7ev.noarch
ovirt-engine-extension-aaa-jdbc-1.1.1-1.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
ovirt-engine-tools-4.0.5.5-0.1.el7ev.noarch
ovirt-engine-restapi-4.0.5.5-0.1.el7ev.noarch
ovirt-log-collector-4.0.1-1.el7ev.noarch
ovirt-image-uploader-4.0.1-1.el7ev.noarch
ovirt-setup-lib-1.0.2-1.el7ev.noarch
ovirt-engine-dwh-setup-4.0.5-1.el7ev.noarch
ovirt-vmconsole-proxy-1.0.4-1.el7ev.noarch
ovirt-engine-setup-base-4.0.5.5-0.1.el7ev.noarch

## Optional and Extras repos added to install cockpit on RHV-M OS.

# yum repolist -v
Not loading "rhnplugin" plugin, as it is disabled
Loading "product-id" plugin
Loading "search-disabled-repos" plugin
Loading "subscription-manager" plugin
Loading "versionlock" plugin
Updating Subscription Management repositories.
Config time: 1.066
Yum version: 3.4.3
Setting up Package Sacks
Reading version lock configuration
pkgsack time: 0.008
Repo-id      : jb-eap-7-for-rhel-7-server-rpms/7Server/x86_64
Repo-name    : JBoss Enterprise Application Platform 7 (RHEL 7 Server) (RPMs)
Repo-revision: 1481118692
Repo-updated : Wed Dec  7 05:51:32 2016
Repo-pkgs    : 508
Repo-size    : 675 M
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/jbeap/7/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:14 2016)
  Filter     : read-only:present
Repo-filename: /etc/yum.repos.d/redhat.repo

Repo-id      : rhel-7-server-extras-rpms/x86_64
Repo-name    : Red Hat Enterprise Linux 7 Server - Extras (RPMs)
Repo-revision: 1481046582
Repo-updated : Tue Dec  6 09:49:42 2016
Repo-pkgs    : 358
Repo-size    : 940 M
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/extras/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:15 2016)
  Filter     : read-only:present
Repo-filename: /etc/yum.repos.d/redhat.repo

Repo-id      : rhel-7-server-optional-rpms/7Server/x86_64
Repo-name    : Red Hat Enterprise Linux 7 Server - Optional (RPMs)
Repo-revision: 1481041381
Repo-updated : Tue Dec  6 08:23:01 2016
Repo-pkgs    : 10,436
Repo-size    : 16 G
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/optional/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:15 2016)
  Filter     : read-only:present
Repo-filename: /etc/yum.repos.d/redhat.repo

Repo-id      : rhel-7-server-rhv-4.0-rpms/x86_64
Repo-name    : Red Hat Virtualization Manager 4.0 (RHEL 7 Server) (RPMs)
Repo-revision: 1479325010
Repo-updated : Wed Nov 16 11:36:50 2016
Repo-pkgs    : 208
Repo-size    : 990 M
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/rhv/4.0/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:16 2016)
  Filter     : read-only:present
Repo-excluded: 32
Repo-filename: /etc/yum.repos.d/redhat.repo

Repo-id      : rhel-7-server-rpms/7Server/x86_64
Repo-name    : Red Hat Enterprise Linux 7 Server (RPMs)
Repo-revision: 1481041632
Repo-updated : Tue Dec  6 08:27:11 2016
Repo-pkgs    : 13,540
Repo-size    : 17 G
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:16 2016)
  Filter     : read-only:present
Repo-filename: /etc/yum.repos.d/redhat.repo

Repo-id      : rhel-7-server-supplementary-rpms/7Server/x86_64
Repo-name    : Red Hat Enterprise Linux 7 Server - Supplementary (RPMs)
Repo-revision: 1478164862
Repo-updated : Thu Nov  3 02:21:02 2016
Repo-pkgs    : 164
Repo-size    : 4.0 G
Repo-baseurl : https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/supplementary/os
Repo-expire  : 86,400 second(s) (last: Wed Dec  7 14:17:17 2016)
  Filter     : read-only:present
Repo-filename: /etc/yum.repos.d/redhat.repo

repolist: 25,214

Comment 16 Jason Woods 2016-12-08 18:33:15 UTC
Created attachment 1229585 [details]
screenshot of error after trying to add a disk to a new VM (100% reproducible)

This was a new install of RHV 4.0.5, with all updates applied as of 2016-12-08.

Comment 17 Tomas Jelinek 2016-12-09 07:52:30 UTC
This bug is targeted to 4.1 - the deepest z-stream clone (https://bugzilla.redhat.com/show_bug.cgi?id=1401576) is targeted to 4.0.6, so in 4.0.5 it still will be occurring.

Comment 22 meital avital 2017-02-10 08:34:56 UTC
Verified on version: 4.1.0.3-0.1.el7


Note You need to log in before you can comment on or make changes to this bug.