Bug 1400043 - [z-stream clone - 4.0.7] [Vm Pool] VMs are created with duplicate MAC addresses
Summary: [z-stream clone - 4.0.7] [Vm Pool] VMs are created with duplicate MAC addresses
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.0.4
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ovirt-4.0.7
: ---
Assignee: Martin Mucha
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On: 1395462
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-30 10:59 UTC by rhev-integ
Modified: 2021-08-30 11:50 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
This bug fixes several issues with insufficient synchronization when accessing MAC pools.
Clone Of: 1395462
Environment:
Last Closed: 2017-03-16 15:29:38 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 2775081 0 None None None 2016-11-30 11:00:17 UTC
Red Hat Product Errata RHBA-2017:0542 0 normal SHIPPED_LIVE Red Hat Virtualization Manager 4.0.7 2017-03-16 19:25:04 UTC
oVirt gerrit 67101 0 None None None 2016-11-30 11:00:17 UTC
oVirt gerrit 67137 0 None None None 2016-11-30 11:20:20 UTC
oVirt gerrit 67245 0 None None None 2016-11-30 11:00:17 UTC
oVirt gerrit 67246 0 None None None 2016-11-30 11:00:17 UTC
oVirt gerrit 67247 0 master ABANDONED core: added more integration-like test for MacPool 2017-03-15 08:40:10 UTC
oVirt gerrit 67570 0 None None None 2016-11-30 11:20:55 UTC
oVirt gerrit 67571 0 None None None 2016-11-30 11:21:16 UTC

Comment 1 rhev-integ 2016-11-30 10:59:35 UTC
Description of problem:

When additional VmPools are created, many of the VMs from the new VmPool end up with the same MAC address of existing VMs from other Pools which were created many days ago.

When these VMs with duplicate MACs are started, they lose the tap device as the MAC is already in use. See:

2016-11-09 03:00:10,787 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.pool-6-thread-30) [699b0a6d] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: Network Interface nic1 has MAC address 00:1a:4a:16:01:6c which is in use, therefore it is being unplugged from VM AAA_03.

So the VM ends up without Networking, rendering it completely useless.

Here is an example of two VMs from different Pools and created in completely different points in time:

2016-10-24 14:31:35.292+08 | VM AAA_03 creation has been completed.
2016-10-24 14:32:19.741+08 | VM Pool AAA (containing 20 VMs) was created by <removed>

2016-10-31 16:16:35.77+08  | VM BBB_01 creation has been completed.
2016-10-31 16:16:37.132+08 | VM Pool BBB (containing 10 VMs) was created by <removed>

Result:

     vm_name      |     mac_addr      
------------------+-------------------
 AAA_03           | 00:1a:4a:16:01:6c 
 BBB_013          | 00:1a:4a:16:01:6c 
 

Deleting all Pools and creating them again seems to yield the same result.

Version-Release number of selected component (if applicable):
ovirt-engine-4.0.4.4-0.1.el7ev.noarch

How reproducible:
* 0% after many tries
* Happens constantly on customer site

Actual results:
Duplicate MACs

Expected results:
No Duplicate MACs

Additional info:
* Allow Duplicate Macs option is disabled
* Using default MAC pool, no extra configurations
* Templates which these VMs are based on were imported and have MACs out of the MacPool range
 (Does not seem related as I tried this as well)
* Pools are created by different users (aaa)
 (Does not seem related as I tried this as well)
* It's always 2 VMs with the same MAC, never more than 2.

This comment was originaly posted by gveitmic

Comment 10 sefi litmanovich 2017-01-29 14:59:51 UTC
Verified with rhevm-4.0.7-0.1.el7ev.noarch.
Created 3 pools with 20 vms each, have a 60+ mac range, then verify there's no duplication. Repeated this several times, but not problem. This case is running on our automation.

Comment 12 errata-xmlrpc 2017-03-16 15:29:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0542.html


Note You need to log in before you can comment on or make changes to this bug.