Bug 1400299 - image upload to pre existing disk ends with NPE when uploading using python-sdk
Summary: image upload to pre existing disk ends with NPE when uploading using python-sdk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.1.0-beta
: ---
Assignee: Liron Aravot
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks: 1337077 1416343
TreeView+ depends on / blocked
 
Reported: 2016-11-30 20:40 UTC by Natalie Gavrielov
Modified: 2017-02-15 15:00 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1416343 (view as bug list)
Environment:
Last Closed: 2017-02-15 15:00:38 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
script, engine.log, vdsm logs (11.54 MB, application/x-gzip)
2016-11-30 20:40 UTC, Natalie Gavrielov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 69473 0 master MERGED core: TransferImage - callback end methods NPE 2017-01-04 13:28:45 UTC
oVirt gerrit 69604 0 ovirt-engine-4.1 MERGED core: TransferImage - callback end methods NPE 2017-01-04 18:01:15 UTC
oVirt gerrit 69646 0 ovirt-engine-4.0 MERGED core: TransferImage - callback end methods NPE 2017-01-09 10:10:22 UTC

Description Natalie Gavrielov 2016-11-30 20:40:42 UTC
Created attachment 1226502 [details]
script, engine.log, vdsm logs

Description of problem:
When raw disk image finishes uploading the following error appears in engine.log:
Error invoking callback method 'onSucceeded' for 'SUCCEEDED' command following by an NPE.

Version-Release number of selected component (if applicable):
ovirt-engine-4.0.6-0.1.el7ev.noarch
vdsm-4.18.17-1.el7ev.x86_64

How reproducible:
100%

Steps to Reproduce:

Performed this test twice, for two storage domain types: iscsi and nfs
1. Create a *preallocated* disk on a storage domain.
2. Upload a *raw* disk using python sdk (script attached)

Actual results:
When the upload is finished, the following errors appear in engine.log:
2016-11-30 20:29:09,612 ERROR [org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller] (DefaultQuartzScheduler8) [4a62a30a] Error invoking callback method 'onSucceeded' for 'SUCCEEDED' command 'a3ffd30e-932e-4101-b08e-7f27faa912e0'
2016-11-30 20:29:09,612 ERROR [org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller] (DefaultQuartzScheduler8) [4a62a30a] Exception: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.storage.disk.image.UploadDiskImageCommand.getImageAlias(UploadDiskImageCommand.java:129) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.image.UploadImageCommand.getUploadDescription(UploadImageCommand.java:669) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.image.UploadImageCommand.onSucceeded(UploadImageCommand.java:679) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.image.UploadImageCommandCallback.onSucceeded(UploadImageCommandCallback.java:18) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller.endCallback(CommandCallbacksPoller.java:57) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller.invokeCallbackMethods(CommandCallbacksPoller.java:108) [bll.jar:]
        at sun.reflect.GeneratedMethodAccessor65.invoke(Unknown Source) [:1.8.0_111]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_111]
        at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_111]
        at org.ovirt.engine.core.utils.timer.JobWrapper.invokeMethod(JobWrapper.java:77) [scheduler.jar:]
        at org.ovirt.engine.core.utils.timer.JobWrapper.execute(JobWrapper.java:51) [scheduler.jar:]
        at org.quartz.core.JobRunShell.run(JobRunShell.java:213) [quartz.jar:]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [rt.jar:1.8.0_111]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [rt.jar:1.8.0_111]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [rt.jar:1.8.0_111]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [rt.jar:1.8.0_111]
        at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_111]

Expected results:
For the upload to succeed with no errors and NPE. 

Additional info:
webadmin shows the disk in status OK.

Comment 2 Sandro Bonazzola 2017-01-25 07:55:32 UTC
4.0.6 has been the last oVirt 4.0 release, please re-target this bug.

Comment 3 Natalie Gavrielov 2017-02-01 19:19:05 UTC
Performed steps described in comment 0
Verified using:
(rhv-4.1.0-11)
rhevm-4.1.0.3-0.1.el7.noarch
ovirt-imageio-common-1.0.0-0.el7ev.noarch
ovirt-imageio-proxy-1.0.0-0.el7ev.noarch
vdsm-4.19.4-7.gitc2f748c.el7.centos.x86_64
ovirt-imageio-daemon-1.0.0-1.el7.noarch


Note You need to log in before you can comment on or make changes to this bug.