Bug 1402456 - Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)
Summary: Review Request: python3-idna - Internationalized Domain Names in Applications...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tim Orling
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1399337
TreeView+ depends on / blocked
 
Reported: 2016-12-07 15:27 UTC by Orion Poplawski
Modified: 2016-12-28 23:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-28 18:17:13 UTC
Type: Bug
Embargoed:
TicoTimo: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2016-12-07 15:27:11 UTC
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-idna.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-idna-2.1-1.el7.src.rpm
Description:
A library to support the Internationalised Domain Names in Applications (IDNA)
protocol as specified in RFC 5891 <http://tools.ietf.org/html/rfc5891>.  This
version of the protocol is often referred to as "IDNA2008" and can produce
different results from the earlier standard from 2003.

The library is also intended to act as a suitable drop-in replacement for the
"encodings.idna" module that comes with the Python standard library but
currently only supports the older 2003 specification.

Fedora Account System Username: orion

This is an EPEL only package

Comment 1 Tim Orling 2016-12-10 16:07:58 UTC
Koji EPEL7 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16811045

Koji EL6 build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=16811047

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package contains BR: python2-devel or python3-devel
  => OK: uses python%{python3_pkgversion}-devel is used and is EPEL only.
- Warning about invalid license: Unicode
  => Appears is should be Unicode-TOU:
     https://spdx.org/licenses/Unicode-TOU.html
  [!] Please address when package is created

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 16 files have unknown license. Detailed
     output of licensecheck in
     /home/parallels/1402456-python3-idna/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
     => OK: LICENSE file breaks down the licenses
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses
     => EPEL has no default owner for /usr/share/licenses
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python34-idna-2.1-1.el7.centos.noarch.rpm
          python3-idna-2.1-1.el7.centos.src.rpm
python34-idna.noarch: W: invalid-license Unicode
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/uts46data.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/uts46data.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/codec.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/codec.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/idnadata.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/idnadata.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/compat.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/compat.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/core.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/intranges.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/core.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/intranges.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python3-idna.src: W: invalid-license Unicode
  => errors are due to a bug in rpmlint.
  => warnings addressed in issues above
2 packages and 0 specfiles checked; 14 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
python34-idna.noarch: W: invalid-license Unicode
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/uts46data.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/uts46data.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/codec.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/codec.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/idnadata.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/idnadata.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/compat.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/compat.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/core.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/intranges.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/core.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
python34-idna.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/idna/__pycache__/intranges.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown)
1 packages and 0 specfiles checked; 14 errors, 1 warnings.



Requires
--------
python34-idna (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python34-idna:
    python34-idna



Source checksums
----------------
https://pypi.io/packages/source/i/idna/idna-2.1.tar.gz :
  CHECKSUM(SHA256) this package     : ed36f281aebf3cd0797f163bb165d84c31507cedd15928b095b1675e2d04c676
  CHECKSUM(SHA256) upstream package : ed36f281aebf3cd0797f163bb165d84c31507cedd15928b095b1675e2d04c676


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1402456
Buildroot used: epel-7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

APPROVED

Comment 2 Gwyn Ciesla 2016-12-12 14:00:20 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-idna

Comment 3 Fedora Update System 2016-12-12 21:43:47 UTC
python3-idna-2.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3faec4c6db

Comment 4 Fedora Update System 2016-12-12 21:43:54 UTC
python3-idna-2.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-940fb9734f

Comment 5 Fedora Update System 2016-12-14 03:49:40 UTC
python3-idna-2.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3faec4c6db

Comment 6 Fedora Update System 2016-12-14 03:50:36 UTC
python3-idna-2.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-940fb9734f

Comment 7 Fedora Update System 2016-12-28 18:17:13 UTC
python3-idna-2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-12-28 23:48:39 UTC
python3-idna-2.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.