Spec URL: https://smani.fedorapeople.org/review/eigen2.spec SRPM URL: https://smani.fedorapeople.org/review/eigen2-2.0.17-8.fc26.src.rpm Description: Obsolete version of the eigen vector and matrix math C++ template library Fedora Account System Username: smani This package is needed to keep Avogadro building, which does not support eigen3 >= 3.3.0.
Avogadro is already built against Eigen3: http://koji.fedoraproject.org/koji/packageinfo?packageID=6814
> This package is needed to keep Avogadro building, which does not support > eigen3 >= 3.3.0. Oh, you are referring to next Eigen3 release. Can you provide me an eigen3-3.3.0 src-rpm package please?
https://smani.fedorapeople.org/review/eigen3-3.3.0-1.fc26.src.rpm See also [1]. Debian has a patch for 3.3.0 [2] but it is reported to not work properly [3]. [1] https://github.com/cryos/avogadro/issues/842 [2] http://http.debian.net/debian/pool/main/a/avogadro/avogadro_1.2.0-1.debian.tar.xz [3] https://github.com/cryos/avogadro/pull/38
Hi Antonio, any news here?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines Error: nothing provides eigen2-devel = 2.0.17-8.fc26 needed by eigen2-doc-1:2.0.17-8.fc26.noarch (try to add '--allowerasing' to command line to replace conflicting packages) ERROR: Command failed. See logs for output. Epoch is not set for doc sub-package. Please, use Requires: 1:%{name}-devel = %{version}-%{release} - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/eigen2 See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names This is a re-review to newly include eigen2 on Fedora. - Any font file bundled? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later) LGPL (v3 or later)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2.1) LGPL (v2.1)", "LGPL (v3 or later) GPL (v3 or later) LGPL (v3 or later)", "Unknown or generated". 279 files have unknown license. Detailed output of licensecheck in /home/sagitter/Downloads/eigen2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in eigen2-devel , eigen2-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Installation errors ------------------- INFO: mock.py version 1.3.2 starting (python version = 3.5.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.3.2 INFO: Mock Version: 1.3.2 Finish: chroot init INFO: installing package(s): /home/sagitter/Downloads/eigen2/results/eigen2-doc-2.0.17-8.fc26.noarch.rpm /home/sagitter/Downloads/eigen2/results/eigen2-devel-2.0.17-8.fc26.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/sagitter/Downloads/eigen2/results/eigen2-doc-2.0.17-8.fc26.noarch.rpm /home/sagitter/Downloads/eigen2/results/eigen2-devel-2.0.17-8.fc26.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: eigen2-devel-2.0.17-8.fc26.noarch.rpm eigen2-doc-2.0.17-8.fc26.noarch.rpm eigen2-2.0.17-8.fc26.src.rpm eigen2-devel.noarch: W: no-documentation eigen2-devel.noarch: E: zero-length /usr/include/eigen2/Eigen/src/Sparse/SparseAssign.h eigen2-doc.noarch: E: devel-dependency eigen2-devel eigen2.src: W: spelling-error Summary(en_US) eigen -> exigent eigen2.src: W: invalid-url Source0: eigen-2.0.17.tar.bz2 3 packages and 0 specfiles checked; 2 errors, 3 warnings. Requires -------- eigen2-doc (rpmlib, GLIBC filtered): eigen2-devel eigen2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake Provides -------- eigen2-doc: eigen2-doc eigen2-devel: eigen2 eigen2-devel eigen2-static pkgconfig(eigen2) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -rn eigen2-2.0.17-8.fc26.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(Waiting for the broken dependencies in the rawhide tree to be fixed...)
Spec URL: https://smani.fedorapeople.org/review/eigen2.spec SRPM URL: https://smani.fedorapeople.org/review/eigen2-2.0.17-9.fc26.src.rpm %changelog * Sat Dec 17 2016 Sandro Mani <manisandro> - 1:2.0.17-9 - Add missing epoch in requires/provides - Update FTBFS patch to also fix invalid attribute syntax error
Package approved.
Thank you!
Please, take care of https://bugzilla.redhat.com/show_bug.cgi?id=1401967 if you can.