Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1405938

Summary:	volumes will become illegal on failure for modules which use jobs and are based on the CopyDataDivEndpoint logic
Product:	[oVirt] vdsm	Reporter:	Maor <mlipchuk>
Component:	Core	Assignee:	Nir Soffer <nsoffer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Raz Tamir <ratamir>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	---	CC:	bugs, nsoffer, tnisan
Target Milestone:	ovirt-4.1.0-beta	Flags:	rule-engine: ovirt-4.1+ tnisan: devel_ack+
Target Release:	4.19.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1408143 (view as bug list)		Environment:
Last Closed:	2016-12-25 09:11:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1408143

Description Maor 2016-12-19 09:00:12 UTC

Description of problem:
As part of Using CopyDataDivEndpoint to maintain jobs in VDSM, if a failure occurs, the volume will become illegal based on the infrastructure behavior.
Some of the operations does not need to make the volume to be illegal on a failure like amend (or sparsify?)

One possible solution is to add a flag that will indicate if the volume should become illegal on failure or not.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Nir Soffer 2016-12-19 09:20:14 UTC

I discussed this with Adam, and we agreed that:

- Operation on illegal volumes are ok, can use now set_illegal=False
- Atomic operations on volume metadata are ok, can use new set_illegal=False
- Any other operation on volume data or qcow2 metadata must set the volume to 
  illegal before the operation and the volume should remain illegal if the
  operation failed.

Comment 2 Maor 2016-12-22 09:49:43 UTC

This bug will be the infrastructure gap to support setting if a volume is illegal or not on failure.
Every operation that was dependent on the CopyDataDivEndpoint and need to change the behavior will be followed by a dependent bug