Bug 1405938 - volumes will become illegal on failure for modules which use jobs and are based on the CopyDataDivEndpoint logic
Summary: volumes will become illegal on failure for modules which use jobs and are bas...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.1.0-beta
: 4.19.2
Assignee: Nir Soffer
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks: 1408143
TreeView+ depends on / blocked
 
Reported: 2016-12-19 09:00 UTC by Maor
Modified: 2017-01-23 12:31 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
: 1408143 (view as bug list)
Environment:
Last Closed: 2016-12-25 09:11:02 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
tnisan: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 68606 0 master MERGED volume: Operation without modifying legality 2016-12-20 12:24:15 UTC

Description Maor 2016-12-19 09:00:12 UTC
Description of problem:
As part of Using CopyDataDivEndpoint to maintain jobs in VDSM, if a failure occurs, the volume will become illegal based on the infrastructure behavior.
Some of the operations does not need to make the volume to be illegal on a failure like amend (or sparsify?)

One possible solution is to add a flag that will indicate if the volume should become illegal on failure or not.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Nir Soffer 2016-12-19 09:20:14 UTC
I discussed this with Adam, and we agreed that:

- Operation on illegal volumes are ok, can use now set_illegal=False
- Atomic operations on volume metadata are ok, can use new set_illegal=False
- Any other operation on volume data or qcow2 metadata must set the volume to 
  illegal before the operation and the volume should remain illegal if the
  operation failed.

Comment 2 Maor 2016-12-22 09:49:43 UTC
This bug will be the infrastructure gap to support setting if a volume is illegal or not on failure.
Every operation that was dependent on the CopyDataDivEndpoint and need to change the behavior will be followed by a dependent bug


Note You need to log in before you can comment on or make changes to this bug.