+++ This bug was initially created as a clone of Bug #1405938 +++ Description of problem: As part of Using CopyDataDivEndpoint to maintain jobs in VDSM, if a failure occurs, the volume will become illegal based on the infrastructure behavior. Some of the operations does not need to make the volume to be illegal on a failure like amend (or sparsify?) One possible solution is to add a flag that will indicate if the volume should become illegal on failure or not. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Nir Soffer on 2016-12-19 04:20:14 EST --- I discussed this with Adam, and we agreed that: - Operation on illegal volumes are ok, can use now set_illegal=False - Atomic operations on volume metadata are ok, can use new set_illegal=False - Any other operation on volume data or qcow2 metadata must set the volume to illegal before the operation and the volume should remain illegal if the operation failed.
Now that BZ1405938 is solved and the infrastructure has the ability to determine if the volume will be illegal or not on failure, the amend operation should be changed to use the new infrastructure.
Verified with the following code: ------------------------------------------- ovirt-engine-4.1.1-0.0.master.20170126161333.git83fd7e0.el7.centos.noarch vdsm-4.19.3-1.gitdfa4d67.el7.centos.x86_64 Verified with the following scenario: ------------------------------------------ 1. On a system with the DC and Cluster with compatibility ver 4.0 create a new VM with block disks 2. Upgrade the DC and Cluster 3. Set the block image LV to inactive 4. Amend the volume - fails to amend - volume is not in illegal state Moving to VERIFIED!
Moving to verified based on Comment 2