Spec URL: https://radez.fedorapeople.org/python-heat-translator.spec SRPM URL: https://radez.fedorapeople.org/python-heat-translator-0.6.0-1.fc25.src.rpm Description: Heat-Translator is an Openstack project and licensed under Apache 2. It is a command line tool which takes non-Heat templates as an input and produces a Heat Orchestration Template (HOT) which can be deployed by Heat. Currently the development and testing is done with an aim to translate OASIS Topology and Orchestration Specification for Cloud Applications (TOSCA) templates to HOT. However, the tool is designed to be easily extended to use with any format other than TOSCA. Fedora Account System Username: radez
I have a few initial comments on the spec: - python3 subpackage build should be optional, we only have it in Fedora for now. - We're missing doc creation and a doc subpackage. - Ideally, we should have a tests subpackage including the unit tests, instead of simply removing them in %prep. This would also allow us to have a %check section to run unit tests during packaging. You can use https://github.com/openstack-packages/openstack-example-spec/blob/master/python-example-library.spec as an example to fix the above items. That said, let's run a quick licensecheck and iterate on the spec review using review.rdoproject.org. We'll give the final approval here in the bz.
$ licensecheck -r . ./translator/tests/test_utils.py: *No copyright* Apache (v2.0) ./translator/tests/test_tosca_hot_translation.py: *No copyright* Apache (v2.0) ./translator/tests/test_template.py: *No copyright* Apache (v2.0) ./translator/tests/test_shell.py: *No copyright* Apache (v2.0) ./translator/tests/test_conf.py: *No copyright* Apache (v2.0) ./translator/tests/data/artifacts/wordpress/wordpress_install.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/wordpress/wordpress_configure.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/webserver/webserver_start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/webserver/webserver_install.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/ssh/ssh_import_public_key.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/ssh/ssh_generate_keys.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/rsyslog/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/rsyslog/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/rsyslog/config.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/nodejs/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/nodejs/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/nodejs/config.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mysql/mysql_dbms_start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mysql/mysql_dbms_install.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mysql/mysql_dbms_configure.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mysql/mysql_database_configure.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mongodb/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mongodb/create_database.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mongodb/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/mongodb/config.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/logstash/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/logstash/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/logstash/configure_rsyslog.py: *No copyright* Apache (v2.0) ./translator/tests/data/artifacts/logstash/configure_elasticsearch.py: *No copyright* Apache (v2.0) ./translator/tests/data/artifacts/logstash/configure_collectd.py: *No copyright* Apache (v2.0) ./translator/tests/data/artifacts/kibana/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/kibana/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/kibana/config.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/elasticsearch/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/elasticsearch/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/collectd/start.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/collectd/create.sh: *No copyright* UNKNOWN ./translator/tests/data/artifacts/collectd/config.py: *No copyright* Apache (v2.0) ./translator/tests/base.py: Apache (v2.0) ./translator/shell.py: *No copyright* Apache (v2.0) ./translator/osc/v1/translate.py: *No copyright* Apache (v2.0) ./translator/osc/v1/tests/utils.py: *No copyright* Apache (v2.0) ./translator/osc/v1/tests/test_translate.py: *No copyright* Apache (v2.0) ./translator/osc/v1/tests/fakes.py: *No copyright* Apache (v2.0) ./translator/osc/utils.py: *No copyright* Apache (v2.0) ./translator/osc/osc_plugin.py: *No copyright* Apache (v2.0) ./translator/hot/translate_outputs.py: *No copyright* Apache (v2.0) ./translator/hot/translate_node_templates.py: *No copyright* Apache (v2.0) ./translator/hot/translate_inputs.py: *No copyright* Apache (v2.0) ./translator/hot/tosca_translator.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_webserver.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_web_application.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_software_component.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_policies_scaling.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_policies.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_object_storage.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_network_port.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_network_network.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_dbms.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_database.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_compute.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_cluster_policies_scaling.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_block_storage_attachment.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tosca_block_storage.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tests/test_tosca_policies.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tests/test_tosca_objectstore.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tests/test_tosca_compute.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tests/test_tosca_blockstorage.py: *No copyright* Apache (v2.0) ./translator/hot/tosca/tests/test_tosca_autoscaling.py: *No copyright* Apache (v2.0) ./translator/hot/tests/test_translate_outputs.py: *No copyright* Apache (v2.0) ./translator/hot/tests/test_translate_inputs.py: *No copyright* Apache (v2.0) ./translator/hot/tests/test_hot_parameter.py: *No copyright* Apache (v2.0) ./translator/hot/syntax/hot_template.py: *No copyright* Apache (v2.0) ./translator/hot/syntax/hot_resource.py: *No copyright* Apache (v2.0) ./translator/hot/syntax/hot_parameter.py: *No copyright* Apache (v2.0) ./translator/hot/syntax/hot_output.py: *No copyright* Apache (v2.0) ./translator/conf/config.py: *No copyright* Apache (v2.0) ./translator/conf/__init__.py: *No copyright* Apache (v2.0) ./translator/common/utils.py: *No copyright* Apache (v2.0) ./translator/common/images.py: *No copyright* Apache (v2.0) ./translator/common/flavors.py: *No copyright* Apache (v2.0) ./translator/common/exception.py: *No copyright* Apache (v2.0) ./translator/__init__.py: *No copyright* Apache (v2.0) ./setup.py: Apache (v2.0) GENERATED FILE ./run_py27-tosca-parser-master.sh: *No copyright* UNKNOWN ./heat_translator.py: *No copyright* Apache (v2.0) ./doc/source/conf.py: Apache (v2.0) ./LICENSE: *No copyright* GENERATED FILE The module is using the Apache 2.0 license.
Ok, updated the spec, do you want an updated srpm? It seems there may be an error in the exmaple rpm, on f25 when I try and build I get: dradez@tirreno:~/fedora-scm➤ rpmbuild -bs python-heat-translator.spec error: line 178: Package does not exist: %files python3-heat-translator I'll poke at that and see if I can figure out what it means. Mean time, let me know if we need more updates to the spec. Thanks!
Spec and SRPM files as approved in the Gerrit review: Spec: https://raw.githubusercontent.com/rdo-packages/heat-translator-distgit/rpm-master/python-heat-translator.spec SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/47/4147/37/gate/DLRN-rpmbuild/Z8e0b01d510c64c00bb00417e3881245b/artifacts/centos/repos/40/48/40485206458722833f94995e1950a855eb5a995e_dev/python-heat-translator-0.6.1-0.20170110150001.4048520.el7.centos.src.rpm
https://review.rdoproject.org/r/4257 has a small fix to allow fedora-review to run.
Updated files with the fix: Spec: https://raw.githubusercontent.com/rdo-packages/heat-translator-distgit/rpm-master/python-heat-translator.spec SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/57/4257/3/gate/DLRN-rpmbuild/Zca66078f0fa24ea0b1304ac60f4ad2e1/artifacts/centos/repos/af/ee/afee6dbfe8efad53746ea1d614c130bbce2d1fe5_dev/python-heat-translator-0.6.1-0.20170110185128.afee6db.el7.centos.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Check did not completechecksum differs and there are problems running diff. Please verify manually. See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 161 files have unknown license. Detailed output of licensecheck in /tmp/heat-tr/review- python-heat-translator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -heat-translator , python2-heat-translator-tests , python-heat- translator-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-heat-translator-0.6.1-0.20170110185128.afee6db.el7.centos.noarch.rpm python2-heat-translator-tests-0.6.1-0.20170110185128.afee6db.el7.centos.noarch.rpm python-heat-translator-doc-0.6.1-0.20170110185128.afee6db.el7.centos.noarch.rpm python-heat-translator-0.6.1-0.20170110185128.afee6db.el7.centos.src.rpm python2-heat-translator.noarch: E: no-changelogname-tag python2-heat-translator.noarch: W: no-documentation python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator-2.7 python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator-2 python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator python2-heat-translator-tests.noarch: E: no-changelogname-tag python2-heat-translator-tests.noarch: W: no-documentation python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/config.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/ssh/ssh_generate_keys.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/create_database.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/start.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/create.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/ssh/ssh_import_public_key.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/create.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/rsyslog/config.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/config.sh 644 /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/start.sh 644 /bin/bash python-heat-translator-doc.noarch: E: no-changelogname-tag python-heat-translator-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-heat-translator-doc-0.6.1/html/.buildinfo python-heat-translator.src: E: no-changelogname-tag python-heat-translator.src:191: W: macro-in-comment %check python-heat-translator.src: W: invalid-url Source0: heat-translator-0.6.1.dev53-0.20170110185128.afee6db.tar.gz 4 packages and 0 specfiles checked; 14 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python-heat-translator-doc.noarch: E: no-changelogname-tag python-heat-translator-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-heat-translator-doc-0.6.1/html/.buildinfo python2-heat-translator.noarch: E: no-changelogname-tag python2-heat-translator.noarch: W: no-documentation python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator-2.7 python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator python2-heat-translator.noarch: W: no-manual-page-for-binary heat-translator-2 python2-heat-translator-tests.noarch: E: no-changelogname-tag python2-heat-translator-tests.noarch: W: no-documentation python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/config.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/create_database.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/create.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/start.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/rsyslog/config.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/start.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/nodejs/config.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/ssh/ssh_generate_keys.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/mongodb/create.sh 0644L /bin/bash python2-heat-translator-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/translator/tests/data/artifacts/ssh/ssh_import_public_key.sh 0644L /bin/bash 3 packages and 0 specfiles checked; 13 errors, 6 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/heat-tr/python-heat-translator.spec 2017-01-10 22:00:48.232696512 +0100 +++ /tmp/heat-tr/review-python-heat-translator/srpm-unpacked/python-heat-translator.spec 2017-01-10 19:51:28.000000000 +0100 @@ -1,2 +1,4 @@ +%global dlrn 1 +%define upstream_version 0.6.1.dev53 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} @@ -13,11 +15,11 @@ Name: python-%{library} -Version: 0.6.1 -Release: 0.20170110185128.afee6db +Version: 0.6.1 +Release: 0.20170110185128.afee6db%{?dist} Summary: OpenStack Heat Translator License: ASL 2.0 URL: http://launchpad.net/%{library}/ -Source0: http://tarballs.openstack.org/%{library}/%{library}-master.tar.gz +Source0: heat-translator-0.6.1.dev53-0.20170110185128.afee6db.tar.gz BuildArch: noarch @@ -227,4 +229,2 @@ %changelog -* Mon Dec 19 2016 Dan Radez <dradez> - 0.6.1.dev35-1 -- Initial Packaging Requires -------- python-heat-translator-doc (rpmlib, GLIBC filtered): python2-heat-translator (rpmlib, GLIBC filtered): /usr/bin/python2 PyYAML python(abi) python-babel python-cliff python-dateutil python-glanceclient python-heatclient python-keystoneauth1 python-novaclient python-pbr python-requests python-six python-tosca-parser python2-heat-translator-tests (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python python(abi) python-coverage python-fixtures python-hacking python-oslo-sphinx python-oslotest python-sphinx python-subunit python-testrepository python-testscenarios python-testtools python-tosca-parser python2-heat-translator Provides -------- python-heat-translator-doc: python-heat-translator-doc python2-heat-translator: python-heat-translator python2-heat-translator python2-heat-translator-tests: python2-heat-translator-tests Source checksums ---------------- http://tarballs.openstack.org/heat-translator/heat-translator-master.tar.gz : CHECKSUM(SHA256) this package : ERROR CHECKSUM(SHA256) upstream package : f3b2da4a71795dd414cef7c8711d14613def393bbc22701522617a1aba8d1c82 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n python-heat-translator -m dlrn Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 * The differences in spec and source tarball are expected, being a DLRN SRPM. * The dist tag is also expected due to using DLRN. The package is APPROVED.
Imported and built in trunk by DLRN.