Spec URL: https://radez.fedorapeople.org/openstack-tacker.spec Description: Tacker is an OpenStack based NFV Orchestrator service with built-in general purpose VNF Manager to deploy and operate Virtual Network Functions (VNFs) on an OpenStack based NFV Platform. It is based on ETSI MANO Architectural Framework and provides full functional stack to orchestrate VNFs end-to-end. RDO Gerrit Username: radez
Initial licensecheck output: $ licensecheck -r . ./tools/with_venv.sh: Apache (v2.0) ./tools/prepare_functional_test.sh: *No copyright* UNKNOWN ./tools/ostestr_compat_shim.sh: *No copyright* UNKNOWN ./tools/install_venv_common.py: Apache (v2.0) ./tools/install_venv.py: Apache (v2.0) ./tools/i18n_cfg.py: *No copyright* Apache (v2.0) ./tools/generate_config_file_sample.sh: *No copyright* Apache (v2.0) ./tools/clean.sh: *No copyright* UNKNOWN ./tools/check_i18n.py: Apache (v2.0) ./tacker/wsgi.py: Apache (v2.0) ./tacker/vnfm/vim_client.py: Apache (v2.0) ./tacker/vnfm/tosca/utils.py: Apache (v2.0) ./tacker/vnfm/plugin.py: Apache (v2.0) ./tacker/vnfm/monitor_drivers/token.py: Apache (v2.0) ./tacker/vnfm/monitor_drivers/ping/ping.py: *No copyright* Apache (v2.0) ./tacker/vnfm/monitor_drivers/http_ping/http_ping.py: *No copyright* Apache (v2.0) ./tacker/vnfm/monitor_drivers/ceilometer/ceilometer.py: *No copyright* Apache (v2.0) ./tacker/vnfm/monitor_drivers/abstract_driver.py: *No copyright* Apache (v2.0) ./tacker/vnfm/monitor.py: Apache (v2.0) ./tacker/vnfm/mgmt_drivers/openwrt/openwrt.py: Apache (v2.0) ./tacker/vnfm/mgmt_drivers/noop.py: Apache (v2.0) ./tacker/vnfm/mgmt_drivers/constants.py: Apache (v2.0) ./tacker/vnfm/mgmt_drivers/abstract_driver.py: Apache (v2.0) ./tacker/vnfm/keystone.py: Apache (v2.0) ./tacker/vnfm/infra_drivers/scale_driver.py: *No copyright* Apache (v2.0) ./tacker/vnfm/infra_drivers/openstack/translate_template.py: *No copyright* Apache (v2.0) ./tacker/vnfm/infra_drivers/openstack/openstack.py: Apache (v2.0) ./tacker/vnfm/infra_drivers/openstack/heat_client.py: *No copyright* Apache (v2.0) ./tacker/vnfm/infra_drivers/noop.py: Apache (v2.0) ./tacker/vnfm/infra_drivers/heat/heat.py: Apache (v2.0) ./tacker/vnfm/infra_drivers/abstract_driver.py: Apache (v2.0) ./tacker/vnfm/constants.py: Apache (v2.0) ./tacker/version.py: Apache (v2.0) ./tacker/tests/utils.py: Apache (v2.0) ./tacker/tests/unit/vm/test_vim_client.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/test_toscautils.py: Apache (v2.0) ./tacker/tests/unit/vm/test_tosca_templates_under_samples.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/test_plugin.py: Apache (v2.0) ./tacker/tests/unit/vm/test_monitor.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/test_alarm_receiver.py: Apache (v2.0) ./tacker/tests/unit/vm/nfvo/test_nfvo_plugin.py: Apache (v2.0) ./tacker/tests/unit/vm/nfvo/drivers/vnffg/sfc_drivers/networking-sfc/test_n_sfc.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/nfvo/drivers/vim/test_openstack_driver.py: Apache (v2.0) ./tacker/tests/unit/vm/monitor_drivers/ping/test_ping.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/monitor_drivers/http_ping/test_http_ping.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/vm/infra_drivers/openstack/test_openstack.py: Apache (v2.0) ./tacker/tests/unit/vm/infra_drivers/heat/test_heat.py: Apache (v2.0) ./tacker/tests/unit/testlib_api.py: Apache (v2.0) ./tacker/tests/unit/test_wsgi.py: Apache (v2.0) ./tacker/tests/unit/test_tacker_context.py: Apache (v2.0) ./tacker/tests/unit/test_post_mortem_debug.py: Apache (v2.0) ./tacker/tests/unit/test_policy.py: Apache (v2.0) ./tacker/tests/unit/test_hacking.py: *No copyright* Apache (v2.0) ./tacker/tests/unit/test_extensions.py: Apache (v2.0) ./tacker/tests/unit/test_extension_extended_attribute.py: Apache (v2.0) ./tacker/tests/unit/test_db_purge_delete.py: Apache (v2.0) ./tacker/tests/unit/test_db_migration.py: Apache (v2.0) ./tacker/tests/unit/test_config.py: Apache (v2.0) ./tacker/tests/unit/test_common_utils.py: Apache (v2.0) ./tacker/tests/unit/test_common_services_plugin.py: Apache (v2.0) ./tacker/tests/unit/test_common_log.py: Apache (v2.0) ./tacker/tests/unit/test_auth.py: Apache (v2.0) ./tacker/tests/unit/test_attributes.py: Apache (v2.0) ./tacker/tests/unit/test_api_v2_resource.py: Apache (v2.0) ./tacker/tests/unit/test_api_v2_extension.py: Apache (v2.0) ./tacker/tests/unit/test_api_v2.py: Apache (v2.0) ./tacker/tests/unit/test_api_api_common.py: Apache (v2.0) ./tacker/tests/unit/services/vm/test_servicevm_extension.py: Apache (v2.0) ./tacker/tests/unit/extensions/v2attributes.py: Apache (v2.0) ./tacker/tests/unit/extensions/foxinsocks.py: Apache (v2.0) ./tacker/tests/unit/extensions/extensionattribute.py: Apache (v2.0) ./tacker/tests/unit/extensions/extendedattribute.py: Apache (v2.0) ./tacker/tests/unit/extension_stubs.py: Apache (v2.0) ./tacker/tests/unit/db/utils.py: Apache (v2.0) ./tacker/tests/unit/db/base.py: Apache (v2.0) ./tacker/tests/unit/database_stubs.py: Apache (v2.0) ./tacker/tests/unit/base.py: Apache (v2.0) ./tacker/tests/unit/_test_rootwrap_exec.py: Apache (v2.0) GENERATED FILE ./tacker/tests/unit/__init__.py: Apache (v2.0) ./tacker/tests/tools.py: Apache (v2.0) ./tacker/tests/post_mortem_debug.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_vnfm_param.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_vnfd.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_vnf_multiple_vdu.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_vnf_monitoring.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_vnf.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_tosca_vnfd.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_tosca_vnf_scale.py: *No copyright* Apache (v2.0) ./tacker/tests/functional/vnfm/test_tosca_vnf_multiple_vdu.py: Apache (v2.0) ./tacker/tests/functional/vnfm/test_tosca_vnf.py: Apache (v2.0) ./tacker/tests/functional/nfvo/test_vim.py: Apache (v2.0) ./tacker/tests/functional/keystone.py: Apache (v2.0) ./tacker/tests/functional/clients.py: *No copyright* Apache (v2.0) ./tacker/tests/functional/base.py: Apache (v2.0) ./tacker/tests/contrib/post_test_hook_lib.sh: *No copyright* Apache (v2.0) ./tacker/tests/contrib/post_test_hook.sh: *No copyright* Apache (v2.0) ./tacker/tests/contrib/README: *No copyright* UNKNOWN ./tacker/tests/constants.py: *No copyright* Apache (v2.0) ./tacker/tests/base.py: Apache (v2.0) ./tacker/services/service_base.py: Apache (v2.0) ./tacker/service.py: Apache (v2.0) ./tacker/policy.py: Apache (v2.0) ./tacker/plugins/common_services/common_services_plugin.py: Apache (v2.0) ./tacker/plugins/common/utils.py: Apache (v2.0) ./tacker/plugins/common/constants.py: Apache (v2.0) ./tacker/nfvo/nfvo_plugin.py: Apache (v2.0) ./tacker/nfvo/drivers/vnffg/sfc_drivers/noop.py: Apache (v2.0) ./tacker/nfvo/drivers/vnffg/abstract_vnffg_driver.py: *No copyright* Apache (v2.0) ./tacker/nfvo/drivers/vim/openstack_driver.py: Apache (v2.0) ./tacker/nfvo/drivers/vim/abstract_vim_driver.py: *No copyright* Apache (v2.0) ./tacker/manager.py: Apache (v2.0) ./tacker/hacking/checks.py: Apache (v2.0) ./tacker/extensions/vnfm.py: Apache (v2.0) ./tacker/extensions/nfvo_plugins/vnffg.py: Apache (v2.0) ./tacker/extensions/nfvo.py: Apache (v2.0) ./tacker/extensions/common_services.py: Apache (v2.0) ./tacker/db/vnfm/vnfm_db.py: Apache (v2.0) ./tacker/db/types.py: *No copyright* Apache (v2.0) ./tacker/db/sqlalchemyutils.py: Apache (v2.0) ./tacker/db/nfvo/vnffg_db.py: Apache (v2.0) ./tacker/db/nfvo/nfvo_db.py: Apache (v2.0) ./tacker/db/models_v1.py: Apache (v2.0) ./tacker/db/model_base.py: Apache (v2.0) ./tacker/db/migration/purge_tables.py: Apache (v2.0) ./tacker/db/migration/models/head.py: Apache (v2.0) ./tacker/db/migration/cli.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/f958f58e5daa_uuid_consistency.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/d4f265e8eb9d_add_default_to_vim.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/c7cde2f45f82_set_description_to_text.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/b07673bb8654_set_status_type_tenant_id_length.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/acf941e54075_add_error_reason_to_device.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/README: *No copyright* UNKNOWN ./tacker/db/migration/alembic_migrations/versions/HEAD: *No copyright* UNKNOWN ./tacker/db/migration/alembic_migrations/versions/941b5a6fff9e_enable_soft_delete.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/81ffa86020d_rpc_proxy.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/6e56d4474b2a_blob_to_json_text.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/5f88e86b35c7_make_vnfd_vnf_vim_name_mandatory.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/5958429bcb3c_modify_datatype_of_value.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/5246a6bd410f_multisite_vim.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/507122918800_adds_vnffg.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/4ee19c8a6d0a_audit_support_events.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/4c31092895b8_remove_service_instance.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/354de64ba129_set_mandatory_columns_not_null.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/2ff0a0e360f1_audit_support.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/2774a42c7163_remove_service_related.py: Apache (v2.0) GENERATED FILE ./tacker/db/migration/alembic_migrations/versions/24bec5f211c7_alter_value_in_deviceattributes.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/22f5385a3d50_rename_devicedb.py: Apache (v2.0) GENERATED FILE ./tacker/db/migration/alembic_migrations/versions/22f5385a3d4f_remove_proxydb.py: Apache (v2.0) GENERATED FILE ./tacker/db/migration/alembic_migrations/versions/22f5385a3d3f_add_status_to_vims.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/1c6b0d82afcd_servicevm_framework.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/13c0e0661015_add_descrition_to_vnf.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/versions/12a57080b278_alter_devices.py: Apache (v2.0) GENERATED FILE ./tacker/db/migration/alembic_migrations/versions/12a57080b277_add_service_db.py: Apache (v2.0) GENERATED FILE ./tacker/db/migration/alembic_migrations/versions/0ae5b1ce3024_unique_constraint_name.py: Apache (v2.0) ./tacker/db/migration/alembic_migrations/env.py: Apache (v2.0) ./tacker/db/migration/__init__.py: Apache (v2.0) ./tacker/db/migration/README: Apache (v2.0) ./tacker/db/db_base.py: Apache (v2.0) ./tacker/db/common_services/common_services_db.py: Apache (v2.0) ./tacker/db/api.py: Apache (v2.0) ./tacker/context.py: Apache (v2.0) ./tacker/common/utils.py: Apache (v2.0) ./tacker/common/topics.py: Apache (v2.0) ./tacker/common/test_lib.py: Apache (v2.0) MIT/X11 (BSD like) ./tacker/common/rpc.py: Apache (v2.0) ./tacker/common/log.py: Apache (v2.0) ./tacker/common/exceptions.py: Apache (v2.0) ./tacker/common/driver_manager.py: Apache (v2.0) ./tacker/common/constants.py: Apache (v2.0) ./tacker/common/config.py: Apache (v2.0) ./tacker/common/cmd_executer.py: *No copyright* Apache (v2.0) ./tacker/common/clients.py: *No copyright* Apache (v2.0) ./tacker/cmd/server.py: Apache (v2.0) ./tacker/auth.py: Apache (v2.0) ./tacker/api/views/versions.py: Apache (v2.0) ./tacker/api/versions.py: Apache (v2.0) ./tacker/api/v1/router.py: Apache (v2.0) ./tacker/api/v1/resource_helper.py: Apache (v2.0) ./tacker/api/v1/resource.py: Apache (v2.0) ./tacker/api/v1/base.py: Apache (v2.0) ./tacker/api/v1/attributes.py: Apache (v2.0) ./tacker/api/extensions.py: Apache (v2.0) ./tacker/api/api_common.py: Apache (v2.0) ./tacker/alarm_receiver.py: Apache (v2.0) ./tacker/agent/linux/utils.py: Apache (v2.0) ./tacker/_i18n.py: *No copyright* Apache (v2.0) ./tacker/__init__.py: Apache (v2.0) ./setup.py: Apache (v2.0) GENERATED FILE ./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE ./etc/init.d/tacker-server: *No copyright* UNKNOWN ./doc/source/conf.py: Apache (v2.0) ./doc/Makefile: *No copyright* GENERATED FILE ./devstack/settings: *No copyright* UNKNOWN ./devstack/plugin.sh: *No copyright* UNKNOWN ./devstack/lib/tacker: *No copyright* UNKNOWN ./api-ref/source/v1/vnfs.inc: *No copyright* UNKNOWN ./api-ref/source/v1/vnffgs.inc: *No copyright* UNKNOWN ./api-ref/source/v1/vnffgds.inc: *No copyright* UNKNOWN ./api-ref/source/v1/vnfds.inc: *No copyright* UNKNOWN ./api-ref/source/v1/vims.inc: *No copyright* UNKNOWN ./api-ref/source/v1/versions.inc: *No copyright* UNKNOWN ./api-ref/source/v1/sfcs.inc: *No copyright* UNKNOWN ./api-ref/source/v1/nfps.inc: *No copyright* UNKNOWN ./api-ref/source/v1/extensions.inc: *No copyright* UNKNOWN ./api-ref/source/v1/events.inc: *No copyright* UNKNOWN ./api-ref/source/v1/classifiers.inc: *No copyright* UNKNOWN ./api-ref/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE ./LICENSE: *No copyright* GENERATED FILE The project is licensed using the Apache 2.0 license. Looking at the git history, it was originally based on the Neutron code, which is ok.
Spec and SRPM reviewed in Gerrit: - Spec: https://raw.githubusercontent.com/rdo-packages/tacker-distgit/rpm-master/openstack-tacker.spec - SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/13/4213/10/gate/DLRN-rpmbuild/Z6c7ed7b5f9a64436aeedace0ef5160a8/artifacts/centos/repos/53/c1/53c1c0464bcf1cd1fe22c197be8dbb58bff8c9a0_dev/openstack-tacker-0.5.1-0.20170116162734.53c1c04.el7.centos.src.rpm Please note that the SRPM has been generated by DLRN, so some differences regarding Version/Release are expected.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Apache (v2.0) MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 265 files have unknown license. Detailed output of licensecheck in /tmp/watcher/review-openstack-tacker/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/rootwrap.d, /etc/tacker [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /etc/logrotate.d, /etc/tacker, /etc/rootwrap.d, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://tarballs.openstack.org/tacker/tacker-0.5.1.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- tacker , python-tacker-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: openstack-tacker-0.5.1-0.20170116162734.53c1c04.el7.centos.noarch.rpm python-tacker-0.5.1-0.20170116162734.53c1c04.el7.centos.noarch.rpm python-tacker-doc-0.5.1-0.20170116162734.53c1c04.el7.centos.noarch.rpm openstack-tacker-0.5.1-0.20170116162734.53c1c04.el7.centos.src.rpm openstack-tacker.noarch: E: no-changelogname-tag openstack-tacker.noarch: W: no-documentation openstack-tacker.noarch: W: non-standard-uid /var/log/tacker tacker openstack-tacker.noarch: W: non-standard-gid /var/log/tacker tacker openstack-tacker.noarch: W: no-manual-page-for-binary tacker-db-manage openstack-tacker.noarch: W: no-manual-page-for-binary tacker-server openstack-tacker.noarch: W: no-manual-page-for-binary tacker-rootwrap python-tacker.noarch: E: no-changelogname-tag python-tacker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/tacker/cmd/server.py /usr/bin/env python python-tacker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tacker/cmd/server.py 644 /usr/bin/env python python-tacker-doc.noarch: E: no-changelogname-tag python-tacker-doc.noarch: W: file-not-utf8 /usr/share/doc/python-tacker-doc-0.5.1/html/objects.inv openstack-tacker.src: E: no-changelogname-tag openstack-tacker.src: W: invalid-url Source0: tacker-0.5.1.dev140-0.20170116162734.53c1c04.tar.gz 4 packages and 0 specfiles checked; 6 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- openstack-tacker.noarch: E: no-changelogname-tag openstack-tacker.noarch: W: only-non-binary-in-usr-lib openstack-tacker.noarch: W: no-documentation openstack-tacker.noarch: W: non-standard-uid /var/log/tacker tacker openstack-tacker.noarch: W: non-standard-gid /var/log/tacker tacker openstack-tacker.noarch: W: no-manual-page-for-binary tacker-db-manage openstack-tacker.noarch: W: no-manual-page-for-binary tacker-rootwrap openstack-tacker.noarch: W: no-manual-page-for-binary tacker-server python-tacker.noarch: E: no-changelogname-tag python-tacker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tacker/cmd/server.py 0644L /usr/bin/env python-tacker-doc.noarch: E: no-changelogname-tag 3 packages and 0 specfiles checked; 4 errors, 7 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/watcher/openstack-tacker.spec 2017-01-18 18:32:29.210307897 +0100 +++ /tmp/watcher/review-openstack-tacker/srpm-unpacked/openstack-tacker.spec 2017-01-16 17:27:34.000000000 +0100 @@ -1,2 +1,4 @@ +%global dlrn 1 +%define upstream_version 0.5.1.dev140 %global pypi_name tacker @@ -7,11 +9,11 @@ Name: openstack-%{pypi_name} -Version: 0.5.1 -Release: 0.20170116162734.53c1c04 +Version: 0.5.1 +Release: 0.20170116162734.53c1c04%{?dist} Summary: OpenStack Tacker Service License: ASL 2.0 URL: https://launchpad.net/%{pypi_name} -Source0: http://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{version}.tar.gz +Source0: tacker-0.5.1.dev140-0.20170116162734.53c1c04.tar.gz Source1: openstack-tacker-server.service Source2: tacker.logrotate @@ -184,4 +186,2 @@ %changelog -* Mon Dec 19 2016 Dan Radez <dradez> - 0.5.0-1 -- Initial Packaging Requires -------- openstack-tacker (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-tacker) python-tacker python-tacker-doc shadow-utils python-tacker (rpmlib, GLIBC filtered): python(abi) python-alembic python-anyjson python-babel python-crypto python-eventlet python-heat-translator python-heatclient python-keystoneclient python-keystonemiddleware python-kombu python-netaddr python-neutronclient python-novaclient python-oslo-concurrency python-oslo-config python-oslo-context python-oslo-db python-oslo-log python-oslo-messaging python-oslo-middleware python-oslo-policy python-oslo-reports python-oslo-rootwrap python-oslo-serialization python-oslo-service python-oslo-sphinx python-oslo-utils python-paramiko python-paste python-paste-deploy python-requests python-routes python-six python-sqlalchemy python-stevedore python-tosca-parser python-webob python-tacker-doc (rpmlib, GLIBC filtered): Provides -------- openstack-tacker: config(openstack-tacker) openstack-tacker python-tacker: python-tacker python-tacker-doc: python-tacker-doc Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n openstack-tacker -m dlrn Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 * The differences between the spec from the review and srpm are due to the SRPM being generated by DLRN, so they are expected. Same for the dist tag being present. The package is APPROVED.
This landed so closing.