Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1406751

Summary: [RFE] align ovirt-engine maven dependencies with WildFly 11 BOM
Product: [oVirt] ovirt-engine Reporter: Eyal Edri <eedri>
Component: Build.MavenAssignee: Ori Liel <oliel>
Status: CLOSED DEFERRED QA Contact: Ori Liel <oliel>
Severity: medium Docs Contact:
Priority: unspecified    
Version: futureCC: bugs, juan.hernandez, lsvaty, mperina, vtunka
Target Milestone: ---Keywords: CodeChange, FutureFeature
Target Release: ---Flags: sbonazzo: ovirt-4.2-
lsvaty: testing_plan_complete-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-05 13:33:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1475459    
Bug Blocks:    

Description Eyal Edri 2016-12-21 12:08:32 UTC
Description of problem:
ovirt-engine specifies today all the build time & run-time maven dependencies 
in the pom.xml files of the project.

However, the versions specified in the pom.xml doesn't reflect the real versions that are actually being used in run time which are provided by jboss wildfly.

This pose a problem when trying to scan the project for any outdated dependencies and actually shows a wrong status of which versions are being used.

The purpose of this RFE is to align what ovirt-engine defines in its pom.xml file with the REAL versions provided by the wildfly version it uses.

The full list of wildfly 7 can be found here:
https://mvnrepository.com/artifact/org.wildfly.bom/wildfly-javaee7


Version-Release number of selected component (if applicable):
master

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Yaniv Kaul 2017-03-12 19:22:27 UTC
Oved - is it your team in charge of this?
Can you assess the work needed, the risk and the value?

Comment 2 Oved Ourfali 2017-03-27 15:07:25 UTC
Moving to Martin.

Comment 3 Martin Perina 2017-03-28 10:06:26 UTC
(In reply to Yaniv Kaul from comment #1)
> Oved - is it your team in charge of this?
> Can you assess the work needed, the risk and the value?

So in general we should always bump versions in pom.xml to match oldest available version in both WildFly and EAP after each significant upgrade. But in practise we do that only when needed (for example if WildFly/EAP provides some newer version of the library and we want to use those new features). Generally we don't need to do that unless backward compatibility of some library broke, so we need to rebuild engine, because on runtime we always use version provided either by WildFly/EAP or package provided by OS or custom dependency (on upstream included within engine itself, on downstream part of rhevm-dependencies).

I'll try to go over our current status and update 4.1 needed. If no change required than I'd would leave it to the moment we upgrade to WildFly 11.

Comment 4 Yaniv Kaul 2017-06-07 20:51:40 UTC
(In reply to Martin Perina from comment #3)
> (In reply to Yaniv Kaul from comment #1)
> > Oved - is it your team in charge of this?
> > Can you assess the work needed, the risk and the value?
> 
> So in general we should always bump versions in pom.xml to match oldest
> available version in both WildFly and EAP after each significant upgrade.
> But in practise we do that only when needed (for example if WildFly/EAP
> provides some newer version of the library and we want to use those new
> features). Generally we don't need to do that unless backward compatibility
> of some library broke, so we need to rebuild engine, because on runtime we
> always use version provided either by WildFly/EAP or package provided by OS
> or custom dependency (on upstream included within engine itself, on
> downstream part of rhevm-dependencies).
> 
> I'll try to go over our current status and update 4.1 needed. If no change
> required than I'd would leave it to the moment we upgrade to WildFly 11.

Can you update? I think WildFly 11 will come before our next release even.

Comment 5 Martin Perina 2017-07-27 09:09:56 UTC
I will take a look what's needed in this area once we upgrade to WildFly 11

Comment 6 Yaniv Kaul 2017-11-16 14:11:03 UTC
(In reply to Martin Perina from comment #5)
> I will take a look what's needed in this area once we upgrade to WildFly 11

Any updates?

Comment 7 Ori Liel 2018-01-03 07:34:42 UTC
https://gerrit.ovirt.org/#/c/85776/

Comment 8 Martin Perina 2018-01-05 13:33:30 UTC
We have found that it's very tricky to use WildFly BOM file and not all dependencies were found on that file. We will fix dependencies manually as a part of BZ1406766, but don't want to spent more time on BOM file now