Created attachment 1237077 [details]
Showing Enabled Menu item
Description of problem:
When defining a new rate for chargeback of container Images, the predefined "Default Container Image Rate" can be edited.
This causes CFME to be unable to produce any chargeback for images reports.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Navigate to Cloud Intel --> Chargeback --> Rates
2.Select Default Container Image Rate
3.Click on Configuration button
4. View drop-down
The menu item: Configuration --> Edit this Chargeback rate is enabled
The menu item: Configuration --> Edit this Chargeback rate should be disabled.
The implication of being able to edit this specific rate is that once edited (e.g. change the rate's name) CFME is unable to generate any chargeback for images reports.
Ari, would you be willing to take a look into this one?
See discussion in https://github.com/ManageIQ/manageiq/pull/13359
Thanks a lot. I'll use the extra time for cleaning this up for the longterm.
Simon, I think that if I make the name uneditable we should be done.
What do you think?
What is the user story behind this container rate?
Based on the user-story for this default container compute rate, we could tell:
- if it be true 'default' rate? What is meaning of default, really?
- or Should we create new 'Compute for Containers'?
I don't know all this so I don't have a strong opinion. That being said, Ari, I will trust your judgment on what needs to be done here. :)
I tested under 5.8.03, the 'Default Container Image Rate' is editable.
Ari how come this failed QE? Can you check with Gilad?
IIUC https://github.com/ManageIQ/manageiq-ui-classic/pull/269 was merged on the 21st of Feb and should have been in 18.104.22.168 (1st of Mar).
Gilad, you should be able to edit the rates but NOT the description (which is the scenario that causes the problem)
Can you check again?
the UI behaviour for the "default rate" is different to the behaviour for the "default container image rate"
In the default rate, the dropdown "Edit" button is not available to the user.
In the default container image rate, the dropdown "Edit" is available, the user is able to edit the name of the rate, but, when pressing the "Add" button, the user is presented with an error:
"Can not change description of 'Default Container Image Rate'"
Obviously this is very confusing to the user.
So, indeed, the report will not be generated, but,the UI-UX is inconsistent.
I am returning this BZ back to dev, to resolve the issue and disable the "edit" option for this rate, as is the behaviour of the "default" rate.
Here is the status:
- From functionality point of view this is fully functional as defined by PMs:
* "Default Container Image Rate" - is editabe (only rates not the name or description)
* "Default Container Image Rate" - can not be deleted through the UI
The above is exactly the functionality defined by PM for this rate.
If one can not add/edit the amounts in this rate, there will be no default rates for containers.
- This bug was reopened due to a UI inconsistent behaviour:
* the fact the one can edit a default rate (the other default rate can not be edited)
* when editing the "Default Container Image Rate" you can not edit the description (as the charge back engine looks for this defaule rate by name)
So Moving this bug to ON_QA and please verify the above functionality.
Please open a different bu on the UI inconsistencies.