Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version-1.0.1-1.fc26.src.rpm Description: Provides a RubyVersion class to simplify checking for the right Ruby version in your programs. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500697/
Taking. I would appreciate it if you would review my review request (bug 1409355)
Well, a simple gem based rpm. Some requests: * Exclude files not needed for runtime The following files are not needed and for developing purpose (mainly for test suite). Please consider to remove the below. - %{gem_instdir}/spec/ - %{gem_instdir}/Gemfile - %{gem_instdir}/Gemfile.lock - %{gem_instdir}/Rakefile Note that for spec/ directory, curret ruby guideline requests that test files should not be packaged: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites See "Do not ship tests". Otherwise okay.
* Additionally: - Also consider to remove %{gem_instdir}/ruby_version.gemspec , this is not needed for runtime (%{gem_spec} is needed, of course)
Just update the %files list, then I can approve this package.
Thanks for the review! I will review rubygem-tk package yet... Updated version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-2/rubygem-ruby_version.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-2/rubygem-ruby_version-1.0.1-2.fc26.src.rpm %changelog * Mon Jan 23 2017 František Dvořák <valtri.cz> - 1.0.1-2 - Exclude unnecessary files
Okay. * license okay (MIT) * spec file clean * source matches upstream * builds fine * installation fine * rpmlint sane * general functionality okay $ ruby -e 'require "ruby_version" ; p RubyVersion.is > "2.3"' true ====================================================== This package (rubygem-ruby_version) is APPROVED by mtasaka ======================================================
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-ruby_version