Bug 1414002 - Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
Summary: Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1414004
TreeView+ depends on / blocked
 
Reported: 2017-01-17 14:24 UTC by František Dvořák
Modified: 2017-01-25 13:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-25 13:52:37 UTC
Type: ---
mtasaka: fedora-review+


Attachments (Terms of Use)

Description František Dvořák 2017-01-17 14:24:40 UTC
Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version-1.0.1-1.fc26.src.rpm
Description: Provides a RubyVersion class to simplify checking for the right Ruby version in your programs.
Fedora Account System Username: valtri

COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500697/

Comment 1 Mamoru TASAKA 2017-01-17 14:54:24 UTC
Taking.

I would appreciate it if you would review my review request (bug 1409355)

Comment 2 Mamoru TASAKA 2017-01-20 07:23:19 UTC
Well, a simple gem based rpm.

Some requests:
* Exclude files not needed for runtime
  The following files are not needed and for developing purpose
  (mainly for test suite). Please consider to remove the below.

  - %{gem_instdir}/spec/
  - %{gem_instdir}/Gemfile
  - %{gem_instdir}/Gemfile.lock
  - %{gem_instdir}/Rakefile

   Note that for spec/ directory, curret ruby guideline requests
   that test files should not be packaged:
   https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
   See "Do not ship tests".

Otherwise okay.

Comment 3 Mamoru TASAKA 2017-01-20 09:13:37 UTC
* Additionally:
  - Also consider to remove %{gem_instdir}/ruby_version.gemspec , this is
    not needed for runtime
    (%{gem_spec} is needed, of course)

Comment 4 Mamoru TASAKA 2017-01-22 14:48:33 UTC
Just update the %files list, then I can approve this package.

Comment 5 František Dvořák 2017-01-23 16:29:30 UTC
Thanks for the review! I will review rubygem-tk package yet...

Updated version:

Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-2/rubygem-ruby_version.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-2/rubygem-ruby_version-1.0.1-2.fc26.src.rpm

%changelog
* Mon Jan 23 2017 František Dvořák <valtri@civ.zcu.cz> - 1.0.1-2
- Exclude unnecessary files

Comment 6 Mamoru TASAKA 2017-01-24 09:20:22 UTC
Okay.

* license okay (MIT)
* spec file clean
* source matches upstream
* builds fine
* installation fine
* rpmlint sane
* general functionality okay

$ ruby -e 'require "ruby_version" ; p RubyVersion.is > "2.3"'
true

======================================================
  This package (rubygem-ruby_version) is APPROVED
  by mtasaka
======================================================

Comment 7 Gwyn Ciesla 2017-01-25 13:18:56 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-ruby_version


Note You need to log in before you can comment on or make changes to this bug.