Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for-0.1.3-1.fc26.src.rpm Description: Mark specs pending or skipped for specific Ruby engine (e.g. MRI or JRuby) / version combinations. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500704/
If you are still interested in this, first please upgrade to 0.1.4. Anyway taking. By the way, I would appreciate it if you would review my review request (bug 1446927)
Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.5-1/rubygem-rspec-pending_for.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.5-1/rubygem-rspec-pending_for-0.1.5-1.fc26.src.rpm The new version. I'll take the review, thanks!
One note: * Possibly unneeded files - Please check if the files under bin/ is really needed. Looks like these are scripts used for development or for installation process, and don't seem to be needed for runtime (and actually these don't seem useful) Otherwise okay. - spec file clean - rpmlint clean - license okay (MIT) - builds fine (F-27, F-26) - installation okay - basic functionality okay ------------------------------------------------ This package (rubygem-rspec-pending_for) is APPROVED by mtasaka ------------------------------------------------
You're right, binaries in %{gem_instdir}/bin/ can be excluded. Thanks!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-rspec-pending_for
rubygem-rspec-pending_for-0.1.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d
rubygem-rspec-pending_for-0.1.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d
rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d
rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d
rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.