Bug 1414004 - Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine
Summary: Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1414001 1414002
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-17 14:26 UTC by František Dvořák
Modified: 2017-05-19 14:57 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-08 14:20:53 UTC
Type: ---
mtasaka: fedora-review+


Attachments (Terms of Use)

Description František Dvořák 2017-01-17 14:26:14 UTC
Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for.spec
SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for-0.1.3-1.fc26.src.rpm
Description: Mark specs pending or skipped for specific Ruby engine (e.g. MRI or JRuby) / version combinations.
Fedora Account System Username: valtri

COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500704/

Comment 1 Mamoru TASAKA 2017-04-30 15:18:00 UTC
If you are still interested in this, first please upgrade to 0.1.4.
Anyway taking.

By the way, I would appreciate it if you would review my review request (bug 1446927)

Comment 3 Mamoru TASAKA 2017-05-02 13:43:59 UTC
One note:

* Possibly unneeded files
  - Please check if the files under bin/ is really needed.
    Looks like these are scripts used for development or for installation
    process, and don't seem to be needed for runtime
    (and actually these don't seem useful)

Otherwise okay.
- spec file clean
- rpmlint clean
- license okay (MIT)
- builds fine (F-27, F-26)
- installation okay
- basic functionality okay

------------------------------------------------
  This package (rubygem-rspec-pending_for) is
  APPROVED by mtasaka
------------------------------------------------

Comment 4 František Dvořák 2017-05-03 11:12:48 UTC
You're right, binaries in %{gem_instdir}/bin/ can be excluded. Thanks!

Comment 5 Gwyn Ciesla 2017-05-03 12:43:00 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-rspec-pending_for

Comment 6 Fedora Update System 2017-05-03 14:14:31 UTC
rubygem-rspec-pending_for-0.1.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d

Comment 7 Fedora Update System 2017-05-03 14:14:38 UTC
rubygem-rspec-pending_for-0.1.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d

Comment 8 Fedora Update System 2017-05-04 18:55:13 UTC
rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d

Comment 9 Fedora Update System 2017-05-04 22:06:20 UTC
rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d

Comment 10 Fedora Update System 2017-05-08 14:20:53 UTC
rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2017-05-19 14:57:29 UTC
rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.