Bug 1414655 - Upcall: Possible memleak if inode_ctx_set fails
Summary: Upcall: Possible memleak if inode_ctx_set fails
Alias: None
Product: GlusterFS
Classification: Community
Component: upcall
Version: 3.8
Hardware: All
OS: All
Target Milestone: ---
Assignee: Soumya Koduri
QA Contact:
Depends On: 1412489
Blocks: 1414654
TreeView+ depends on / blocked
Reported: 2017-01-19 07:22 UTC by Soumya Koduri
Modified: 2017-02-20 12:34 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1412489
Last Closed: 2017-02-20 12:34:24 UTC
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:

Attachments (Terms of Use)

Description Soumya Koduri 2017-01-19 07:22:43 UTC
+++ This bug was initially created as a clone of Bug #1412489 +++

Description of problem:

In __upcall_inode_ctx_set() if __inode_ctx_set() fails, we should be freeing the allocated inode_ctx. That's not the case now. Thanks Nithya for the pointer.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

--- Additional comment from Worker Ant on 2017-01-12 03:53:34 EST ---

REVIEW: http://review.gluster.org/16381 (Upcall: Fix possible memleak when inode_ctx_set fails) posted (#1) for review on master by soumya k (skoduri@redhat.com)

--- Additional comment from Worker Ant on 2017-01-12 10:47:27 EST ---

COMMIT: http://review.gluster.org/16381 committed in master by Jeff Darcy (jdarcy@redhat.com) 
commit 84271e12efb783bfc83133329b0fd18aba729c84
Author: Soumya Koduri <skoduri@redhat.com>
Date:   Thu Jan 12 14:19:31 2017 +0530

    Upcall: Fix possible memleak when inode_ctx_set fails
    In __upcall_inode_ctx_set(), if inode_ctx_set fails we should
    free allocated memory for ctx. This patch takes care of the same.
    Change-Id: Iafb42787151a579caf6f396c9b414ea48d16e6b4
    BUG: 1412489
    Reported-by: Nithya Balachandran <nbalacha@redhat.com>
    Signed-off-by: Soumya Koduri <skoduri@redhat.com>
    Reviewed-on: http://review.gluster.org/16381
    Reviewed-by: N Balachandran <nbalacha@redhat.com>
    Smoke: Gluster Build System <jenkins@build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy@redhat.com>

Comment 1 Worker Ant 2017-01-19 07:26:12 UTC
REVIEW: http://review.gluster.org/16431 (Upcall: Fix possible memleak when inode_ctx_set fails) posted (#1) for review on release-3.8 by soumya k (skoduri@redhat.com)

Comment 2 Niels de Vos 2017-02-20 12:34:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.9, please open a new bug report.

glusterfs-3.8.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-February/000066.html
[2] https://www.gluster.org/pipermail/gluster-users/

Note You need to log in before you can comment on or make changes to this bug.