Bug 1414787 - Hide tracebacks in engine.log by upgrading non responsive host
Summary: Hide tracebacks in engine.log by upgrading non responsive host
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.1.3
: 4.1.3.3
Assignee: Ravi Nori
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-19 12:49 UTC by Lucie Leistnerova
Modified: 2017-07-06 13:15 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-06 13:15:59 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+
mgoldboi: planning_ack+
mperina: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)
engine log (1.94 MB, text/plain)
2017-02-27 14:33 UTC, sefi litmanovich
no flags Details
engine.log.2 (13.60 KB, text/plain)
2017-05-03 10:27 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 71325 0 master MERGED engine: Hide tracebacks in engine.log by upgrading non responsive host 2017-01-30 16:31:27 UTC
oVirt gerrit 71813 0 ovirt-engine-4.1 MERGED engine: Hide tracebacks in engine.log by upgrading non responsive host 2017-02-08 08:26:19 UTC
oVirt gerrit 73276 0 master MERGED engine: Hide tracebacks in engine.log for non responsive host 2017-03-07 14:21:21 UTC
oVirt gerrit 74601 0 ovirt-engine-4.1 MERGED engine: Hide tracebacks in engine.log for non responsive host 2017-03-27 15:21:05 UTC
oVirt gerrit 77260 0 master MERGED engine : Hide tracebacks in engine.log by upgrading non responsive host 2017-05-25 13:36:21 UTC
oVirt gerrit 77595 0 ovirt-engine-4.1 MERGED engine : Hide tracebacks in engine.log by upgrading non responsive host 2017-06-01 08:29:47 UTC

Description Lucie Leistnerova 2017-01-19 12:49:41 UTC
Description of problem:
According to BZ 1388117 hide traceback in engine.log when host is in maintenance and upgrade fails because of non responsive host.

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.0-0.4.master.20170118090304.git86ab9ea.el7.centos.noarch

2017-01-19 09:54:23,057+01 INFO  [org.ovirt.engine.core.vdsbroker.SetVdsStatusVDSCommand] (pool-5-thread-1) [193f2106-775d-4c18-8ee7-721919c4f89b] FINISH, SetVdsStatusVDSCommand, log id: 7640ad73
2017-01-19 09:54:26,084+01 ERROR [org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase] (pool-5-thread-1) [193f2106-775d-4c18-8ee7-721919c4f89b] Error during host XX.XX.XX.XX install: org.apache.sshd.common.RuntimeSshException: Failed to get the session.
        at org.apache.sshd.client.future.DefaultConnectFuture.getSession(DefaultConnectFuture.java:43)
        at org.ovirt.engine.core.uutils.ssh.SSHClient.connect(SSHClient.java:310) [uutils.jar:]
...

2017-01-19 09:54:26,098+01 ERROR [org.ovirt.engine.core.bll.host.HostUpgradeManager] (pool-5-thread-1) [193f2106-775d-4c18-8ee7-721919c4f89b] Failed to update host 'vmhost05' packages 'libvirt-daemon-config-nwfilter, rubygem-fluent-plugin-rewrite-tag-filter, ioprocess, mom, collectd-disk, collectd-virt, qemu-kvm, ovirt-vmconsole-host, ovirt-imageio-common, vdsm-cli, libvirt-client, collectd-netlink, libvirt-python, lvm2, libvirt-lock-sanlock, rubygem-fluent-plugin-secure-forward, ovirt-imageio-daemon, python-ioprocess, collectd, collectd-write_http, fluentd, libvirt-daemon-kvm, qemu-img, ovirt-vmconsole, sanlock, vdsm'.
2017-01-19 09:54:26,098+01 ERROR [org.ovirt.engine.core.bll.host.HostUpgradeManager] (pool-5-thread-1) [193f2106-775d-4c18-8ee7-721919c4f89b] Exception: org.apache.sshd.common.RuntimeSshException: Failed to get the session.
        at org.apache.sshd.client.future.DefaultConnectFuture.getSession(DefaultConnectFuture.java:43)
        at org.ovirt.engine.core.uutils.ssh.SSHClient.connect(SSHClient.java:310) [uutils.jar:]
...

Comment 1 Martin Perina 2017-01-20 08:58:26 UTC
If host is in Maintenance, then check for upgrades should not be executed? What are exact reproducing steps for it?

Comment 2 Lucie Leistnerova 2017-01-20 09:12:45 UTC
It is not the check for upgrade, but upgrade itself. In General tab there is an Upgrade link and after clicking on it the error appears in engine log.

Comment 3 sefi litmanovich 2017-02-27 14:32:30 UTC
Re opening the bug, seems that while the trace from 'org.ovirt.engine.core.bll.host.HostUpgradeManager' doesn't appear in engine.log (without debug mode), some other traces now appear as can be seen in the attached engine.log.
The action's invocation time stamp in the log is: 15:43:12,435+02 INFO.

Comment 4 Red Hat Bugzilla Rules Engine 2017-02-27 14:32:33 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 5 sefi litmanovich 2017-02-27 14:33:06 UTC
Created attachment 1258112 [details]
engine log

Comment 6 Lucie Leistnerova 2017-05-03 10:25:50 UTC
Traceback in org.ovirt.engine.core.bll.host.HostUpgradeManager is hidden, but in org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase still visible

Steps to reproduce:
1. add newest repo to host
2. in engine on host Installation -> Check for upgrade, in General tab is Upgrade link available
3. put host to maintenance
4. stop sshd on host
5. try to upgrade host from engine

engine.log attached
tested in ovirt-engine-4.1.2-0.1.el7.noarch

Comment 7 Red Hat Bugzilla Rules Engine 2017-05-03 10:25:54 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Lucie Leistnerova 2017-05-03 10:27:46 UTC
Created attachment 1275870 [details]
engine.log.2

Comment 9 Martin Perina 2017-06-14 13:26:06 UTC
Moving back to 4.1.4 as it's part of 4.1.3.2 build

Comment 10 rhev-integ 2017-06-16 16:44:29 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'ovirt-engine-4.1.3.4' doesn't contain patch 'https://gerrit.ovirt.org/71813']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.1.3.4

For more info please contact: infra

Comment 11 Martin Perina 2017-06-16 16:58:53 UTC
(In reply to rhev-integ from comment #10)
> INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following
> reason:
> 
> [Tag 'ovirt-engine-4.1.3.4' doesn't contain patch
> 'https://gerrit.ovirt.org/71813']
> gitweb:
> https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/
> ovirt-engine-4.1.3.4
> 
> For more info please contact: infra

Not true, all attached pacthes have been merged to ovirt-engine-4.1 branch before June 1st

Comment 12 Lucie Leistnerova 2017-06-19 13:37:34 UTC
traceback in org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase is also hidden

verified in ovirt-engine-4.1.3.4-0.1.el7.noarch


Note You need to log in before you can comment on or make changes to this bug.