Bug 1418973 - removing warning related to enum, to let the build take place without errors for 3.10
Summary: removing warning related to enum, to let the build take place without errors ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: ---
Assignee: hari gowtham
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: 1419846
TreeView+ depends on / blocked
 
Reported: 2017-02-03 10:24 UTC by hari gowtham
Modified: 2017-05-30 18:40 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1419846 (view as bug list)
Environment:
Last Closed: 2017-05-30 18:40:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description hari gowtham 2017-02-03 10:24:34 UTC
Description of problem:

The usage of two different enums checked under one enum in the function glusterd_remove_brick_validate_bricks might cause serious issues when the function uses various cases.

How reproducible:
no change in the current functionality. 
Build will throw errors. 

Steps to Reproduce:
1.with the source code trying to make it
2.will throw warnings
3.will fail if we try to build packages.

Actual results:
build failure with error

Expected results:
To build without error and work in future without breaking.

Additional info:

Comment 1 Worker Ant 2017-02-03 10:33:07 UTC
REVIEW: https://review.gluster.org/16539 (Tier: remove warning related to the enum) posted (#1) for review on master by hari gowtham (hari.gowtham005)

Comment 2 Worker Ant 2017-02-03 11:08:20 UTC
REVIEW: https://review.gluster.org/16539 (Tier: remove warning related to the enum) posted (#2) for review on master by hari gowtham (hari.gowtham005)

Comment 3 Worker Ant 2017-02-06 07:10:09 UTC
REVIEW: https://review.gluster.org/16539 (Tier: remove warning related to the enum) posted (#3) for review on master by hari gowtham (hari.gowtham005)

Comment 4 Worker Ant 2017-02-06 11:27:46 UTC
REVIEW: https://review.gluster.org/16539 (Tier: remove warning related to the enum) posted (#4) for review on master by hari gowtham (hari.gowtham005)

Comment 5 Worker Ant 2017-02-07 05:12:33 UTC
COMMIT: https://review.gluster.org/16539 committed in master by Atin Mukherjee (amukherj) 
------
commit f2133923b8d8851943c5676b88c5ce67725eabe5
Author: hari gowtham <hgowtham>
Date:   Fri Feb 3 15:55:47 2017 +0530

    Tier: remove warning related to the enum
    
    PROBLEM: In the tier as a service patch the enums for tier (from
    gf1_op_command and gf_defrag_command) are put into a single enum
    gf_defrag_command which causes a warning that will make the build
    fail.
    
    FIX: send both the enum and eliminate the warning.
    
    Change-Id: I899ff622dfb07134e6459aa65f65ea7252765293
    BUG: 1418973
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/16539
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 6 Shyamsundar 2017-05-30 18:40:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.