Bug 1422099 - VM lease selection in webadmin is enabled when it shouldn't
Summary: VM lease selection in webadmin is enabled when it shouldn't
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.3
: 4.1.3
Assignee: Tal Nisan
QA Contact: Lilach Zitnitski
URL:
Whiteboard:
: 1434381 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-14 13:22 UTC by Tal Nisan
Modified: 2017-07-06 13:10 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-06 13:10:20 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 72268 0 master MERGED webadmin: VM lease can be selected even if not supported by version 2017-05-16 10:38:24 UTC
oVirt gerrit 74681 0 ovirt-engine-4.1 MERGED webadmin: VM lease can be selected even if not supported by version 2017-05-16 11:06:19 UTC

Description Tal Nisan 2017-02-14 13:22:16 UTC
There are two problems:
The lease selection should be disabled once high availability is set to false yet this is overriden by the version check, if leases are supported then the field becomes enabled

If the lease selection is disabled since it's not supported by the cluster version, toggling high availability will enable the selection even though leases are not supported

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce 1: 
1. Try to add a new in a cluster version supporting VM leases
2. Go to High Availability tab

Actual results:
VM lease selection is available although it shouldn't (HA is not set)

Expected results:
VM lease selection should be disabled


Steps to Reproduce 2: 
1. Try to add a new in a cluster version not supporting VM leases
2. Go to High Availability tab (VM leases selection will be disabled)
3. Click on high Availility checkbox

Actual results:
VM lease selection is not available although it shouldn't (cluster version does not support it)

Expected results:
VM lease selection should still be disabled

Comment 1 Tal Nisan 2017-03-22 14:41:33 UTC
*** Bug 1434381 has been marked as a duplicate of this bug. ***

Comment 3 Lilach Zitnitski 2017-05-29 06:44:01 UTC
--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.3-0.1.el7.noarch
vdsm-4.19.16-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce 1:
1. Try to add a new VM in a cluster version supporting VM leases
2. Go to High Availability tab

Actual results:
VM lease selection is disabled

Steps to Reproduce 2: 
1. Try to add a new VM in a cluster version not supporting VM leases
2. Go to High Availability tab (VM leases selection will be disabled)
3. Click on high Availability checkbox

Actual results:
VM lease is still disabled 

Moving to VERIFIED!


Note You need to log in before you can comment on or make changes to this bug.