Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1422099

Summary:	VM lease selection in webadmin is enabled when it shouldn't
Product:	[oVirt] ovirt-engine	Reporter:	Tal Nisan <tnisan>
Component:	BLL.Storage	Assignee:	Tal Nisan <tnisan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lilach Zitnitski <lzitnits>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.0	CC:	amureini, bugs, cmestreg, stirabos
Target Milestone:	ovirt-4.1.3	Flags:	rule-engine: ovirt-4.1+
Target Release:	4.1.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-06 13:10:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tal Nisan 2017-02-14 13:22:16 UTC

There are two problems:
The lease selection should be disabled once high availability is set to false yet this is overriden by the version check, if leases are supported then the field becomes enabled

If the lease selection is disabled since it's not supported by the cluster version, toggling high availability will enable the selection even though leases are not supported

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce 1: 
1. Try to add a new in a cluster version supporting VM leases
2. Go to High Availability tab

Actual results:
VM lease selection is available although it shouldn't (HA is not set)

Expected results:
VM lease selection should be disabled


Steps to Reproduce 2: 
1. Try to add a new in a cluster version not supporting VM leases
2. Go to High Availability tab (VM leases selection will be disabled)
3. Click on high Availility checkbox

Actual results:
VM lease selection is not available although it shouldn't (cluster version does not support it)

Expected results:
VM lease selection should still be disabled

Comment 1 Tal Nisan 2017-03-22 14:41:33 UTC

*** Bug 1434381 has been marked as a duplicate of this bug. ***

Comment 3 Lilach Zitnitski 2017-05-29 06:44:01 UTC

--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.3-0.1.el7.noarch
vdsm-4.19.16-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce 1:
1. Try to add a new VM in a cluster version supporting VM leases
2. Go to High Availability tab

Actual results:
VM lease selection is disabled

Steps to Reproduce 2: 
1. Try to add a new VM in a cluster version not supporting VM leases
2. Go to High Availability tab (VM leases selection will be disabled)
3. Click on high Availability checkbox

Actual results:
VM lease is still disabled 

Moving to VERIFIED!