Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1422278

Summary: libvirt: avoid generating script with empty path
Product: Red Hat OpenStack Reporter: Guil Barros <gbarros>
Component: openstack-novaAssignee: Eoghan Glynn <eglynn>
Status: CLOSED DUPLICATE QA Contact: Prasanth Anbalagan <panbalag>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.0 (Liberty)CC: berrange, dasmith, eglynn, kchamart, sbauza, sferdjao, sgordon, srevivo, vromanso
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-14 23:54:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Guil Barros 2017-02-14 23:28:49 UTC 
With OSP10 being our long-term support version, I'm requesting this backport from Mitaka/Ocata.

Previously, libvirt just appended 'script=' onto the QEMU cmd line
according to what <script path=''/> contained, letting QEMU execute the
script.  That was flawed from security POV (you don't want QEMU to be
allowed to execute anything), so newer libvirt (as of [1]) executes the
script now.  But the libvirt code doesn't allow this corner case (of
allowing and ignoring an empty script path) whereas apparently the QEMU
code does.

So the Nova setting of '' used to work by accident, but now does not.

[1]
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=9c17d66 (autocreate
tap device for ethernet network type)
Comment 1 Stephen Gordon 2017-02-14 23:54:13 UTC 
Bugs tracking the need for this in every actively supported RHOSP release were opened as soon as we found out about it.

*** This bug has been marked as a duplicate of bug 1416881 ***
Comment 2 Stephen Gordon 2017-02-15 00:07:25 UTC 

*** This bug has been marked as a duplicate of bug 1408464 ***