Description of problem: Files like extras/group-virt.example should have comments for each option. Unfortunately it is likely that glusterd does not handle the comments correctly. Changes like https://review.gluster.org/16577 now mention the reasons for the options in the related bug report, but that is not easily accessible for people that install Gluster packages and do not have the sources available. To enable easier testing of optimal values, and have users understand the advise to use certain options, comments in the config files are crucial. Please add support for reading comments in these files to GlusterD, and copy the comments from the bugzilla reports into the option files. Thanks!
IMO, the profile file itself talks about what kind of workload the set of tunables are meant for. And gluster volume help does provide the list of volume tunables with the description of each of them. With that mind, the priority of this bug stays low and in near future I don't plan to work on this.
This can be done by making some changes in the way we read profile files. If we start considering json/yaml model for reading profile file.
(In reply to Amar Tumballi from comment #2) > If we start considering json/yaml model for reading profile file. I do not know of a reason why we want to change the format completely. It would be sufficient to have lines starting with # as comments and ignore these while applying the key/values.
Let's address this as part of intern activity this year.
REVIEW: https://review.gluster.org/23277 (cli - group files to set volume options supports comments) posted (#1) for review on master by Barak Sason Rofman
REVIEW: https://review.gluster.org/23277 (cli - group files to set volume options supports comments) merged (#5) on master by Atin Mukherjee