Bug 1433751 - [RFE] 'gluster volume get' should implement the way to retrieve volume options using the volume name 'all'
Summary: [RFE] 'gluster volume get' should implement the way to retrieve volume option...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: glusterd
Version: rhgs-3.3
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: RHGS 3.3.0
Assignee: Atin Mukherjee
QA Contact: Bala Konda Reddy M
URL:
Whiteboard:
Depends On: 1322212 1378842
Blocks: 1417138
TreeView+ depends on / blocked
 
Reported: 2017-03-19 19:29 UTC by Atin Mukherjee
Modified: 2017-09-21 04:57 UTC (History)
11 users (show)

Fixed In Version: glusterfs-3.8.4-19
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1378842
Environment:
Last Closed: 2017-09-21 04:33:25 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2774 0 normal SHIPPED_LIVE glusterfs bug fix and enhancement update 2017-09-21 08:16:29 UTC

Description Atin Mukherjee 2017-03-19 19:29:55 UTC
+++ This bug was initially created as a clone of Bug #1378842 +++

+++ This bug was initially created as a clone of Bug #1322212 +++

Description of problem:
-----------------------
When setting the global options, 'gluster volume set' provides a way to set them using the volume name as 'all'

But 'gluster volume get' doesn't implement 'all' to get the global options.
So in order to get the global volume options one has to use 'gluster volume get' with specific volume name. This usage makes the illusion as though the option is set only on one volume, which is incorrect.

Retrieving the global volume options ( like op-version, etc ) using the volume name as 'all' should be implemented with 'gluster volume get' functionality


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gluster 3.7.9 & mainline 

How reproducible:
-----------------
N/A as this is a Feature Request for 'gluster volume get' functionality

Steps to Reproduce:
-------------------
N/A as this is a Feature Request for 'gluster volume get' functionality

Actual results:
---------------
With current implementation, the global options are retrieved with 'gluster volume get' functionality using the specific volume name

Expected results:
-----------------
'gluster volume get' to implement the way to get the global options using - "gluster volume get all"

--- Additional comment from Worker Ant on 2016-09-23 08:49:38 EDT ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#1) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-11-24 04:54:57 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#2) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-11-24 06:10:34 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#3) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-11-28 06:02:47 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#4) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-11-28 06:22:09 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#5) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-01 07:42:16 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#6) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-02 06:59:44 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#7) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-23 07:08:14 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#8) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-23 08:23:08 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#9) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-27 04:06:35 EST ---

REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#10) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-30 23:47:31 EST ---

COMMIT: http://review.gluster.org/15563 committed in master by Atin Mukherjee (amukherj) 
------
commit 08056421b886b1ebf1e0eed93d9f6f9b6d017489
Author: Samikshan Bairagya <samikshan>
Date:   Fri Sep 23 16:35:15 2016 +0530

    glusterd, cli: Get global options through volume get functionality
    
    Currently it is not possible to retrieve values of global options
    by using the 'gluster volume get' functionality if there are no
    volumes present. In order to get the global options one has to use
    'gluster volume get' with a specific volume name. This usage makes
    the illusion as though the option is set only on one volume, which
    is incorrect. When setting the global options, 'gluster volume set'
    provides a way to set them using the volume name as 'all'.
    
    Similarly, retrieving the global options should be made possible by
    using the volume name 'all' with the 'gluster volume get'
    functionality. This patch adds that functionality to 'volume get'
    
    Usage:
    	# gluster volume get all <OPTION/all>
    
    Change-Id: Ic2fdb9eda69d4806d432dae26d117d9660fe6d4e
    BUG: 1378842
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: http://review.gluster.org/15563
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

--- Additional comment from Shyamsundar on 2017-03-06 12:27:39 EST ---

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 2 Atin Mukherjee 2017-03-19 19:30:44 UTC
upstream patch : http://review.gluster.org/15563

Comment 4 Atin Mukherjee 2017-03-24 09:22:18 UTC
downstream patch : https://code.engineering.redhat.com/gerrit/#/c/101299/

Comment 6 Bala Konda Reddy M 2017-04-24 11:13:00 UTC
version: 3.8.4.22

[root@dhcp37-135 gluster]# gluster vol get all all
Option                                  Value                                   
------                                  -----                                   
cluster.server-quorum-ratio             51                                      
cluster.enable-shared-storage           disable                                 
cluster.op-version                      31001                                   
cluster.brick-multiplex                 disable 

gluster vol get all all will retrieve the global options set.

Comment 8 errata-xmlrpc 2017-09-21 04:33:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774

Comment 9 errata-xmlrpc 2017-09-21 04:57:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774


Note You need to log in before you can comment on or make changes to this bug.