Bug 1434410 - Review Request: python-compreffor - CFF table subroutinizer for FontTools
Summary: Review Request: python-compreffor - CFF table subroutinizer for FontTools
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1435230
TreeView+ depends on / blocked
 
Reported: 2017-03-21 13:03 UTC by Athos Ribeiro
Modified: 2017-07-17 04:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-17 04:51:11 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Athos Ribeiro 2017-03-21 13:03:45 UTC
Spec URL: https://athoscr.fedorapeople.org/packaging/python-compreffor.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/python-compreffor-0.4.4-1.fc25.src.rpm

Description: A CFF (Compact Font Format) table subroutinizer for FontTools.

Fedora Account System Username: athoscr

Comment 1 Fabio Valentini 2017-07-05 11:54:48 UTC
Package Review
==============

(...)
[x]: Package complies to the Packaging Guidelines
(...)
[x]: Package meets the Packaging Guidelines::Python
(...)


A koji scratch build was successful on rawhide for all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20339987
So the commented "BuildArch: noarch" can definitely be removed.

Minor nitpick: Remove the leading "A" in the summary line.

Those "issues" can be fixed prior to importing and building.

Package approved.

Comment 2 Athos Ribeiro 2017-07-05 13:36:07 UTC
Thank you for the review, Fabio!

I will fix the pointed issues before importing

Comment 3 Gwyn Ciesla 2017-07-05 13:56:21 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-compreffor

Comment 4 Fedora Update System 2017-07-06 14:28:51 UTC
python-compreffor-0.4.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c325ea8aa9

Comment 5 Fedora Update System 2017-07-09 02:52:34 UTC
python-compreffor-0.4.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c325ea8aa9

Comment 6 Fedora Update System 2017-07-17 04:51:11 UTC
python-compreffor-0.4.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.