Version-Release number of selected component (if applicable): firefox-52.0-6.fc25.x86_64, which introduced respecting the GNOME setting /org/gnome/terminal/legacy/dark-theme if E10s is enabled How reproducible: always Steps to Reproduce: 1. Make sure /org/gnome/terminal/legacy/dark-theme is set to False (see also: Gnome-Tweak-Tool → Appearance → Global Dark Theme to On 2. Open Firefox (any profile with a history or bookmarks) 3. Make sure e10s is enabled (check on about:support) 4. Focus urlbar (by click or by pressing Ctrl+L) 5. type anything 6. have a look at the URLs in the dropdown menu for suggestions from history and bookmarks Actual results: URLs are drawn in dark blue on dark gray, leaving it barely readable. Expected results: Higher contrast between URLs and dropdown menu background color. Additional info: Gtk+ fixed this bug a while ago. See section "Links" in https://git.gnome.org/browse/gtk+/tree/gtk/theme/Adwaita/gtk-contained-dark.css?h=gtk-3-22#n1403
Created attachment 1266501 [details] A screenshot of firefox urlbar with dark Adwaita theme And the original bug report #1421143 has a screenshot for this bug: https://bugzilla.redhat.com/attachment.cgi?id=1249035 but with firefox 52.0-6.fc25 the situation got worse.
Created attachment 1266518 [details] Screencap from liferea, same issue when dark desktop theme enabled I see the same thing after force-enabling e10s. Also, this is a problem with liferea as well. GTK issue?
New FF allows to use dark theme for UI (title bar, tabs) and light theme for web content when e10s is enabled. Looks like it needs some more fixes to make it usable.
I see this regression also affects combobox dropdown on web page content which should be also light.
(In reply to Dimitris from comment #2) > Created attachment 1266518 [details] > Screencap from liferea, same issue when dark desktop theme enabled > > I see the same thing after force-enabling e10s. Also, this is a problem > with liferea as well. GTK issue? I thought this has been fixed in Gtk+ (see above) and LibreOffice (see bug #1287593 point 6). I am not sure whether this is a Gtk+ issue or specific to liferea. See https://github.com/lwindolf/liferea/issues/444 for an upstream liferea bug report. (In reply to Martin Stransky from comment #4) > I see this regression also affects combobox dropdown on web page content > which should be also light. Oh, I didn't notice that. Of course, having a dark dropdown menu for a light button is weird. So the dropdown menu must become light too. This is a small issue though, because dropdown menus are still readable.
Also, dropdown menus of forms (saved input strings or saved login names) are drawn dark, but should be drawn light (same issue as combobox dropdown).
Okay, I reverted the dark theme patch, fixed in firefox-52.0-7.
(In reply to Martin Stransky from comment #7) > Okay, I reverted the dark theme patch, fixed in firefox-52.0-7. BTW: why don't you set the version number to 52.0.1 if it has the patch to CVE-2017-5428?
(In reply to Christian Stadelmann from comment #8) > (In reply to Martin Stransky from comment #7) > > Okay, I reverted the dark theme patch, fixed in firefox-52.0-7. > > BTW: why don't you set the version number to 52.0.1 if it has the patch to > CVE-2017-5428? Because the package version match upstream tarball version used in the package which is 52.0.
Created attachment 1266650 [details] Contact details from contacts.google.com in edit mode There is also an issue with several google sites where the text in form fields appears white on white background. I stumbled upon it yesterday, when I tried to fill in a questionnaire and today I went to contacts.google.com to edit a contact and I couldn't see anything in edit mode (see attachment). Funny thing, the "Submit" button here on RHBZ has black text on dark gray background, while the "Browse" button and the drop-down menus are white on dark gray.
(In reply to Alexander Ploumistos from comment #10) > Created attachment 1266650 [details] > Contact details from contacts.google.com in edit mode > > There is also an issue with several google sites where the text in form > fields appears white on white background. I stumbled upon it yesterday, when > I tried to fill in a questionnaire and today I went to contacts.google.com > to edit a contact and I couldn't see anything in edit mode (see attachment). > > Funny thing, the "Submit" button here on RHBZ has black text on dark gray > background, while the "Browse" button and the drop-down menus are white on > dark gray. This is a different bug (#1421143) because it affects the content process.
firefox-52.0-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e2f9d36e4
firefox-52.0-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-702ea62bb1
firefox-52.0-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b5b9751fd
firefox-52.0-7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-702ea62bb1
firefox-52.0-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b5b9751fd
firefox-52.0-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e2f9d36e4
firefox-52.0-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
firefox-52.0-7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
firefox-52.0.2-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-85f5f525f1
firefox-52.0.2-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-85f5f525f1
firefox-52.0.2-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
I'm on 52.0.2-2.fc25, and with global dark theme enabled, /org/gnome/terminal/legacy/dark-theme false (non-existent in dconf), e10s enabled. - With widget.chrome.allow-gtk-dark-theme enabled, URLs in the dropdown still hard to read, dark blue over dark gray background. - With widget.chrome.allow-gtk-dark-theme disabled, FF not using dark theme.