Bug 1438794 - [RFE] Install Windows virtio-rng drivers on VMs imported
Summary: [RFE] Install Windows virtio-rng drivers on VMs imported
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1439733
TreeView+ depends on / blocked
 
Reported: 2017-04-04 12:32 UTC by Yaniv Kaul
Modified: 2017-04-11 20:55 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
: 1439733 (view as bug list)
Environment:
Last Closed: 2017-04-11 20:55:19 UTC
Embargoed:


Attachments (Terms of Use)

Description Yaniv Kaul 2017-04-04 12:32:26 UTC
Description of problem:
I don't think today we install the driver for virtio-rng on Windows VMs. We should install it on supported OSes automatically.

Comment 1 Richard W.M. Jones 2017-04-04 16:10:24 UTC
Although we don't install it (we don't install any drivers on
Windows except the virtio-blk driver), we do copy all applicable
drivers to %systemroot%\Drivers\VirtIO, and then we add that
path to the relevant registry key so that Windows will install
them if it finds the appropriate PCI device.

There seem to be two issues:

(1) I can't find the virtio-rng driver in virtio-win (1.9.0-3.el7).
Are we shipping it and if so where?

(2) We are not adding a virtio-rng device to the libvirt that
virt-v2v generates.  This is a bug in virt-v2v.

Comment 2 Cole Robinson 2017-04-04 16:13:50 UTC
(In reply to Richard W.M. Jones from comment #1)
> 
> (1) I can't find the virtio-rng driver in virtio-win (1.9.0-3.el7).
> Are we shipping it and if so where?

It should be on the .iso, but not in the host 'drivers' directory, due to https://bugzilla.redhat.com/show_bug.cgi?id=1167941

Comment 3 Richard W.M. Jones 2017-04-04 16:18:18 UTC
Fair enough: I've found the RNG driver in the ISO now.

In that case it's just a bug in virt-v2v, so cancelling NEEDINFO.

Comment 4 Richard W.M. Jones 2017-04-05 13:44:43 UTC
I posted an initial set of patches:

https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html

Yaniv: is it possible to describe the virtio RNG device (or the
virtio memory balloon, or the pvpanic device) in oVirt's OVF XML?
I checked the code but couldn't see how to do that.  Maybe they
are added implicitly?

Comment 5 Yaniv Kaul 2017-04-05 13:52:00 UTC
(In reply to Richard W.M. Jones from comment #4)
> I posted an initial set of patches:
> 
> https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html
> 
> Yaniv: is it possible to describe the virtio RNG device (or the
> virtio memory balloon, or the pvpanic device) in oVirt's OVF XML?
> I checked the code but couldn't see how to do that.  Maybe they
> are added implicitly?

Michal?

Comment 6 Richard W.M. Jones 2017-04-05 14:41:11 UTC
Better patch series (but still not adding the devices to OVF output):

https://www.redhat.com/archives/libguestfs/2017-April/msg00040.html

Comment 7 Tomáš Golembiovský 2017-04-06 09:59:53 UTC
We are able to read the RNG and memballoon devices from OVF. We don't care about pvpanic device. I'll investigate the details and provide a patch.

Comment 8 Richard W.M. Jones 2017-04-06 10:05:50 UTC
Updated again:

https://www.redhat.com/archives/libguestfs/2017-April/msg00068.html

Comment 9 Richard W.M. Jones 2017-04-06 15:43:44 UTC
Apart from oVirt support, this is now upstream in libguestfs >= 1.37.9.
The commits are:

27a7214074be11b08c49700aa528bbc83c252650
95f1e83bafafba38c8c745630bce5da3367265b5
413ebec0392892ca36b86f416f650090ef8825d3
e6c9c4f69f10fecbf372253f44afe22389ebcb30
f5ce03c4dafe084111c832fa23353b66a9f8a553
3e0ff263a55e7508f23adb19e38c35065790b508
2db46a41142c77d34009a6b63992a7bd06961d74
0a0586936a13845a15f05236aa928d6b514fe171
d6e59ddfcd15d79d245ef96f63fc31df2a62243c
543b7433e29e18fd5b272d6ba927ff3ec27cbecb

I'm leaving this bug open since I think Tomáš is planning to
implement oVirt support.

Comment 10 Richard W.M. Jones 2017-04-11 20:55:19 UTC
Tomáš added support for oVirt.

The full list of commits is now:

27a7214074be11b08c49700aa528bbc83c252650
95f1e83bafafba38c8c745630bce5da3367265b5
413ebec0392892ca36b86f416f650090ef8825d3
e6c9c4f69f10fecbf372253f44afe22389ebcb30
f5ce03c4dafe084111c832fa23353b66a9f8a553
3e0ff263a55e7508f23adb19e38c35065790b508
2db46a41142c77d34009a6b63992a7bd06961d74
0a0586936a13845a15f05236aa928d6b514fe171
d6e59ddfcd15d79d245ef96f63fc31df2a62243c
543b7433e29e18fd5b272d6ba927ff3ec27cbecb
1a3fa37ae10f948cd97e8ddb10d0bd12fe534dc4
dac5fc53acdd1e51be2957c67e1e063e2132e680

As this bug is filed against upstream, I am closing this
issue because it is fixed.  If this fix was intended
for RHEL 7 then you will need to reopen or clone this
bug and set it against the correct product/component.


Note You need to log in before you can comment on or make changes to this bug.