Bug 1439733 - [RFE] Install Windows virtio-rng drivers on VMs imported
Summary: [RFE] Install Windows virtio-rng drivers on VMs imported
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.3.1
: ---
Assignee: Tomáš Golembiovský
QA Contact: Nisim Simsolo
URL:
Whiteboard:
Depends On: 1438794
Blocks: 1430760
TreeView+ depends on / blocked
 
Reported: 2017-04-06 12:39 UTC by Michal Skrivanek
Modified: 2019-04-16 14:04 UTC (History)
12 users (show)

Fixed In Version:
Clone Of: 1438794
Environment:
Last Closed: 2019-04-16 14:04:06 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.3+
mtessun: planning_ack+
aoconnor: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)

Description Michal Skrivanek 2017-04-06 12:39:58 UTC
we need to reflect the virtio-rng device generated in v2v's OVF when we create the oVirt VM entity.
Actually, this may not be needed if we make it enabled by default by adding to Blank template(this is currently unplanned)

+++ This bug was initially created as a clone of Bug #1438794 +++

Description of problem:
I don't think today we install the driver for virtio-rng on Windows VMs. We should install it on supported OSes automatically.

Comment 1 Richard W.M. Jones 2017-04-06 13:03:48 UTC
Also be helpful to get a definition of exactly what XML fragment
we should add to the OVF output.

Comment 2 Tomáš Golembiovský 2017-04-07 09:56:17 UTC
We need this for memory balloon device:

      <Item>
        <rasd:ResourceType>0</rasd:ResourceType>
        <Type>balloon</Type>
        <Device>memballoon</Device>
      </Item>

And this for RNG device

      <Item>
        <rasd:ResourceType>0</rasd:ResourceType>
        <Type>rng</Type>
        <Device>virtio</Device>
      </Item>

I've already sent a patch for virt-v2v
https://www.redhat.com/archives/libguestfs/2017-April/msg00092.html

Comment 3 Tomáš Golembiovský 2017-04-12 11:15:13 UTC
A patch was merged in virt-v2v, the commit is:

    dac5fc53acdd1e51be2957c67e1e063e2132e680

The final version of the patch is:

    https://www.redhat.com/archives/libguestfs/2017-April/msg00103.html

Comment 4 Tomáš Golembiovský 2018-01-07 16:09:52 UTC
Update: there still isn't any stable release of libguestfs with this patch

Comment 5 Richard W.M. Jones 2018-01-08 07:24:52 UTC
We missed this patch for RHEL 7.5 because there isn't any RHEL/libguestfs
bug for it.  Do we need this in RHEL 7.5?  It's probably too late
unfortunately.

Comment 6 Martin Tessun 2018-07-06 16:37:37 UTC
Michal,

could you take care of a downstream bug for v2v for RHEL 7.7 if this is still needed?

Thanks!
Martin

Comment 7 Richard W.M. Jones 2018-07-09 07:43:40 UTC
Still(!) no bug for libguestfs.  However this patch was included
anyway in virt-v2v 1.38 which is what we rebased to, so we're good
for RHEL *7.6*.

Comment 8 Ryan Barry 2019-01-21 14:54:17 UTC
Re-targeting to 4.3.1 since it is missing a patch, an acked blocker flag, or both

Comment 9 Tomáš Golembiovský 2019-02-13 09:54:14 UTC
this seems to be already in libguestfs, should be only tested

Comment 11 Tomáš Golembiovský 2019-03-13 12:14:18 UTC
looks good to me

Comment 12 Nisim Simsolo 2019-04-16 08:15:19 UTC
Verification version:
rhvm-4.3.3.3-0.1.el7
libvirt-4.5.0-10.el7_6.7.x86_64
vdsm-4.30.13-1.el7ev.x86_64
sanlock-3.6.0-1.el7.x86_64
qemu-kvm-rhev-2.12.0-21.el7.x86_64
virt-v2v-1.38.2-12.29.lp.el7ev.x86_64

Verification scenario:
Polarion test case added to external trackers.

Comment 13 Sandro Bonazzola 2019-04-16 14:04:06 UTC
This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.