Description of problem:
Firefox 53 fails to build on second arches (ppc/arm).
* extract of build log is reporting a missing def of RegTypeName
* as per upstream query this is defined in Architecture-shared.h
that should be included via Architecture-none.h
assuming JS_CODEGEN_NONE is defined.
* BUT in unpacked source on fedora this include is not present.
* Suggestion is to add the two patches identified below from upstream.
=== build.log extract:
/builddir/build/BUILD/firefox-53.0/firefox-53.0/js/src/jit/Registers.h:91:22: error: 'RegTypeName' does not name a type; did you mean 'typename'?
static constexpr RegTypeName DefaultType = RegTypeName::GPR;
Note that even if correction of this include, then next failure
is a rust related error as per scratchbuild (also for x86_64)
Running `/usr/bin/rustc --crate-name mp4parse_gtest /builddir/build/BUILD/firefox-53.0/firefox-53.0/dom/media/gtest/hello.rs --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C debuginfo=2 -C metadata=29cb3f043171d892 -C extra-filename=-29cb3f043171d892 --out-dir /builddir/build/BUILD/firefox-53.0/firefox-53.0/objdir/toolkit/library/gtest/rust/./x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/builddir/build/BUILD/firefox-53.0/firefox-53.0/objdir/toolkit/library/gtest/rust/./x86_64-unknown-linux-gnu/release/deps -L dependency=/builddir/build/BUILD/firefox-53.0/firefox-53.0/objdir/toolkit/library/gtest/rust/./release/deps`
error[E0463]: can't find crate for `cheddar`
1 | extern crate cheddar;
| ^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
error: Could not compile `mp4parse_capi`.
the changelog contains
* Tue Apr 18 2017 Martin Stransky <email@example.com> - 53.0-1
- Updated to 53.0 (B6)
so probably it's not the GA tarball (if B6 means Beta6), where these fixes would be included. If I see correctly in upstream mercurial repo, then these fixes landed 5 days after creating the FIREFOX_AURORA_53_BASE tag.
is it feasible to keep firefox 52 in f26, as long as 53 do not build ? this would avoid some openQA tests to fail because of missing firefox at install time.
(In reply to Michel Normand from comment #4)
> Hello Martin
> is it feasible to keep firefox 52 in f26, as long as 53 do not build ? this
> would avoid some openQA tests to fail because of missing firefox at install
I don't know how to do that - the builds are already in koji and updates I expect. Can rel-eng do it?
(In reply to Dan Horák from comment #3)
> the changelog contains
> * Tue Apr 18 2017 Martin Stransky <firstname.lastname@example.org> - 53.0-1
> - Updated to 53.0 (B6)
> so probably it's not the GA tarball (if B6 means Beta6), where these fixes
> would be included. If I see correctly in upstream mercurial repo, then these
> fixes landed 5 days after creating the FIREFOX_AURORA_53_BASE tag.
B6 means Build6 as you see them on http://archive.mozilla.org/pub/firefox/candidates/53.0-candidates/
Proposing as a blocker for F26 Beta, firefox is the default browser on XFCE which is the release blocking desktop image on arm.
(In reply to Michel Normand from comment #2)
> Note that even if correction of this include, then next failure
> is a rust related error as per scratchbuild (also for x86_64)
> Running `/usr/bin/rustc --crate-name mp4parse_gtest
> --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C
> codegen-units=1 -C debuginfo=2 -C metadata=29cb3f043171d892 -C
> extra-filename=-29cb3f043171d892 --out-dir
> rust/./x86_64-unknown-linux-gnu/release/deps --target
> x86_64-unknown-linux-gnu -L
> library/gtest/rust/./x86_64-unknown-linux-gnu/release/deps -L
> error[E0463]: can't find crate for `cheddar`
> 1 | extern crate cheddar;
> | ^^^^^^^^^^^^^^^^^^^^^ can't find crate
> error: aborting due to previous error
> Build failed, waiting for other jobs to finish...
> error: Could not compile `mp4parse_capi`.
AFAIK we don't support Rust on arm now. Should work with disabled Rust, which I'm building now.
Arm builds are fixed now.
firefox-53.0.2-3.fc26 is built for ARM. Looks like we still have problems with F24/25 which will be fixed later.
Discussed in the 2017-05-02 Blocker Review meeting . This is rejected in favour of the alternative proposal #1448923 , which more precisely reflects the actual criteria violation. There was a long discussion on it during the meeting  as well as a mailing list discussion  to explain the rationale.
 Sorry for the late update on this.
Let's mark this as Arm build failures and target ppc/s390/aarch64 in different bugs.
Michael, thanks for the patches in comment 1 - that really helped. Right now I work on F25/24 build failures, F26/rawhide seems to be fine.
firefox-53.0.2-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b8b0cc0a2
firefox-53.0.2-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b8b0cc0a2
Can someone test with ARM that the new build works? Thanks!
firefox-53.0.2-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.