Bug 1443977
| Summary: | Unable to take snapshot on a geo-replicated volume, even after stopping the session | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Kotresh HR <khiremat> | |
| Component: | geo-replication | Assignee: | Kotresh HR <khiremat> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, avishwan, bugs, csaba, jgalvez, rcyriac, rhinduja, rhs-bugs, sanandpa, storage-qa-internal | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.11.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1416024 | |||
| : | 1445209 1445213 (view as bug list) | Environment: | ||
| Last Closed: | 2017-05-30 18:50:19 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1416024 | |||
| Bug Blocks: | 1445209, 1445213, 1445591 | |||
|
Comment 1
Kotresh HR
2017-04-20 11:21:21 UTC
REVIEW: https://review.gluster.org/17093 (glusterd/geo-rep: Fix snapshot create in geo-rep setup) posted (#1) for review on master by Kotresh HR (khiremat) REVIEW: https://review.gluster.org/17093 (glusterd/geo-rep: Fix snapshot create in geo-rep setup) posted (#2) for review on master by Kotresh HR (khiremat) REVIEW: https://review.gluster.org/17093 (glusterd/geo-rep: Fix snapshot create in geo-rep setup) posted (#3) for review on master by Kotresh HR (khiremat) REVIEW: https://review.gluster.org/17093 (glusterd/geo-rep: Fix snapshot create in geo-rep setup) posted (#4) for review on master by Kotresh HR (khiremat) COMMIT: https://review.gluster.org/17093 committed in master by Atin Mukherjee (amukherj) ------ commit f071d2a285ea4802fe8f328f9f275180983fbbba Author: Kotresh HR <khiremat> Date: Thu Apr 20 07:18:52 2017 -0400 glusterd/geo-rep: Fix snapshot create in geo-rep setup glusterd persists geo-rep sessions in glusterd info file which is represented by dictionary 'volinfo->gsync_slaves' in memory. Glusterd also maintains in memory active geo-rep sessions in dictionary 'volinfo->gsync_active_slaves' whose key is "<slave_url>::<slavhost>". When glusterd is restarted while the geo-rep sessions are active, it builds the 'volinfo->gsync_active_slaves' from persisted glusterd info file. Since slave volume uuid is added to "voinfo->gsync_slaves" with the commit "http://review.gluster.org/13111", it builds it with key "<slave_url>::<slavehost>:<slavevol_uuid>" which is wrong. So during snapshot pre-validation which checks whether geo-rep is active or not, it always says it is ACTIVE, as geo-rep stop would not deleted this key. Fixed the same in this patch. Change-Id: I185178910b4b8a62e66aba406d88d12fabc5c122 BUG: 1443977 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: https://review.gluster.org/17093 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/ |