Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-1.fc27.src.rpm Description: When writing Cython code, special care must be taken to ensure that the code can be interrupted with CTRL-C. Since Cython optimizes for speed, Cython normally does not check for interrupts. For example, code like the following cannot be interrupted in Cython: while True: pass The cysignals package provides mechanisms to handle interrupts (and other signals and errors) in Cython code. See http://cysignals.readthedocs.org/ for the full documentation. Fedora Account System Username: pcpa
I will take this review.
Created attachment 1274064 [details] Patch to remove python preloading Two quick notes: fedora-review says the spec file at the URL given above does not match the spec file inside the SRPM. Also, the cysignals-CSI script attempts to "preload the right Python library." However, Fedora's gdb is already linked with the python 3 library. The preload attempt is both unnecessary and wrong, as it causes gdb to crash on startup. I think that the rest of %prep after %setup should be removed, and the attached patch applied instead. I haven't tried yet, but I expect that will fix the problem with %check as well. The first hunk of the patch tells gdb that it can load an init file from anywhere. I'm not sure that is necessary. You might want to remove that part.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Header files in -devel subpackage, if present. Note: python2-cysignals : /usr/lib64/python2.7/site- packages/cysignals/debug.h python2-cysignals : /usr/lib64/python2.7/site- packages/cysignals/macros.h python2-cysignals : /usr/lib64/python2.7 /site-packages/cysignals/pxi.h python2-cysignals : /usr/lib64/python2.7 /site-packages/cysignals/signals.h python2-cysignals : /usr/lib64/python2.7/site-packages/cysignals/signals_api.h python2-cysignals : /usr/lib64/python2.7/site- packages/cysignals/struct_signals.h python3-cysignals : /usr/lib64/python3.6/site-packages/cysignals/debug.h python3-cysignals : /usr/lib64/python3.6/site-packages/cysignals/macros.h python3-cysignals : /usr/lib64/python3.6/site-packages/cysignals/pxi.h python3-cysignals : /usr/lib64/python3.6/site-packages/cysignals/signals.h python3-cysignals : /usr/lib64/python3.6/site-packages/cysignals/signals_api.h python3-cysignals : /usr/lib64/python3.6/site- packages/cysignals/struct_signals.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages. Also, is it really necessary to install the .pxd and .pxi files? - %{?python_provide:%python_provide python3-%{modname}} is missing from the python3 package - The cysignals-CSI script has a shebang that invokes /usr/bin/env. It should invoke the correct python interpreter directly instead. - Shouldn't the license be LGPLv3+? - The license file is not installed if only the -doc subpackage is installed. - The -doc subpackage doesn't own /usr/share/doc/python-cysignals, and neither does any other subpackage. - I assume the intent is to unbundle this package from sagemath. Is that right? If so, the fact that sagemath also owns /usr/lib64/python2.7/site-packages/cysignals can be ignored. - The changelog is missing. - The URL field is missing. It should probably point to either http://cysignals.readthedocs.io/en/latest/ or https://github.com/sagemath/cysignals. - The latest version is 1.6.4. - The package checks for the emms assembly instruction. That's okay on x86_64, where it is universally available, and also okay on non-x86 architectures, where it is universally unavailable. However, on i386, that instruction may be detected on the builders and compiled in, but we can't guarantee that all i386 users have that instruction available. Somehow, use of that instruction has to be disabled for i386 builds. - The spec file uses both tabs and spaces. - /usr/share/doc/python-cysignals/html/.buildinfo can be excluded from the -doc subpackage. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* LGPL (v3 or later)", "LGPL (v3 or later)", "GPL (v3)", "Unknown or generated". 20 files have unknown license. [!]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/python-cysignals [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/python- cysignals [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python2.7/site- packages/cysignals(sagemath-core) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python2-cysignals-1.3.2-1.fc27.x86_64.rpm python3-cysignals-1.3.2-1.fc27.x86_64.rpm python-cysignals-doc-1.3.2-1.fc27.x86_64.rpm python-cysignals-debuginfo-1.3.2-1.fc27.x86_64.rpm python-cysignals-1.3.2-1.fc27.src.rpm python2-cysignals.x86_64: E: no-changelogname-tag python2-cysignals.x86_64: W: no-url-tag python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/signals.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/debug.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/pxi.h python2-cysignals.x86_64: E: script-without-shebang /usr/bin/cysignals-CSI-helper.py python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/struct_signals.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/macros.h python2-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/signals_api.h python2-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI-helper.py python2-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI python3-cysignals.x86_64: E: no-changelogname-tag python3-cysignals.x86_64: W: no-url-tag python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/signals_api.h python3-cysignals.x86_64: E: script-without-shebang /usr/bin/cysignals-CSI-helper.py python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/macros.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/struct_signals.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/signals.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/debug.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/pxi.h python3-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python3-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python3-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI-helper.py python3-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI python-cysignals-doc.x86_64: E: no-changelogname-tag python-cysignals-doc.x86_64: W: no-url-tag python-cysignals-doc.x86_64: W: hidden-file-or-dir /usr/share/doc/python-cysignals/html/.buildinfo python-cysignals-debuginfo.x86_64: E: no-changelogname-tag python-cysignals-debuginfo.x86_64: W: no-url-tag python-cysignals.src: E: no-changelogname-tag python-cysignals.src: W: no-url-tag python-cysignals.src:30: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 1) 5 packages and 0 specfiles checked; 7 errors, 27 warnings. Rpmlint (debuginfo) ------------------- Checking: python-cysignals-debuginfo-1.3.2-1.fc27.x86_64.rpm python-cysignals-debuginfo.x86_64: E: no-changelogname-tag python-cysignals-debuginfo.x86_64: W: no-url-tag 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- python-cysignals-doc.x86_64: E: no-changelogname-tag python-cysignals-doc.x86_64: W: no-url-tag python-cysignals-doc.x86_64: W: hidden-file-or-dir /usr/share/doc/python-cysignals/html/.buildinfo python3-cysignals.x86_64: E: no-changelogname-tag python3-cysignals.x86_64: W: no-url-tag python3-cysignals.x86_64: E: script-without-shebang /usr/bin/cysignals-CSI-helper.py python3-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python3-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/debug.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/macros.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/pxi.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/signals.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/signals_api.h python3-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/cysignals/struct_signals.h python3-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI python3-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI-helper.py python2-cysignals.x86_64: E: no-changelogname-tag python2-cysignals.x86_64: W: no-url-tag python2-cysignals.x86_64: E: script-without-shebang /usr/bin/cysignals-CSI-helper.py python2-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-cysignals.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/debug.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/macros.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/pxi.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/signals.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/signals_api.h python2-cysignals.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/cysignals/struct_signals.h python2-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI python2-cysignals.x86_64: W: no-manual-page-for-binary cysignals-CSI-helper.py python-cysignals-debuginfo.x86_64: E: no-changelogname-tag python-cysignals-debuginfo.x86_64: W: no-url-tag 4 packages and 0 specfiles checked; 6 errors, 25 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/1445411-python-cysignals/srpm/python-cysignals.spec 2017-04-25 17:36:46.029203940 -0600 +++ /home/jamesjer/1445411-python-cysignals/srpm-unpacked/python-cysignals.spec 2017-04-24 08:31:19.000000000 -0600 @@ -79,16 +79,16 @@ %license LICENSE %doc PKG-INFO README.rst -%{_bindir}/%{modname}-CSI -%{_bindir}/%{modname}-CSI-helper.py -%{python2_sitearch}/%{modname} -%{python2_sitearch}/%{modname}-*.egg-info +%{_bindir}/cysignals-CSI +%{_bindir}/cysignals-CSI-helper.py +%{python2_sitearch}/cysignals +%{python2_sitearch}/cysignals-*.egg-info %files -n python3-%{modname} %license LICENSE %doc PKG-INFO README.rst -%{_bindir}/%{modname}-CSI -%{_bindir}/%{modname}-CSI-helper.py -%{python3_sitearch}/%{modname} -%{python3_sitearch}/%{modname}-*.egg-info +%{_bindir}/cysignals-CSI +%{_bindir}/cysignals-CSI-helper.py +%{python3_sitearch}/cysignals +%{python3_sitearch}/cysignals-*.egg-info %files doc Requires -------- python-cysignals-doc (rpmlib, GLIBC filtered): python3-cysignals (rpmlib, GLIBC filtered): /usr/bin/python libc.so.6()(64bit) libpari-gmp.so.5()(64bit) libpthread.so.0()(64bit) libpython3.6m.so.1.0()(64bit) python(abi) rtld(GNU_HASH) python2-cysignals (rpmlib, GLIBC filtered): /usr/bin/python libc.so.6()(64bit) libpari-gmp.so.5()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) rtld(GNU_HASH) python-cysignals-debuginfo (rpmlib, GLIBC filtered): Provides -------- python-cysignals-doc: python-cysignals-doc python-cysignals-doc(x86-64) python3-cysignals: python3-cysignals python3-cysignals(x86-64) python3.6dist(cysignals) python3dist(cysignals) python2-cysignals: python-cysignals python-cysignals(x86-64) python2-cysignals python2-cysignals(x86-64) python2.7dist(cysignals) python2dist(cysignals) python-cysignals-debuginfo: python-cysignals-debuginfo python-cysignals-debuginfo(x86-64) Unversioned so-files -------------------- python2-cysignals: /usr/lib64/python2.7/site-packages/cysignals/alarm.so python2-cysignals: /usr/lib64/python2.7/site-packages/cysignals/pselect.so python2-cysignals: /usr/lib64/python2.7/site-packages/cysignals/signals.so python2-cysignals: /usr/lib64/python2.7/site-packages/cysignals/tests.so python3-cysignals: /usr/lib64/python3.6/site-packages/cysignals/alarm.cpython-36m-x86_64-linux-gnu.so python3-cysignals: /usr/lib64/python3.6/site-packages/cysignals/pselect.cpython-36m-x86_64-linux-gnu.so python3-cysignals: /usr/lib64/python3.6/site-packages/cysignals/signals.cpython-36m-x86_64-linux-gnu.so python3-cysignals: /usr/lib64/python3.6/site-packages/cysignals/tests.cpython-36m-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/sagemath/cysignals/releases/download/1.3.2/cysignals-1.3.2.tar.bz2 : CHECKSUM(SHA256) this package : 82418186d6cd1ca6ec16f6d5dab5487fc57ddea1356cd7d0228e8862635ca0d1 CHECKSUM(SHA256) upstream package : 82418186d6cd1ca6ec16f6d5dab5487fc57ddea1356cd7d0228e8862635ca0d1 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1445411 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-2.fc27.src.rpm I might have made some change to the spec, but now I am sure it matches the one in the srpm. Your suggested patch was added verbatim, and also a few extra changes to make it "almost" pass all %check tests with python3; apparently is is not yet fully functional with python3, or this version has issues. Major issue was a Popen('python') that would invoke python2. > - Header files in -devel subpackage, if present. > Note: python2-cysignals : /usr/lib64/python2.7/site- > packages/cysignals/debug.h python2-cysignals : /usr/lib64/python2.7/site- [...] > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages. > Also, is it really necessary to install the .pxd and .pxi files? I did not create a -devel at first subpackage because it is not the only python package installing private headers: $ rpm -qf $(find /usr/lib64/python2.7/site-packages/ | grep '\.h$') | grep -v cysignals | grep -v sagemath | uniq python2-zmq-16.0.2-3.fc26.x86_64 python2-astropy-1.3.2-1.fc27.x86_64 python2-scipy-0.18.0-3.fc26.x86_64 python2-cffi-1.10.0-1.fc27.x86_64 python2-lxml-3.7.2-2.fc26.x86_64 python2-numpy-1.12.1-1.fc27.x86_64 python2-numpy-f2py-1.12.1-1.fc27.x86_64 python2-Cython-0.25.2-4.fc26.x86_64 The .pxi and .pxd are used during sagemath build. > - %{?python_provide:%python_provide python3-%{modname}} is missing from the > python3 package Fixed. > - The cysignals-CSI script has a shebang that invokes /usr/bin/env. It should > invoke the correct python interpreter directly instead. Now it installs cysignals-CSI-2 and cysignals-CSI-3 files, and the C source was patched to invoke the correct one. > - Shouldn't the license be LGPLv3+? Corrected. > - The license file is not installed if only the -doc subpackage is installed. Added a requires to python-cysignals > - The -doc subpackage doesn't own /usr/share/doc/python-cysignals, and neither > does any other subpackage. Corrected. > - I assume the intent is to unbundle this package from sagemath. Is that > right? If so, the fact that sagemath also owns > /usr/lib64/python2.7/site-packages/cysignals can be ignored. Yes. Only sagemath uses it, thus also not the latest version. > - The changelog is missing. Fixed. > - The URL field is missing. It should probably point to either > http://cysignals.readthedocs.io/en/latest/ or > https://github.com/sagemath/cysignals. Corrected. > - The latest version is 1.6.4. At first, and because only sagemath uses it, I would prefer to avoid conflicts using a version not matching the one required by the sagemath package. > - The package checks for the emms assembly instruction. That's okay on > x86_64, where it is universally available, and also okay on non-x86 > architectures, where it is universally unavailable. However, on i386, that > instruction may be detected on the builders and compiled in, but we can't > guarantee that all i386 users have that instruction available. Somehow, use > of that instruction has to be disabled for i386 builds. I just #if 0'ed the C source. It apparently is only required for solaris. > - The spec file uses both tabs and spaces. I did not find any match for ' \t' or '\t '. But there are lines starting with less than 8 spaces. That may depend on having tabs set to 4 or 8 spaces... > - /usr/share/doc/python-cysignals/html/.buildinfo can be excluded from the > -doc subpackage. Fixed.
(In reply to Paulo Andrade from comment #4) > I did not create a -devel at first subpackage because it is not the > only python package installing private headers: That makes sense for packages like python2-cffi and python2-Cython, which use those header files for normal functioning. Some of those seem like bugs to me, though. For this package, in particular, the header files won't be needed at runtime, just the shared object, so I believe a -devel subpackage is needed. We can ask about this on -devel-list if you want. > At first, and because only sagemath uses it, I would prefer to avoid > conflicts using a version not matching the one required by the sagemath > package. Sure, that's fine. > I did not find any match for ' \t' or '\t '. But there are lines starting > with less than 8 spaces. That may depend on having tabs set to 4 or 8 > spaces... I'm looking at the spec file in Emacs. Typing 'C-s C-q TAB' shows that there are tabs on almost all of the header lines, but "BuildRequires: python2-devel", "BuildRequires: python3-devel", and "BuildRequires: python-sphinx" all have spaces instead, as well as the "Summary" line for the -doc subpackage. One other question: do the Popen() invocation changes made in the %check script need to be made in the actual installed files, too?
Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-2.fc27.src.rpm Changed to install .h, .pxi and .pxd files in a -devel package. This should require changes to the spec of python-fpylll review request, I will confirm. Sorry for the cut&paste and not properly noticing the spaces only in some BuildRequires. Fixed now. The Popen calls are on doctests of .pyx files. For safety I changed the files before every build; no changes in %install because it pass --skip-build in eval of %py{2,3}_install.
Okay, that looks good. This package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-cysignals
f25 and f26 branches were asked. For the moment the package is rawhide only, for sagemath update.
python-cysignals-1.3.2-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-da8a082a94
python-cysignals-1.3.2-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-da8a082a94
python-cysignals-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.