Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1450773

Summary:	Quota: After upgrade from 3.7 to higher version , gluster quota list command shows "No quota configured on volume repvol"
Product:	[Community] GlusterFS	Reporter:	Sanoj Unnikrishnan <sunnikri>
Component:	quota	Assignee:	Sanoj Unnikrishnan <sunnikri>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	amukherj, ashah, bugs, rcyriac, rhs-bugs, rtalur, storage-qa-internal
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.10.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1414346	Environment:
Last Closed:	2017-06-06 06:08:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1457513

Description Sanoj Unnikrishnan 2017-05-15 07:40:41 UTC

+++ This bug was initially created as a clone of Bug #1414346 +++

Description of problem:

Quota is enabled,and limit-usage is set on certain directories. After upgrade from 3.7.9 to latest quota list command shows "No quota configured on volume repvol "

Steps to Reproduce:
1. Create 2*2 dist-repvol vol on 3.7.9
2. Enable quota and set limit-usage and limit-object
3. Do fuse mount and create some date on mount point
4. Now do in-server upgrade of system .
5. after upgrade run quota vol list command

Actual results:

gluster v info shows quota is on 
however quota list command shows "quota: No quota configured on volume "

Expected results:

quota list command should work 

It was noticed that with op version bump up the quota conf file is updated and the limits stored in this file get lost. 

This issue is hit in 2 scenarios:
1) when we upgrade from 3.6 to 3.7 (where the quota.conf needs an upgrade)
2) When the upgrade happens from 3.7 or more to higher version (where no quota.conf upgrade is needed)

--- Additional comment from Worker Ant on 2017-01-18 05:34:36 EST ---

REVIEW: http://review.gluster.org/16425 (Fixes upgrade issue in quota.conf) posted (#1) for review on master by sanoj-unnikrishnan (sunnikri)

--- Additional comment from Worker Ant on 2017-01-19 02:19:09 EST ---

REVIEW: http://review.gluster.org/16425 (Fixes upgrade issue in quota.conf) posted (#2) for review on master by sanoj-unnikrishnan (sunnikri)

--- Additional comment from Worker Ant on 2017-01-19 08:29:29 EST ---

COMMIT: http://review.gluster.org/16425 committed in master by Atin Mukherjee (amukherj) 
------
commit 89cf743118ab6554c7f210754e51c4921cbb60c7
Author: Sanoj Unnikrishnan <sunnikri>
Date:   Wed Jan 18 15:56:00 2017 +0530

    Fixes upgrade issue in quota.conf
    
    When an op-version bump up is done the glusterd_store_quota_config
    upgrades the quota conf file, although overwriting the same later
    which leaves out all gfid entries. While this is warranted for
    enable opcode, for upgrade we need to retain gfids. So for upgrade
    opcode, we return once the upgrade is done.
    
    Change-Id: I2b38c6022d74b4a14dc07432651a51cc39ad5120
    BUG: 1414346
    Signed-off-by: Sanoj Unnikrishnan <sunnikri>
    Reviewed-on: http://review.gluster.org/16425
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

--- Additional comment from Worker Ant on 2017-05-15 03:29:07 EDT ---

REVIEW: https://review.gluster.org/17291 (Fixes upgrade issue in quota.conf) posted (#1) for review on release-3.8 by sanoj-unnikrishnan (sunnikri)

Comment 1 Worker Ant 2017-05-15 07:44:02 UTC

REVIEW: https://review.gluster.org/17292 (Fixes upgrade issue in quota.conf) posted (#1) for review on release-3.10 by sanoj-unnikrishnan (sunnikri)

Comment 2 Worker Ant 2017-05-31 05:58:28 UTC

COMMIT: https://review.gluster.org/17292 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit 37bec170521e6bfa994648fad5ba2e3769a87628
Author: Sanoj Unnikrishnan <sunnikri>
Date:   Wed Jan 18 15:56:00 2017 +0530

    Fixes upgrade issue in quota.conf
    
    When an op-version bump up is done the glusterd_store_quota_config
    upgrades the quota conf file, although overwriting the same later
    which leaves out all gfid entries. While this is warranted for
    enable opcode, for upgrade we need to retain gfids. So for upgrade
    opcode, we return once the upgrade is done.
    
    > Reviewed-on: http://review.gluster.org/16425
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > (cherry picked from commit 89cf743118ab6554c7f210754e51c4921cbb60c7)
    
    Change-Id: I2b38c6022d74b4a14dc07432651a51cc39ad5120
    BUG: 1450773
    Signed-off-by: Sanoj Unnikrishnan <sunnikri>
    Reviewed-on: https://review.gluster.org/17292
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 3 Raghavendra Talur 2017-06-06 06:08:20 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.3, please open a new bug report.

glusterfs-3.10.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-June/031399.html
[2] https://www.gluster.org/pipermail/gluster-users/