Bug 1452335 - [PATCH] Remove recommends on dnf debuginfo-install
Summary: [PATCH] Remove recommends on dnf debuginfo-install
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gdb
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Kratochvil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-18 17:47 UTC by Colin Walters
Modified: 2017-05-20 19:06 UTC (History)
6 users (show)

Fixed In Version: gdb-7.99.90.20170420-12.fc27
Clone Of:
Environment:
Last Closed: 2017-05-20 19:06:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Colin Walters 2017-05-18 17:47:01 UTC
From d57002cff7dd8ab3eaf2be5bff08baa377f381c4 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters>
Date: Thu, 18 May 2017 13:44:05 -0400
Subject: [PATCH] Remove recommends on dnf debuginfo-install

In practice in Fedora, there are `dnf` and `rpm-ostree` for system
management.  For systems which use `dnf`, they'll generally have `plugins-core`
too.  If they don't, it's easy to add.

For `rpm-ostree` based systems, having `gdb` pull in parts of `dnf` is
problematic (since `dnf` doesnt' work there).  Yes, it's just a recommends...
but in practice our tools install them by default.

So while the `Recommends` is theoretically right, the value it brings isn't
worth the pain for people building systems not using `dnf`.
---
 gdb.spec | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb.spec b/gdb.spec
index ded4b0c..c1d4214 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -98,7 +98,6 @@ Provides: bundled(md5-gcc) = %{snapsrc}
 %endif
 
 %if 0%{!?rhel:1} || 0%{?rhel} > 7
-Recommends: dnf-command(debuginfo-install)
 # https://bugzilla.redhat.com/show_bug.cgi?id=1209492
 Recommends: default-yama-scope
 %endif
-- 
2.9.4

Comment 1 Colin Walters 2017-05-18 17:48:10 UTC
And gdb itself is pulled in by abrt: https://bugzilla.redhat.com/show_bug.cgi?id=1452336

Comment 2 Jan Kratochvil 2017-05-20 18:15:59 UTC
(In reply to Colin Walters from comment #0)
> For `rpm-ostree` based systems, having `gdb` pull in parts of `dnf` is
> problematic (since `dnf` doesnt' work there).  Yes, it's just a recommends...
> but in practice our tools install them by default.

In such case there should be /usr/lib/rpm/macros.d/macros.rpm-ostree setting some rpm variable which gdb.spec could use to disable the debuginfo-install Recommends.

Currently I have just moved the Recommends from gdb-headless to gdb which should be right to do anyway.  Together with ABRT's Bug 1452336 it should be IMO enough to fix this Bug.


> So while the `Recommends` is theoretically right, the value it brings isn't
> worth the pain for people building systems not using `dnf`.

That is not an unbiased view.

Comment 3 Jan Kratochvil 2017-05-20 19:06:15 UTC
It is only in Rawhide as requested, reopen it for other releases.


Note You need to log in before you can comment on or make changes to this bug.