Bug 1455552 - Display a warning for large number of objects in the Topology pages
Summary: Display a warning for large number of objects in the Topology pages
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Nimrod Shneor
QA Contact: Gilad Shefer
URL:
Whiteboard: container:ui:topology
Depends On:
Blocks: 1468296
TreeView+ depends on / blocked
 
Reported: 2017-05-25 12:41 UTC by Peter McGowan
Modified: 2018-04-09 12:28 UTC (History)
11 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1468296 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:13:31 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Peter McGowan 2017-05-25 12:41:14 UTC
Description of problem:
The 'Topology Default Items in View' filter in 'My Settings' is not working for an OpenShift provider containing many hundreds of objects (tested with 1300 pods and 1300 containers).

Version-Release number of selected component (if applicable):
5.8.0.16.20170522163900_28fa952

How reproducible:
every time

Steps to Reproduce:
1. Attach an OpenShift provider containing many hundreds of pods and/or containers
2. As Admin go to My Settings, and set the 'Topology Default Items in View' for containers to a low value such as 20.
3. Go to the Containers -> Toplogy view
4. Enable the display of pods or containers

Actual results:
Many more objects are displayed than defined by the limit

Expected results:
Only the number of objects defined by the limit should be displayed.

Additional info:
This problem is made much worse if the default settings are set to display all objects in the Containers -> Toplogy view (i.e. none of the 'click here to show/hide entities are greyed out). In this case the initial display of the topology view will lock up the browser for several minutes, presumably while the full object list is being rendered. Chrome (on a Mac) just times out.

Comment 4 Federico Simoncelli 2017-05-26 11:50:08 UTC
(In reply to Peter McGowan from comment #0)
> Steps to Reproduce:
> 1. Attach an OpenShift provider containing many hundreds of pods and/or
> containers
> 2. As Admin go to My Settings, and set the 'Topology Default Items in View'
> for containers to a low value such as 20.
> 3. Go to the Containers -> Toplogy view
> 4. Enable the display of pods or containers
> 
> Actual results:
> Many more objects are displayed than defined by the limit

Peter 'Topology Default Items in View' allows you to set the default total number of items that the topology will show (typically 100-200 is a good number).
That is achieved by automatically disabling types of entities (e.g. Pods/Containers/etc.) if the number of items exceed the setting.
Of course we won't display just a subset of the items (e.g. only up to 20 Pods out of say... 21 or 1300) because that would be confusing.

Anyway as you noticed we won't prevent you from overriding manually what entities to display.


> Expected results:
> Only the number of objects defined by the limit should be displayed.

The expected result is currently satisfied (unless of course you manually re-enable the entities).


Peter let me know if there is a bug in the expected behavior above: entities are automatically disabled in Topology to respect the limit of items specified in the settings.

Thanks.

Comment 5 Peter McGowan 2017-05-26 15:11:13 UTC
Hi Federico

Thanks for the explanation, it seems that my understanding of how it works was at fault here, rather than the limit setting.

I do however get a browser lock-up and timeout problem if I set 'Topology Default Items in View' to 'Unlimited' with this many objects. The problem happens with both Chrome and Firefox on a Mac, and seems to be a browser rendering issue (the browser process consumes 100% CPU utilization for several minutes and needs to be killed).

Not sure if this is worthy of a separate BZ?

Thanks,
Peter

Comment 6 Federico Simoncelli 2017-05-30 14:55:50 UTC
(In reply to Peter McGowan from comment #5)
> Hi Federico
> 
> Thanks for the explanation, it seems that my understanding of how it works
> was at fault here, rather than the limit setting.
> 
> I do however get a browser lock-up and timeout problem if I set 'Topology
> Default Items in View' to 'Unlimited' with this many objects. The problem
> happens with both Chrome and Firefox on a Mac, and seems to be a browser
> rendering issue (the browser process consumes 100% CPU utilization for
> several minutes and needs to be killed).
> 
> Not sure if this is worthy of a separate BZ?

We can use this BZ, but I don't know what should be the expected behavior.

Considered that:

- By default the limit should be set to 100 items (see bug 1455892)
- We would like to allow to manually enable more items if it makes sense

I don't know what we should do.

I am not in favor of adding another threshold (we already have one and it should suffice).

Should we prevent the manual override of re-enabling the entities that are automatically hidden?

Should we put a counter of entities next to each one so that you know in advance how many new items will appear on the screen?

Any other proposal?

Comment 7 Peter McGowan 2017-05-30 16:01:57 UTC
I think that setting the default to 100 items would be a great improvement, I only saw this problem when the value was set to 'Unlimited'.

The only other thing that springs to mind would be to display a warning, perhaps appended to the default text: "Click on the legend to show/hide entities, and double click/right click the entities in the graph to navigate to their summary pages."

Maybe add something like: "Note: displaying a very large number of objects in the topology display can adversely affect the performance of some web browsers"

Comment 8 Federico Simoncelli 2017-05-30 22:27:42 UTC
(In reply to Peter McGowan from comment #7)
> Maybe add something like: "Note: displaying a very large number of objects
> in the topology display can adversely affect the performance of some web
> browsers"

OK
Assigning to Nimrod.

Comment 10 Nimrod Shneor 2017-06-29 04:35:07 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/1605
Merged.

Comment 11 Mooli Tayer 2017-06-29 10:35:40 UTC
Move back to 5.8.1?


Note You need to log in before you can comment on or make changes to this bug.