Bug 1456414 – New domain should default to true on Discard After Delete

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1456414 - New domain should default to true on Discard After Delete

Summary:	New domain should default to true on Discard After Delete

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	ovirt-engine
Classification:	oVirt
Component:	BLL.Storage (Show other bugs)
Sub Component:
Version:	4.2.0
Hardware:	Unspecified Unspecified

Priority	high Severity low (vote)
Target Milestone:	ovirt-4.2.0
Target Release:	---
Assigned To:	Idan Shaby
QA Contact:	Avihai
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-05-29 06:59 EDT by Sandro Bonazzola
Modified:	2017-12-24 03:32 EST (History)
CC List:	6 users (show)

See Also:	1448710
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	The default value of the "Discard After Delete" field of block storage domains has been changed from "false" to "true". The "Discard After Delete" checkbox is selected in the Administration Portal and a block storage domain created with the REST API has "Discard After Delete" enabled by default.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-12-20 05:46:37 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	rule-engine: ovirt‑4.2+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	77759	master	MERGED	core: set DAD's default value to true	2017-06-08 07:10 EDT

Groups: None (edit)

Description Sandro Bonazzola 2017-05-29 06:59:27 EDT

As requested in bug #1448710, 
New domain should default to true on Discard and Discard After Delete.

Comment 1 Yaniv Lavi 2017-05-29 08:04:47 EDT

In upgrades the setting should not be changed.

Comment 2 Tal Nisan 2017-06-07 10:18:28 EDT

You need to add a doc text for the changed REST behavior, up until now if you didn't sent a discard value it would have been defaults to false and your patch changes that so please document the new behavior

Comment 3 Sandro Bonazzola 2017-06-07 12:15:47 EDT

(In reply to Tal Nisan from comment #2)
> You need to add a doc text for the changed REST behavior, up until now if
> you didn't sent a discard value it would have been defaults to false and
> your patch changes that so please document the new behavior

Adding needinfo on Idan

Comment 4 Idan Shaby 2017-06-08 07:20:00 EDT

Thanks Tal and Sandro, done.

Comment 6 Avihai 2017-06-28 10:05:37 EDT

Please disregard, wrong bug (1463083 -which is still in post)

Comment 7 Avihai 2017-07-05 05:15:40 EDT

Issue verified , new block SD is created by default with DAD enabled.

Engine :
4.2.0-0.0.master.20170702100738.git46a9f67

VDSM:
4.20.1-120.git28558d7

Comment 8 Sandro Bonazzola 2017-12-20 05:46:37 EST

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Note You need to log in before you can comment on or make changes to this bug.