Bug 1456414 - New domain should default to true on Discard After Delete
Summary: New domain should default to true on Discard After Delete
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ovirt-4.2.0
: ---
Assignee: Idan Shaby
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-05-29 10:59 UTC by Sandro Bonazzola
Modified: 2017-12-24 08:32 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:46:37 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1448710 0 unspecified CLOSED [RFE] Add 'Default SAN discard after delete' option to engine-setup 2022-02-25 15:55:29 UTC
oVirt gerrit 77759 0 master MERGED core: set DAD's default value to true 2017-06-08 11:10:29 UTC

Internal Links: 1448710

Description Sandro Bonazzola 2017-05-29 10:59:27 UTC 
As requested in bug #1448710, 
New domain should default to true on Discard and Discard After Delete.
Comment 1 Yaniv Lavi 2017-05-29 12:04:47 UTC 
In upgrades the setting should not be changed.
Comment 2 Tal Nisan 2017-06-07 14:18:28 UTC 
You need to add a doc text for the changed REST behavior, up until now if you didn't sent a discard value it would have been defaults to false and your patch changes that so please document the new behavior
Comment 3 Sandro Bonazzola 2017-06-07 16:15:47 UTC 
(In reply to Tal Nisan from comment #2)
> You need to add a doc text for the changed REST behavior, up until now if
> you didn't sent a discard value it would have been defaults to false and
> your patch changes that so please document the new behavior

Adding needinfo on Idan
Comment 4 Idan Shaby 2017-06-08 11:20:00 UTC 
Thanks Tal and Sandro, done.
Comment 6 Avihai 2017-06-28 14:05:37 UTC 
Please disregard, wrong bug (1463083 -which is still in post)
Comment 7 Avihai 2017-07-05 09:15:40 UTC 
Issue verified , new block SD is created by default with DAD enabled.

Engine :
4.2.0-0.0.master.20170702100738.git46a9f67

VDSM:
4.20.1-120.git28558d7
Comment 8 Sandro Bonazzola 2017-12-20 10:46:37 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.