Bug 1460325 - Review Request: gnome-flashback - GNOME Flashback desktop session
Review Request: gnome-flashback - GNOME Flashback desktop session
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
26
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On: 1460319 1217991 1460317
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-09 13:25 EDT by Yaakov Selkowitz
Modified: 2017-10-01 12:02 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Yaakov Selkowitz 2017-06-09 13:25:06 EDT
Spec URL: https://yselkowitz.fedorapeople.org/gnome-flashback.spec
SRPM URL: https://yselkowitz.fedorapeople.org/gnome-flashback-3.24.0-1.fc27.src.rpm
Description: GNOME Flashback desktop session
Fedora Account System Username: yselkowitz

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=19933189

This depends on the reinstatement of gnome-panel and gnome-applets at runtime, but not to build.
Comment 1 Robert-André Mauchin 2017-10-01 11:09:17 EDT
SPEC and SRPM are 404, if you still intend to package this for Fedora, please upload them again and I'll review the package.
Comment 2 Robert-André Mauchin 2017-10-01 12:02:13 EDT
Found an SRPM on your profile, I'll review it.

Trivial issues:

 - make %{?_smp_mflags} ⇒ %make_build

 - make install DESTDIR=$RPM_BUILD_ROOT ⇒ %make_install

 - The glib-compile-schemas scripplets shouldn't be used on Fedora 24 and above. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#GSettings_Schema

 - DEBUG util.py:458:   Problem: conflicting requests
DEBUG util.py:458:    - nothing provides gnome-applets needed by gnome-flashback-3.24.0-1.fc28.x86_64

gnome-applets doesn't exist on Rawhide anymore (since Fedora 19 apparently).

 - You have several files containing an invalid FSF address (list at the end of the review). You should notify upstream about this and patch the files. See https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
     generated", "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect
     FSF address)", "FSF All Permissive". 259 files have unknown license.
     Detailed output of licensecheck in /home/bob/packaging/review/gnome-
     flashback/review-gnome-flashback/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gnome-
     flashback-debuginfo , gnome-flashback-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.



Rpmlint
-------
Checking: gnome-flashback-3.24.0-1.fc28.x86_64.rpm
          gnome-flashback-debuginfo-3.24.0-1.fc28.x86_64.rpm
          gnome-flashback-debugsource-3.24.0-1.fc28.x86_64.rpm
          gnome-flashback-3.24.0-1.fc28.src.rpm
gnome-flashback.x86_64: W: only-non-binary-in-usr-lib
gnome-flashback.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gnome-flashback-nm-applet.desktop
gnome-flashback.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gnome-flashback-screensaver.desktop
gnome-flashback.x86_64: W: non-conffile-in-etc /etc/xdg/menus/gnome-flashback-applications.menu
gnome-flashback.x86_64: W: no-manual-page-for-binary gnome-flashback
gnome-flashback.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-flashback-init.desktop value "GNOME-Flashback;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "GNOME-Flashback"; values extending the format should start with "X-"
gnome-flashback.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-flashback.desktop value "GNOME-Flashback;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "GNOME-Flashback"; values extending the format should start with "X-"
gnome-flashback-debugsource.x86_64: W: no-documentation
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-channel-map-private.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-channel-map.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-channel-map.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-card-private.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-card.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-card.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-control.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-control.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-event-role.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-event-role.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-sink-input.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-sink-input.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-sink.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-sink.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-source-output.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-source-output.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-source.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-source.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-stream-private.h
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-stream.c
gnome-flashback-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-flashback-3.24.0-1.fc28.x86_64/gnome-flashback/libsound-applet/gvc/gvc-mixer-stream.h
4 packages and 0 specfiles checked; 23 errors, 6 warnings.

Note You need to log in before you can comment on or make changes to this bug.