Bug 1462500
| Summary: | Add a check that ovirt_env_name is a valid OpenShift namespace identifier | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine-metrics | Reporter: | Shirly Radco <sradco> |
| Component: | RFEs | Assignee: | Shirly Radco <sradco> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Lukas Svaty <lsvaty> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.0.4.2 | CC: | bugs, didi, lsvaty, lveyde, pstehlik, rmeggins, sradco, trichard, ylavi |
| Target Milestone: | ovirt-4.1.5 | Keywords: | FutureFeature |
| Target Release: | 1.0.6 | Flags: | rule-engine:
ovirt-4.1?
rule-engine: planning_ack? rule-engine: devel_ack+ lsvaty: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-metrics-1.0.6 | Doc Type: | Enhancement |
| Doc Text: |
This release adds checks to the ovirt_env_name, to make sure it is a valid OpenShift namespace identifier. If it is not, the metrics script will now fail. The name must be valid in order for the records to be kept by the Elasticsearch running in OpenShift.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-23 08:01:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Metrics | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1419858 | ||
| Bug Blocks: | 1402901, 1475125 | ||
|
Description
Shirly Radco
2017-06-18 07:22:52 UTC
Also you should note somewhere (comment in config.yml) about the prefix, without it people wont be aware there is any, except for logs in metrics, and would have to change namespaces. The user does not need to add a prefix. We add it. I will add a comment with the prefixes that we add. Lukas, Please review the PR: https://github.com/oVirt/ovirt-site/pull/1097/files Commented inside PR. Few more comments: - inside the document you are have diferent z-stream versions, I would prefer just to use y-stream version 4.1 so we wont have to change it. - fqdn/of/engine/machine -> should rather be fqdn-of-engine-machine - its a hostname not path - In the end "It should finish without errors." I would also mention "collectd and fluentd services should be running", this does not make user to check it however in case of issue they are able to debug it. verified in ovirt-engine-metrics-1.0.6-1.el7ev.noarch > ovirt_env_name must be a valid OpenShift namespace identifier in order for
> the records to be kept to the elasticsearch that is running in OpenShift.
Hi Shirly, looking at this again before we publish the Release Notes book, I'm not quite sure what the technical meaning is meant to be here (I'm not familiar with Elasticsearch, but looking it up suggests it searches rather than stores - I may be wrong).
Does this mean:
* The name must be valid in order for the records to be kept by the Elasticsearch running on OpenShift"?
* "The name must be valid in order for metrics to be gathered by the Elasticsearch running on Openshift"?
* Something else?
(In reply to Tahlia Richardson from comment #6) > > ovirt_env_name must be a valid OpenShift namespace identifier in order for > > the records to be kept to the elasticsearch that is running in OpenShift. > > Hi Shirly, looking at this again before we publish the Release Notes book, > I'm not quite sure what the technical meaning is meant to be here (I'm not > familiar with Elasticsearch, but looking it up suggests it searches rather > than stores - I may be wrong). > > Does this mean: > * The name must be valid in order for the records to be kept by the > Elasticsearch running on OpenShift"? That is correct. > * "The name must be valid in order for metrics to be gathered by the > Elasticsearch running on Openshift"? > * Something else? |