Bug 1467717 - NSISdl.dll is not loadable (LIBWINPTHREAD-1.DLL)
Summary: NSISdl.dll is not loadable (LIBWINPTHREAD-1.DLL)
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: mingw-nsis
Version: 28
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-04 19:34 UTC by Xavier BRUGGHEMAN
Modified: 2019-05-28 20:02 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 734905
Environment:
Last Closed: 2019-05-28 20:02:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Xavier BRUGGHEMAN 2017-07-04 19:34:25 UTC
+++ This bug was initially created as a clone of Bug #734905 +++

The NSISdl plugin built for Fedora and RedHat fails to load for NSIS installers which call NSISdl::download or NSISdl::download_quiet when the installer is generated by the makensis command of the mingw-nsis component.

I've used the Dependency Walker (http://www.dependencywalker.com/) to verify that the bug has the same kind of root cause as the original bug (https://bugzilla.redhat.com/show_bug.cgi?id=734905), except that the NSISdl.dll now depends on libwinpthread-1.dll instead of libstdc++-6.dll in the original bug.

The tool shows the following functions from libwinpthread-1.dll being referenced: pthread_getspecific, pthread_key_create, pthread_key_delete, pthread_mutex_lock, pthread_mutex_unlock, pthread_once, pthread_setspecific.


As mentioned by Kevin Kofler in the first comment of the original bug, "NSIS plugins may not depend on any additional DLLs, we have to link them statically.".


I've downloaded and tested some RPMs from https://kojipkgs.fedoraproject.org/packages/mingw-nsis/ to try and see when the regression occurred.

The NSISdl.dll files in /usr/share/nsis/Plugins/x86-ansi/ and /usr/share/nsis/Plugins/x86-unicode/ are both affected in following versions:
- mingw32-nsis-3.01-2.fc26.i686.rpm
- mingw32-nsis-3.01-2.fc26.x86_64.rpm
- mingw32-nsis-3.01-1.el7.x86_64.rpm

The NSISdl.dll file in /usr/share/nsis/Plugins/ is also affected in the following versions:
- mingw32-nsis-2.50-1.fc24.x86_64.rpm
- mingw32-nsis-2.46-17.fc24.i686.rpm
- mingw32-nsis-2.46-16.fc23.x86_64.rpm
- mingw32-nsis-2.46-13.fc21.x86_64.rpm


The last good version I could find is mingw32-nsis-2.46-12.fc21.x86_64.rpm so the regression should be around that time.


Comparing the build logs for NSISdl.dll between the -12 and -13 versions doesn't seem to show any changes to the linker command for that DLL.
- Logs for ..-12 at https://kojipkgs.fedoraproject.org/packages/mingw-nsis/2.46/12.fc21/data/logs/x86_64/build.log
- Logs for ..-13 at https://kojipkgs.fedoraproject.org/packages/mingw-nsis/2.46/13.fc21/data/logs/x86_64/build.log

In both cases it seems to be linked with:
i686-w64-mingw32-g++ -s -mwindows -Wl,--file-alignment,512 -Wl,-Map,build/release/NSISdl/NSISdl.map -static-libgcc -static-libstdc++ -Wl,-e_DllMain@12 -shared -o build/release/NSISdl/NSISdl.dll build/release/NSISdl/asyncdns.o build/release/NSISdl/connection.o build/release/NSISdl/httpget.o build/release/NSISdl/nsisdl.o build/release/NSISdl/util.o -Lbuild/release/api/nsis -lpluginapi -lkernel32 -luser32 -ladvapi32 -lws2_32 -Wl,--out-implib,build/release/NSISdl/libNSISdl.a -Wl,--output-def,build/release/NSISdl/NSISdl.def


I am a bit rusty with GCC, but maybe the situation could be improved by adding -static in there somewhere.

Comment 1 Fedora End Of Life 2018-05-03 08:10:37 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 2 Ben Cotton 2019-05-02 21:52:39 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2019-05-28 20:02:58 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.