Bug 1469009 - Review Request: odcs - On Demand Compose Service
Summary: Review Request: odcs - On Demand Compose Service
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-10 08:58 UTC by Jan Kaluža
Modified: 2017-07-23 08:41 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-07-23 08:41:36 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Jan Kaluža 2017-07-10 08:58:25 UTC
Spec URL: http://jkaluza.fedorapeople.org/odcs.spec
SRPM URL: http://jkaluza.fedorapeople.org/odcs-0.0.3-1.fc24.src.rpm
Description: The On Demand Compose Service (ODCS) creates temporary composes using Pungi tool and manages their lifetime. The composes can be requested by external services or users using the REST API provided by Flask frontend.
Fedora Account System Username: jkaluza

Comment 1 Qixiang Wan 2017-07-10 09:35:41 UTC
You may want to update some python- prefix packages as comments in https://bugzilla.redhat.com/show_bug.cgi?id=1468971. I'll check all these packages and update to you.

Comment 2 Qixiang Wan 2017-07-10 10:40:42 UTC
I had another check on the packages list, some of the python-* packages are named as python2-* from Fedora 26, since Fedora 26 is not GA yet, I think we can keep it as now and update if we find problem with Fedora 26 after GA. The only one exception is python-futures which is available with python2-futures from Fedora 24.

Comment 3 Jan Kaluža 2017-07-11 12:19:39 UTC
Updated package:

Spec URL: http://jkaluza.fedorapeople.org/odcs.spec
SRPM URL: http://jkaluza.fedorapeople.org/odcs-0.0.3-2.fc24.src.rpm

Comment 4 Igor Gnatenko 2017-07-17 07:12:36 UTC
Looks good apart from few things:

- a lot of python- prefixed packages, must be using python2- prefix if available (six, sqlalchemy, pyopenssl are definitely available in that variant)
- add `-p` flag for installing files to preserve timestamp
- BuildRequires:    git, do you really need git for building? if yes, isn't git-core sufficient?

Comment 5 Jan Kaluža 2017-07-17 08:50:38 UTC
Thanks Igor, updated package is here:

Spec URL: http://jkaluza.fedorapeople.org/odcs.spec
SRPM URL: http://jkaluza.fedorapeople.org/odcs-0.0.3-3.fc24.src.rpm

Comment 6 Igor Gnatenko 2017-07-17 09:27:26 UTC
Nothing I can complain about ;)

Comment 7 Jan Kaluža 2017-07-17 09:38:58 UTC
Thanks for the review, Igor :).

Comment 8 Gwyn Ciesla 2017-07-17 23:28:35 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/odcs


Note You need to log in before you can comment on or make changes to this bug.