Bug 1469255 - stonith-action=poweroff leads to failure in fence-agent
stonith-action=poweroff leads to failure in fence-agent
Status: ASSIGNED
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pacemaker (Show other bugs)
7.4
Unspecified Unspecified
unspecified Severity unspecified
: rc
: 7.6
Assigned To: Klaus Wenninger
cluster-qe@redhat.com
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-10 14:19 EDT by Klaus Wenninger
Modified: 2017-12-06 20:09 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Klaus Wenninger 2017-07-10 14:19:24 EDT
Description of problem:
According to documentation stonith-action is either set to reboot or poweroff.
In the poweroff-case this is propagated 1:1 into the RHCS-fence-agents which can't handle that action.


Version-Release number of selected component (if applicable):
found with upstream-master but there shouldn't be a difference to 1.1.17

How reproducible:
100%

Steps to Reproduce:
1. setup a config with a RHCS fencing-agent (e.g. fence_sbd)
2. pcs property set stonith-action=poweroff
3. have pacemaker trigger fencing e.g. by cutting the networking connection

Actual results:
Jul 10 10:52:46 [2520] bsul0799 stonith-ng:  warning: log_action:       fence_sbd[24239] stderr: [ Failed: Unrecognised action 'poweroff' ]

Expected results:
fence-agent properly turns off the fenced node

Additional info:
a test with 'pcs stonith fence ...' doesn't show the problem
stonith-action=off leads to pacemaker initiated fencing working properly but fencing with pcs is failing
Comment 2 michal novacek 2017-08-04 06:02:21 EDT
qa-ack+: setting stonith-action=poweroff must work for all the fence agents
Comment 3 Klaus Wenninger 2017-11-03 10:51:14 EDT
moved to rhel-7.6 due to effort constraints
Comment 4 Andrew Beekhof 2017-11-05 17:15:59 EST
Really?  Shouldn't be that hard to map 'poweroff' to 'off' inside the stonith library
Comment 5 Ken Gaillot 2017-12-06 20:09:21 EST
Pacemaker currently accepts the values "reboot", "off", or "poweroff" for stonith-action.

LHA-style external/* agents (which are supported upstream, but not in RHEL) do support "poweroff". Remapping "poweroff" to "off" globally would break those.

I see two reasonable approaches:

1. Drop support for stonith-action=poweroff. If someone wants to use poweroff with LHA agents, they must set stonith-action=off and pcmk_off_action=poweroff. (This is the cleanest and easiest option development-wise, but involves some pain for LHA users.)

2. Remap stonith-action=poweroff to stonith-action=off, and for LHA agents, also assume pcmk_off_action=poweroff if not otherwise set. (This is easiest for all users.)

Opinions?

Note You need to log in before you can comment on or make changes to this bug.