REVIEW: https://review.gluster.org/17766 (cli/xml: fix return handling) posted (#1) for review on release-3.8 by Atin Mukherjee (amukherj)
Description of problem: when there are large number of volumes in my case 100 volumes, gluster v status --xml command fails Version-Release number of selected component (if applicable): release-3.8 How reproducible: 100% Steps to Reproduce: 1. create & start 100 volume 2. execure gluster v status --xml Actual results: [root@dhcp46-22 ~]# gluster v status all clients --xml [root@dhcp46-22 ~]# echo $? 92
COMMIT: https://review.gluster.org/17766 committed in release-3.8 by Niels de Vos (ndevos) ------ commit b7b13c8cd295fa2e9fba9cc77211e576469e9581 Author: Atin Mukherjee <amukherj> Date: Wed Jul 5 14:58:50 2017 +0530 cli/xml: fix return handling The return code of xmlTextWriter* APIs says it returns either the bytes written (may be 0 because of buffering) or -1 in case of error. Now if the volume of the xml data payload is not huge then most of the time the data to be written gets buffered, however when this grows sometimes this APIs will return the total number of bytes written and then it becomes absolutely mandatory that every such call is followed by XML_RET_CHECK_AND_GOTO otherwise we may end up returning a non zero ret code which would result into the overall xml generation to fail. >Reviewed-on: https://review.gluster.org/17702 >Smoke: Gluster Build System <jenkins.org> >Reviewed-by: Amar Tumballi <amarts> >CentOS-regression: Gluster Build System <jenkins.org> >Reviewed-by: Gaurav Yadav <gyadav> Change-Id: I02ee7076e1d8c26cf654d3dc3e77b1eb17cbdab0 BUG: 1470495 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: https://review.gluster.org/17766 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Samikshan Bairagya <samikshan> Reviewed-by: Niels de Vos <ndevos>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.15, please open a new bug report. glusterfs-3.8.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] blah [2] https://www.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.15, please open a new bug report. glusterfs-3.8.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2017-August/000080.html [2] https://www.gluster.org/pipermail/gluster-users/