Bug 1471301 - [RFE] possibility to hide Red Hat CloudForms Engine text in top left Corner of OPs and SUI
Summary: [RFE] possibility to hide Red Hat CloudForms Engine text in top left Corner o...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Allen W
QA Contact: Angelina Vasileva
URL:
Whiteboard:
: 1518284 1530321 (view as bug list)
Depends On:
Blocks: 1679295 1692488 1693757
TreeView+ depends on / blocked
 
Reported: 2017-07-14 23:23 UTC by Loic Avenel
Modified: 2021-03-11 15:27 UTC (History)
13 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1693757 (view as bug list)
Environment:
Last Closed: 2019-12-13 14:55:08 UTC
Category: Feature
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Loic Avenel 2017-07-14 23:23:16 UTC
Description of problem:

possibility to hide Red Hat CloudForms Engine text in top left Corner of OPs and SUI.
This is a requirement from CCSP

Comment 8 CFME Bot 2018-07-30 15:44:45 UTC
New commit detected on ManageIQ/manageiq-api/master:

https://github.com/ManageIQ/manageiq-api/commit/44b78e8faa9dfd7243df9bb8fad7861b34026812
commit 44b78e8faa9dfd7243df9bb8fad7861b34026812
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Jul 27 11:41:47 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Jul 27 11:41:47 2018 -0400

    Use Vmdb::Appliance.PRODUCT_NAME instead of calling i18n

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/controllers/api/api_controller.rb | 2 +-
 spec/requests/entrypoint_spec.rb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2018-08-06 18:26:08 UTC
New commits detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/a08c049e686d6e93b695103b30dc5f499a9716d5
commit a08c049e686d6e93b695103b30dc5f499a9716d5
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Jul 27 11:44:00 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Jul 27 11:44:00 2018 -0400

    Use Vmdb::Appliance.PRODUCT_NAME instead of calling i18n

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/mailers/generic_mailer.rb | 2 +-
 app/models/embedded_ansible_worker/object_management.rb | 10 +-
 app/models/miq_server/update_management.rb | 2 +-
 config/initializers/postgres_required_versions.rb | 4 +-
 spec/mailers/generic_mailer_spec.rb | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)


https://github.com/ManageIQ/manageiq/commit/a217bccb10f5dc4ff41aae1b225cb011ce16936f
commit a217bccb10f5dc4ff41aae1b225cb011ce16936f
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Jul 27 11:44:35 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Jul 27 11:44:35 2018 -0400

    Add option for customizing the product title through advanced settings

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 config/settings.yml | 1 +
 lib/vmdb/appliance.rb | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)


https://github.com/ManageIQ/manageiq/commit/2d3b069a76a87a35ade6d75742dda9c80afd1834
commit 2d3b069a76a87a35ade6d75742dda9c80afd1834
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul 30 03:54:04 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul 30 03:54:04 2018 -0400

    Add missing custom_login_logo and custom_brand to settings

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 config/settings.yml | 2 +
 1 file changed, 2 insertions(+)

Comment 10 CFME Bot 2018-09-06 12:43:33 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/712c431f96586cef1fb5f7b0fee5931ba6f70b53
commit 712c431f96586cef1fb5f7b0fee5931ba6f70b53
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul 30 04:29:14 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul 30 04:29:14 2018 -0400

    Refactored custom logo uploading methods for better readability

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/controllers/ops_controller/settings/upload.rb | 35 +-
 1 file changed, 18 insertions(+), 17 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/da1cfb5770b969625b529858e24e72242d9c6caa
commit da1cfb5770b969625b529858e24e72242d9c6caa
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul 30 05:37:38 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul 30 05:37:38 2018 -0400

    Allow to upload and display a custom brand image on login/header

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/controllers/ops_controller/settings/common.rb | 9 +-
 app/controllers/ops_controller/settings/upload.rb | 11 +-
 app/views/dashboard/login.html.haml | 2 +-
 app/views/layouts/_header.html.haml | 2 +-
 app/views/ops/_settings_custom_logos_tab.html.haml | 35 +-
 config/routes.rb | 1 +
 6 files changed, 52 insertions(+), 8 deletions(-)

Comment 11 CFME Bot 2018-10-12 21:52:28 UTC
New commit detected on ManageIQ/manageiq-api/master:

https://github.com/ManageIQ/manageiq-api/commit/4ff21f4e0e06faa1b2e37b76fdc8ee191ce6985c
commit 4ff21f4e0e06faa1b2e37b76fdc8ee191ce6985c
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul 30 12:40:38 2018 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul 30 12:40:38 2018 -0400

    Add the /api/product_info route with product and branding info

    https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/controllers/api/api_controller.rb | 37 +-
 app/controllers/api/base_controller.rb | 8 +-
 config/routes.rb | 1 +
 spec/requests/entrypoint_spec.rb | 24 +-
 4 files changed, 56 insertions(+), 14 deletions(-)

Comment 14 Dave Johnson 2018-11-29 09:04:46 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 19 Dave Johnson 2018-12-18 17:02:12 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 20 Allen W 2018-12-18 20:20:49 UTC
Here's a pr for this, not merged yet, but maybe someday soon... https://github.com/ManageIQ/manageiq-ui-service/pull/1513

Comment 21 Dave Johnson 2018-12-19 11:02:37 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 24 Dave Johnson 2019-01-02 19:02:41 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 25 Allen W 2019-01-04 13:32:53 UTC
And we're merged!

Comment 26 Yuri Rudman 2019-01-09 14:05:32 UTC
*** Bug 1518284 has been marked as a duplicate of this bug. ***

Comment 27 Loic Avenel 2019-01-24 13:33:46 UTC
*** Bug 1530321 has been marked as a duplicate of this bug. ***

Comment 31 CFME Bot 2019-02-15 07:25:10 UTC
New commit detected on ManageIQ/manageiq-api/master:

https://github.com/ManageIQ/manageiq-api/commit/10c676ed435d32f31e46fb66be28d9117246f7ed
commit 10c676ed435d32f31e46fb66be28d9117246f7ed
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jan 28 07:04:35 2019 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jan 28 07:04:35 2019 -0500

    Provide the path to the custom branding assets instead of boolean

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1471301

 app/controllers/api/api_controller.rb | 6 +-
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 33 Angelina Vasileva 2019-05-06 08:59:54 UTC
Fixed and verified in 5.11.0.2.20190430174828_0e34dea


Note You need to log in before you can comment on or make changes to this bug.