Bug 1474570 - Cannot change dwh sampling scale with 'engine-setup --reconfigure-dwh-scale'
Summary: Cannot change dwh sampling scale with 'engine-setup --reconfigure-dwh-scale'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-dwh
Version: 4.1.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Ido Rosenzwig
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks: 1519756
TreeView+ depends on / blocked
 
Reported: 2017-07-25 01:19 UTC by Bimal Chollera
Modified: 2020-09-10 11:01 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
The data warehouse scale can now be changed using the command "engine-setup --reconfigure-dwh-scale".
Clone Of:
: 1519756 (view as bug list)
Environment:
Last Closed: 2018-05-15 17:35:46 UTC
oVirt Team: Integration
Target Upstream Version:
Embargoed:
irosenzw: needinfo-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 3178721 0 None None None 2017-09-11 20:17:56 UTC
Red Hat Product Errata RHEA-2018:1487 0 None None None 2018-05-15 17:35:58 UTC
oVirt gerrit 84674 0 master MERGED Revert "packaging: setup: Configure scale only on new database" 2021-01-25 08:27:56 UTC
oVirt gerrit 84676 0 ovirt-engine-dwh-4.1 MERGED Revert "packaging: setup: Configure scale only on new database" 2021-01-25 08:28:38 UTC

Description Bimal Chollera 2017-07-25 01:19:04 UTC
Description of problem:

The "engine-setup --reconfigure-dwh-scale" doesn't seem to ask user about changing for sampling scale setup from Basic to Full and vice versa.  

Version-Release number of selected component (if applicable):

Problem seen on ovirt 4.1.x and 4.0.x

ovirt-engine-4.1.3.5-0.1.el7.noarch
ovirt-engine-dwh-4.1.1-1.el7ev.noarch
ovirt-engine-dwh-setup-4.1.1-1.el7ev.noarch

ovirt-engine-4.0.7.4-0.1.el7ev.noarch
ovirt-engine-dwh-4.0.7-2.el7ev.noarch
ovirt-engine-dwh-setup-4.0.7-2.el7ev.noarch

How reproducible:

100% 

Steps to Reproduce:
1. Issue:  engine-setup --reconfigure-dwh-scale
   
Actual results:

   User will NOT be asked about sampling scale

~~~
    --== MISC CONFIGURATION ==--
         
          Please choose Data Warehouse sampling scale:
          (1) Basic
          (2) Full
          (1, 2)[1]: 
~~~         

Expected results:

Should ask user if they setting sampling scale.


Additional info:

Seems like broken due to BZ https://bugzilla.redhat.com/show_bug.cgi?id=1365427

Comment 2 Yaniv Lavi 2017-07-31 09:18:31 UTC
Can you provide the manual steps to reconfiguare the dwh to full collection?

Comment 3 Shirly Radco 2017-07-31 09:29:19 UTC
A workaround for this issue will be to add a conf file to ovirt-engine-dwhd.conf.d/
with a prefix greater then 10, like  99-my-scale.conf.

Add to the file the following lines:
DWH_TABLES_KEEP_SAMPLES=24
DWH_TABLES_KEEP_HOURLY=1440
DWH_TABLES_KEEP_DAILY=43800

and restart ovirt-engine-dwhd service

Comment 4 Yaniv Lavi 2017-08-07 09:22:59 UTC
Can you please pass the info in comment 3 to the customer?
Can you create a KBase with this info?

Comment 6 Yaniv Kaul 2017-11-23 14:33:42 UTC
Ido, is this going to be in 4.2.0?

Comment 7 Ido Rosenzwig 2017-11-26 11:54:02 UTC
Yes. Sent a patch.

Comment 8 Ido Rosenzwig 2017-11-26 12:16:49 UTC
Do we want this fix in 4.1 also ?

Comment 9 Ido Rosenzwig 2017-11-28 06:56:45 UTC
The fix for this bug was to revert the patch for https://bugzilla.redhat.com/1365427

The author decided to show the question to the user only when a new database is created, what broke the --reconfigure-dwh-scale option.

https://bugzilla.redhat.com/show_bug.cgi?id=1365427#c2

Comment 11 Lukas Svaty 2017-12-06 16:42:36 UTC
No sampling scale configurable during --reconfigure-dwh-scale

tested in ovirt-engine-dwh-setup-4.2.1-0.2.beta1.20171026134154.el7ev.noarch

Comment 12 Ido Rosenzwig 2017-12-07 07:56:23 UTC
Lukas, can you please describe how did you verify?

I just verified as the following:

1. clean engine-setup
2. engine-setup --reconfigure-dwh-scale with the following output:
[root@localhost ~]# engine-setup --reconfigure-dwh-scale
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging-jboss.conf', '/etc/ovirt-engine-setup.conf.d/10-packaging.conf', '/etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf']
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20171207024923-62vxvy.log
          Version: otopi-1.7.6_master (otopi-1.7.6-0.0.master.20171204131110.gitd5016f6.el7.centos)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment setup
[ INFO  ] Stage: Environment customization
         
          --== PRODUCT OPTIONS ==--
         
         
          --== PACKAGES ==--
         
[ INFO  ] ovirt-provider-ovn already installed, skipping.
[ INFO  ] Checking for product updates...
[ INFO  ] No product updates found
         
          --== NETWORK CONFIGURATION ==--
         
          Setup can automatically configure the firewall on this system.
          Note: automatic configuration of the firewall may overwrite current settings.
          NOTICE: iptables is deprecated and will be removed in future releases
          Do you want Setup to configure the firewall? (Yes, No) [Yes]: 
[ INFO  ] firewalld will be configured as firewall manager.
         
          --== DATABASE CONFIGURATION ==--
         
          The detected DWH database size is 23 MB.
          Setup can backup the existing database. The time and space required for the database backup depend on its size. This process takes time, and in some cases (for instance, when the size is few GBs) may take several hours to complete.
          If you choose to not back up the database, and Setup later fails for some reason, it will not be able to restore the database and all DWH data will be lost.
          Would you like to backup the existing database before upgrading it? (Yes, No) [Yes]: 
          Perform full vacuum on the oVirt engine history
          database ovirt_engine_history@localhost?
          This operation may take a while depending on this setup health and the
          configuration of the db vacuum process.
          See https://www.postgresql.org/docs/9.0/static/sql-vacuum.html
          (Yes, No) [No]: 
         
          --== OVIRT ENGINE CONFIGURATION ==--
         
          Perform full vacuum on the engine database engine@localhost?
          This operation may take a while depending on this setup health and the
          configuration of the db vacuum process.
          See https://www.postgresql.org/docs/9.0/static/sql-vacuum.html
          (Yes, No) [No]: 
         
          --== STORAGE CONFIGURATION ==--
         
         
          --== PKI CONFIGURATION ==--
         
         
          --== APACHE CONFIGURATION ==--
         
         
          --== SYSTEM CONFIGURATION ==--
         
         
          --== MISC CONFIGURATION ==--
         
          Please choose Data Warehouse sampling scale:
          (1) Basic
          (2) Full
          (1, 2)[1]: 2
         
          --== END OF CONFIGURATION ==--
         
[ INFO  ] Stage: Setup validation
...

Comment 13 Lukas Svaty 2017-12-14 15:43:30 UTC
fix was included only in latest version ovirt-engine-dwh-setup-4.2.1-1.el7ev.noarch

Comment 17 errata-xmlrpc 2018-05-15 17:35:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1487

Comment 18 Franta Kust 2019-05-16 13:09:45 UTC
BZ<2>Jira Resync


Note You need to log in before you can comment on or make changes to this bug.