Bug 1475780 - [RFE][scale] - Set "blkdiscard" as the default zero method
Summary: [RFE][scale] - Set "blkdiscard" as the default zero method
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: RFEs
Version: 4.18.15
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.2.2
: ---
Assignee: Idan Shaby
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On: 1327886 1367806
Blocks: wipe_disk_using_blkdiscard 1314382
TreeView+ depends on / blocked
 
Reported: 2017-07-27 10:40 UTC by Idan Shaby
Modified: 2018-04-06 05:06 UTC (History)
9 users (show)

Fixed In Version:
Clone Of: 1367806
Environment:
Last Closed: 2018-03-29 11:03:36 UTC
oVirt Team: Storage
Embargoed:
tnisan: ovirt-4.2?
tnisan: exception?
ratamir: testing_plan_complete-
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 85532 0 'None' 'MERGED' 'blockdev: Use safe default value for zeroout' 2019-11-25 19:03:50 UTC
oVirt gerrit 88026 0 'None' 'MERGED' 'config: change default zero method to blkdiscard' 2019-11-25 19:03:50 UTC
oVirt gerrit 89153 0 'None' 'MERGED' 'config: change default zero method to blkdiscard' 2019-11-25 19:03:50 UTC
oVirt gerrit 89155 0 'None' 'MERGED' 'blockdev: Use safe default value for zeroout' 2019-11-25 19:03:50 UTC

Comment 1 Yaniv Kaul 2017-07-30 08:49:07 UTC
I think this is 'blkdiscard --zero' option here.
When we support just 'blkdiscard' (if the storage promises to return zeros on discarded blocks), it's a different option, no?

Comment 2 Idan Shaby 2017-07-30 09:09:09 UTC
Yes, but since we're talking about the config value "zero_method" (see Bug 1367806), the option name is "blkdiscard".

I will open a new BZ to track the second RFE you implied to, i.e when the user removes a disk with an intention to zero and discard it, and the underlying storage support discard_zeroes_data, then the disk is only discarded (and not wiped).

Comment 3 Allon Mureinik 2017-09-14 15:34:52 UTC
This depends on the scale's team ability to prove this method is safe.

Comment 9 Kevin Alon Goldblatt 2018-03-27 08:52:11 UTC
Verified with the following code:
----------------------------------------
ovirt-engine-4.2.2.5-0.1.el7.noarch
vdsm-4.20.23-1.el7ev.x86_64

Verified with the following scenario:
----------------------------------------
1. Created a VM with 10G iscsi disk
2. Started the VM and wrote a 3G of data to the disk
3. Stop the VM
4. Remove the disk
5. Calculated the time that passes between the log message "Zero volume thread started for volume <volume_id>" and the log message "Zero volume <volume_id> task <task_id> completed" >>>>> 4 seconds passed.


Moving to VERIFIED

Comment 10 Sandro Bonazzola 2018-03-29 11:03:36 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.