Bug 1481991
| Summary: | Clicking "Load DataCenters" with no url on a new compute resource causes an error instead of validation message | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | orabin | ||||||||
| Component: | Compute Resources - RHEV | Assignee: | Adam Ruzicka <aruzicka> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Nikhil Kathole <nkathole> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 6.3.0 | CC: | aruzicka, bbuckingham, ehelms, inecas, nkathole, pcreech | ||||||||
| Target Milestone: | Unspecified | Keywords: | Triaged | ||||||||
| Target Release: | Unused | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2018-02-21 17:07:15 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 1316553 [details] after applying patch Apparently the we try to establish the connection before the validations are run, basically making this a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1467664, after switching before_validation to after_validation I'm getting validations on the URL, but the undefined method + still persists as it is caused by older restclient. Validations are added by https://bugzilla.redhat.com/show_bug.cgi?id=1467664, undefined method '+' for NilClass is fixed in rest-client > 2. Currently rest-client is locked to 1.8.0 by runcible (pulled in by katello). The dependency is raised by runcible-2.0.0. Moving to POST because both issues described here are fixed in upstream. Created redmine issue http://projects.theforeman.org/issues/21718 from this bug Upstream bug assigned to aruzicka Upstream bug assigned to aruzicka Adam: would the fix upstream apply also to sat 6.3? Yes, it applies cleanly and seems to fix the issue for me. Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/21718 has been resolved. Adam, This didn't cherry-pick cleanly for me, and I'm not that familiar with foreman's codebase. Could you do the pick for me? Thanks, Patrick Hello, I opened the MR, hope there's everything alright with it. VERIFIED Version Tested: Satellite-6.3 Snap 27 clicking load datacenter while creating new rhev compute resource without URL shows Validation message URL can't be blank and is invalid. (see attachment) Created attachment 1364058 [details]
screenshot of UI
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:0336 |
Created attachment 1314014 [details] Submitting RHEV compute resource with no url Description of problem: Creating a new RHEV compute resource with no url presents an error message "undefined method `+' for nil:NilClass" instead of showing a validation error about the empty url. Version-Release number of selected component (if applicable): 6.3 Snap 11 Steps to Reproduce: 1. Go to "Infrastructure" -> "Compute resources" 2. Click "Create compute resource" 3. Choose "Provider" RHEV 4. Click "Load Datacenters" Actual results: undefined method `+' for nil:NilClass Expected results: validation message: url can't be blank Additional info: When clicking submit instead of "Load Datacenters" the same message appears with "Oops, we're sorry but something went wrong undefined method `+' for nil:NilClass" (screenshot attached)