Bug 1485962 - gluster-block profile needs to have strict-o-direct
Summary: gluster-block profile needs to have strict-o-direct
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1486115 1486122
TreeView+ depends on / blocked
 
Reported: 2017-08-28 14:51 UTC by Pranith Kumar K
Modified: 2017-12-08 17:39 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1486115 1486122 (view as bug list)
Environment:
Last Closed: 2017-12-08 17:39:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2017-08-28 14:51:37 UTC
Description of problem:
    tcmu-runner is not going to open block with O_SYNC anymore
    so writes have a chance of getting cached in write-behind
    when that happens, there is a chance that on failover some
    data could be stuck in cache and be lost. So strict-o-direct should be on


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-08-28 14:52:31 UTC
REVIEW: https://review.gluster.org/18120 (gluster-block: strict-o-direct should be on) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2017-08-29 13:16:36 UTC
REVIEW: https://review.gluster.org/18120 (gluster-block: strict-o-direct should be on) posted (#2) for review on master by Shyamsundar Ranganathan (srangana)

Comment 3 Worker Ant 2017-08-29 13:36:11 UTC
COMMIT: https://review.gluster.org/18120 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 3b5f4de6926780b34570731ad34992a4735dd410
Author: Pranith Kumar K <pkarampu>
Date:   Mon Aug 28 19:33:30 2017 +0530

    gluster-block: strict-o-direct should be on
    
    tcmu-runner is not going to open block with O_SYNC anymore
    so writes have a chance of getting cached in write-behind
    when that happens, there is a chance that on failover some
    data could be stuck in cache and be lost.
    
    BUG: 1485962
    Change-Id: If9835d914821dfc4ff432dc96775677a55d2918f
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/18120
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Shyamsundar Ranganathan <srangana>

Comment 4 Shyamsundar 2017-12-08 17:39:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.