Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1488425

Summary:	[RFE][Tracker] Include new drivers in virtio-win in windows guest tools.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Yaniv Lavi <ylavi>
Component:	rhv-guest-tools-iso	Assignee:	Gal Zaidman <gzaidman>
Status:	CLOSED ERRATA	QA Contact:	Petr Matyáš <pmatyas>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.1.6	CC:	dfediuck, lsvaty
Target Milestone:	ovirt-4.3.4	Keywords:	FutureFeature, Tracking, ZStream
Target Release:	4.3.1	Flags:	pstehlik: testing_plan_complete-
Hardware:	x86_64
OS:	Windows
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-20 14:47:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1578764, 1578775, 1578782, 1578785, 1667515
Bug Blocks:

Description Yaniv Lavi 2017-09-05 11:18:44 UTC

Add new driver to Windows guest tools:

* vioinput - for the virtio-keyboard-pci, virtio-mouse-pci,
virtio-tablet-pci, and virtio-input-host-pci device on Windows 7 and
newer.

* qemufwcfg - for the built-in system FW Cfg device on
Windows 10 and Windows Server 2016. The driver has no functionality,
it only prevents an unrecognized device from showing in Device
Manager.

* smbus - for the built-in system SMBus device on Windows
2008. The driver has no functionality, it only prevents an
unrecognized device from showing in Device Manager.

* The qemupciserial driver is now signed and works on 64-bit Windows.

Comment 1 Yaniv Lavi 2017-09-05 11:21:27 UTC

Since this requires considerable amount of work we will only target latest with Windows desktop and server to include these.

Comment 2 Yaniv Kaul 2017-09-05 14:04:55 UTC

(In reply to Yaniv Lavi (Dary) from comment #0)
> Add new driver to Windows guest tools:
> 
> * vioinput - for the virtio-keyboard-pci, virtio-mouse-pci,
> virtio-tablet-pci, and virtio-input-host-pci device on Windows 7 and
> newer.

Since you can't get rid of the old devices (the PS2 devices), what's the advantage of using them?

Does oVirt even support them? I suspect we'll need a bug per each device or so.

> 
> * qemufwcfg - for the built-in system FW Cfg device on
> Windows 10 and Windows Server 2016. The driver has no functionality,
> it only prevents an unrecognized device from showing in Device
> Manager.
> 
> * smbus - for the built-in system SMBus device on Windows
> 2008. The driver has no functionality, it only prevents an
> unrecognized device from showing in Device Manager.
> 
> * The qemupciserial driver is now signed and works on 64-bit Windows.

Comment 3 Yaniv Lavi 2017-09-06 08:32:53 UTC

(In reply to Yaniv Kaul from comment #2)
> (In reply to Yaniv Lavi (Dary) from comment #0)
> > Add new driver to Windows guest tools:
> > 
> > * vioinput - for the virtio-keyboard-pci, virtio-mouse-pci,
> > virtio-tablet-pci, and virtio-input-host-pci device on Windows 7 and
> > newer.
> 
> Since you can't get rid of the old devices (the PS2 devices), what's the
> advantage of using them?

The driver removes warning in the Windows device manager.

> 
> Does oVirt even support them? I suspect we'll need a bug per each device or
> so.

Yes, this should be released upstream as well.

Comment 4 Yaniv Kaul 2017-09-06 08:39:47 UTC

(In reply to Yaniv Lavi (Dary) from comment #3)
> (In reply to Yaniv Kaul from comment #2)
> > (In reply to Yaniv Lavi (Dary) from comment #0)
> > > Add new driver to Windows guest tools:
> > > 
> > > * vioinput - for the virtio-keyboard-pci, virtio-mouse-pci,
> > > virtio-tablet-pci, and virtio-input-host-pci device on Windows 7 and
> > > newer.
> > 
> > Since you can't get rid of the old devices (the PS2 devices), what's the
> > advantage of using them?
> 
> The driver removes warning in the Windows device manager.

Not the new virtio ones. oVirt doesn't expose them. 
The smbus and pciserial perhaps. 

> 
> > 
> > Does oVirt even support them? I suspect we'll need a bug per each device or
> > so.
> 
> Yes, this should be released upstream as well.

Comment 6 Sandro Bonazzola 2019-01-21 08:28:36 UTC

re-targeting to 4.3.1 since this BZ has not been proposed as blocker for 4.3.0.
If you think this bug should block 4.3.0 please re-target and set blocker flag.

Comment 8 Sandro Bonazzola 2019-02-18 07:54:51 UTC

Moving to 4.3.2 not being identified as blocker for 4.3.1.

Comment 10 Petr Matyáš 2019-05-14 08:06:06 UTC

Tested on RHV-toolsSetup_4.3_8.iso

I can see drivers for qemufwcfg and smbus, however vioinput is not there.
If it is not necessary it needs to be mentioned as per description it is necessary.

Comment 11 Sandro Bonazzola 2019-05-14 09:10:31 UTC

vioinput was handled on bug #1578764 which has been closed not having customer requests for it and so considered not necessary.

Comment 12 Petr Matyáš 2019-05-14 09:50:09 UTC

Well in that case, verified on RHV-toolsSetup_4.3_8.iso

Comment 14 errata-xmlrpc 2019-06-20 14:47:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1558