Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1494917

Summary: [UI] - 'Manage Networks' dialog - Fix minor bugs in the dialog
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: Frontend.WebAdminAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: low Docs Contact:
Priority: low    
Version: 4.2.0CC: awels, bugs, gshereme, mburman, mgoldboi, tjelinek
Target Milestone: ovirt-4.2.2Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 11:15:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
record1
none
screenshot1
none
screenshot2
none
new record none

Description Michael Burman 2017-09-24 06:34:52 UTC
Created attachment 1330075 [details]
record1

Description of problem:
[UI] - 'Manage Networks' dialog -  Fix minor bugs in the dialog.

After fixing and verifying BZ 1491598, this dialog still has some minor issues such as:

- Unnecessary scroll bar, the dialog currently has 3 scroll bars?? why? one should be removed from this dialog as it gives nothing at all.  

- The size of the dialog should be bigger and wider.

- There is a bug in the dialog that when pressing once on one of the radio buttons and then using the expand header of the columns, the dialog is getting 

Version-Release number of selected component (if applicable):
4.2.0-0.0.master.20170921184504.gitfcfc9a7.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Have a cluster with multiple networks around 15
2. Via Cluster>Networks open 'Manage Networks' dialog and see description above^^

Comment 1 Michael Burman 2017-09-24 06:35:54 UTC
- There is a bug in the dialog that when pressing once on one of the radio buttons and then using the expand header of the columns, the dialog is throwing you to the right..

Comment 2 Alexander Wels 2017-11-03 12:49:04 UTC
So I tried in 3 different browsers (Chrome/FF/IE11) and I don't see the extra outer scroll bar at all. I do see the jump when re-sizing the columns after clicking on the radio buttons. I double checked 4.1 and this also has the jumping behavior, so its not new.

Comment 3 Michael Burman 2018-01-07 12:31:19 UTC
Alex,
Still behaves the same on 4.2.1-0.2.el7
jump when re-sizing the columns after clicking on the radio buttons
This bug has failed QA

Comment 4 Michael Burman 2018-01-07 12:32:59 UTC
Alex,
Can we enlarge this dialog? it will be look better if it will be a bit bigger.

Comment 5 Michael Burman 2018-01-07 12:46:50 UTC
Another thing Alex,
There is a bug in the scroll bar, the right one. 
Note(i have attached screenshots..) if you have 9 network, the scroll bar appears on the dialog border. But if adding one more network, the scroll bar moves to the inside and hoover on top of the columns. It doesn't look good and there is a difference in the look between 9 networks or more then 9 networks. 
It should be consistent.

Comment 6 Michael Burman 2018-01-07 12:48:10 UTC
Created attachment 1378069 [details]
screenshot1

Comment 7 Michael Burman 2018-01-07 12:48:35 UTC
Created attachment 1378070 [details]
screenshot2

Comment 8 Alexander Wels 2018-01-09 16:29:54 UTC
I see the issue with the extra scrollbar if you have 9 networks, I will see if I can fix that. Not sure how you managed to resize as the resize was explicitly disabled in the dialog. When you say bigger, do you mean wider or taller?

Comment 9 Michael Burman 2018-01-10 07:44:42 UTC
(In reply to Alexander Wels from comment #8)
> I see the issue with the extra scroll-bar if you have 9 networks, I will see
> if I can fix that. Not sure how you managed to re-size as the re-size was
> explicitly disabled in the dialog. When you say bigger, do you mean wider or
> taller?

You mean re-size what? the columns? not sure i got you, which re-size has been disabled?

If you mean the re-size of the columns, then i see that on master it was indeed disabled, but the current d/s build(4.2.1-0.2.el7) still allow to re-size the columns in this dialog. 
The bug with the scroll bar do exist on master though.

- Please note, that even when the re-size is disabled there is still a bug with the jump issue. 
For example - Open the manage network dialog , press on the default route radio button and then press on 'Assign all' or 'Required all' checkbox. You will see the jump bug. Attaching record of the jump issue even when the re-size disabled.

About the the dialog's size, i mean taller and a bit wider. 
Thanks Alexander)

Comment 10 Michael Burman 2018-01-10 07:45:14 UTC
Created attachment 1379372 [details]
new record

Comment 11 Alexander Wels 2018-01-10 19:29:05 UTC
So I spend some time investigating the problem with the clicking the checkbox header and I have made no headway. Basically the problem as I see it is that after you click on a radio button the contents inside grid have focus, and when you click on the check box header, to assign all, that doesn't change, and after a refresh it tries to show what it is focused on.

I have tried several different things to force it back to the left but nothing has worked consistently across browsers. Can we split that particular minor issue out into its own bug and check the rest?

Comment 12 Michael Burman 2018-01-10 20:04:27 UTC
(In reply to Alexander Wels from comment #11)
> So I spend some time investigating the problem with the clicking the
> checkbox header and I have made no headway. Basically the problem as I see
> it is that after you click on a radio button the contents inside grid have
> focus, and when you click on the check box header, to assign all, that
> doesn't change, and after a refresh it tries to show what it is focused on.
> 
> I have tried several different things to force it back to the left but
> nothing has worked consistently across browsers. Can we split that
> particular minor issue out into its own bug and check the rest?

Sure thing, i will report new bug for it. Thank you)

Comment 13 Michael Burman 2018-01-11 09:05:11 UTC
Reported fresh bug to track the particular minor issue, BZ 1533389

Comment 14 Michael Burman 2018-02-18 08:40:50 UTC
Verified on - 4.2.2-0.1.el7

Comment 15 Sandro Bonazzola 2018-03-29 11:15:20 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.