Bug 1498991 - Review Request: rubygem-ruby-shadow - Ruby shadow password module
Summary: Review Request: rubygem-ruby-shadow - Ruby shadow password module
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-05 18:35 UTC by Terje Røsten
Modified: 2017-11-11 02:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-25 21:18:49 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Comment 1 Terje Røsten 2017-10-07 14:24:18 UTC
See: 

 https://bugzilla.redhat.com/show_bug.cgi?id=1475995 

for background for the request.

Comment 2 Robert-André Mauchin 🐧 2017-10-09 15:19:09 UTC
Hello,

 - Group: is not needed in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You should run the tests.

[!]: Test suite of the library should be run.

   There's a test provided here: https://github.com/apalmblad/ruby-shadow/tree/master/test

   Here's an outline of what needs to be done:

Source1:        tests-%{version}.tar.bz2
Source10:       dl-tests.sh

BuildRequires:  rubygem(minitest)

%prep
gem unpack %{SOURCE0}
%setup -q -D -T -n  %{gem_name}-%{version}
gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
%patch0 -p0
%setup -q -T -D -a 1 -n %{gem_name}-%{version}


%check
pushd .%{gem_instdir}
ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)'
popd


   dl-tests.sh is a script used by the nodejs guys to download tests from Github, it works well with our case. You can grab a copy here https://src.fedoraproject.org/rpms/nodejs-base/blob/master/f/dl-tests.sh Then run it to generate tests-%{version}.tar.bz2

Comment 3 Terje Røsten 2017-10-09 17:42:19 UTC
Group remove

Test added, however this being an shadow utils it seems tests wants super user to run properly, added a hack to "fix" that.

Updated package:
- Remove group
- Run tests

spec: https://terjeros.fedorapeople.org/rubygem-ruby-shadow/rubygem-ruby-shadow.spec
srpm: https://terjeros.fedorapeople.org/rubygem-ruby-shadow/rubygem-ruby-shadow-2.5.0-2.fc26.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22355791

Comment 4 Robert-André Mauchin 🐧 2017-10-09 18:13:22 UTC
All okay, package accepted.

Comment 5 Terje Røsten 2017-10-09 19:28:27 UTC
Thanks!

Comment 6 Gwyn Ciesla 2017-10-10 13:05:40 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-ruby-shadow

Comment 7 Fedora Update System 2017-10-13 15:14:29 UTC
rubygem-ruby-shadow-2.5.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-30b7e2301f

Comment 8 Fedora Update System 2017-10-13 15:14:37 UTC
rubygem-ruby-shadow-2.5.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ddd727c6c

Comment 9 Fedora Update System 2017-10-13 15:14:42 UTC
rubygem-ruby-shadow-2.5.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-61f35163af

Comment 10 Fedora Update System 2017-10-15 04:20:12 UTC
rubygem-ruby-shadow-2.5.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-30b7e2301f

Comment 11 Fedora Update System 2017-10-15 04:21:00 UTC
rubygem-ruby-shadow-2.5.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ddd727c6c

Comment 12 Fedora Update System 2017-10-15 05:52:50 UTC
rubygem-ruby-shadow-2.5.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-61f35163af

Comment 13 Fedora Update System 2017-10-25 21:18:49 UTC
rubygem-ruby-shadow-2.5.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-10-25 23:11:00 UTC
rubygem-ruby-shadow-2.5.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Vít Ondruch 2017-10-26 14:54:26 UTC
Thx, I retired ruby-shadow in F28.

Comment 16 Fedora Update System 2017-11-11 02:52:47 UTC
rubygem-ruby-shadow-2.5.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.