Bug 1499890 - md-cache uses incorrect xattr keynames for GF_POSIX_ACL keys
Summary: md-cache uses incorrect xattr keynames for GF_POSIX_ACL keys
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: md-cache
Version: 3.10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Guenther Deschner
QA Contact:
URL:
Whiteboard:
Depends On: 1476295
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-09 14:37 UTC by Guenther Deschner
Modified: 2017-11-01 12:58 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1476295
Environment:
Last Closed: 2017-11-01 12:58:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Guenther Deschner 2017-10-09 14:37:58 UTC
+++ This bug was initially created as a clone of Bug #1476295 +++

Description of problem:

The caching of GF_POSIX_ACL_DEFAULT and GF_POSIX_ACL_ACCESS keys is not done correctly because mdc_key_load_set() tries to enable the caching with an inappropriate prefix.

"glusterfs.posix_acl." does not match "glusterfs.posix.acl" nor "glusterfs.posix.default_acl"

Version-Release number of selected component (if applicable):
3.8

--- Additional comment from Worker Ant on 2017-07-28 10:28:45 EDT ---

REVIEW: https://review.gluster.org/17909 (md-cache: Use correct xattr keynames for virtual glusterfs ACLs.) posted (#1) for review on master by Günther Deschner (gd)

--- Additional comment from Worker Ant on 2017-07-29 16:54:29 EDT ---

COMMIT: https://review.gluster.org/17909 committed in master by Jeff Darcy (jeff.us) 
------
commit 5fe8555800cbc9818e7c976f63499795a378cd8d
Author: Günther Deschner <gd>
Date:   Wed Jul 26 18:10:33 2017 +0200

    md-cache: Use correct xattr keynames for virtual glusterfs ACLs.
    
    The "glusterfs.posix_acl." prefix does not catch the glusterfs posix acl
    xattr keynames which are
    
    	* "glusterfs.posix.acl" and
    	* "glusterfs.posix.default_acl"
    
    Using the GF_POSIX_ACL_ACCESS and GF_POSIX_ACL_DEFAULT defines directly
    is the savest option.
    
    Guenther
    
    Change-Id: I5aba64b26b6cbec850ea02316dd9f069400e857f
    BUG: 1476295
    Signed-off-by: Guenther Deschner <gd>
    Reviewed-on: https://review.gluster.org/17909
    Reviewed-by: Michael Adam <obnox>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-10-09 15:57:24 UTC
REVIEW: https://review.gluster.org/18457 (md-cache: Use correct xattr keynames for virtual glusterfs ACLs.) posted (#1) for review on release-3.10 by Günther Deschner (gd)

Comment 2 Worker Ant 2017-10-25 14:05:58 UTC
COMMIT: https://review.gluster.org/18457 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 4a26ff89564a90ad10020ab64d92f1ace886caff
Author: Günther Deschner <gd>
Date:   Mon Oct 9 17:56:27 2017 +0200

    md-cache: Use correct xattr keynames for virtual glusterfs ACLs.
    
    The "glusterfs.posix_acl." prefix does not catch the glusterfs posix acl
    xattr keynames which are
    
    	* "glusterfs.posix.acl" and
    	* "glusterfs.posix.default_acl"
    
    Using the GF_POSIX_ACL_ACCESS and GF_POSIX_ACL_DEFAULT defines directly
    is the savest option.
    
    Guenther
    
    > Change-Id: I5aba64b26b6cbec850ea02316dd9f069400e857f
    > BUG: 1476295
    > Signed-off-by: Guenther Deschner <gd>
    > Reviewed-on: https://review.gluster.org/17909
    > Reviewed-by: Michael Adam <obnox>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > Tested-by: Niels de Vos <ndevos>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > (cherry picked from commit 5fe8555800cbc9818e7c976f63499795a378cd8d)
    > Signed-off-by: Günther Deschner <gd>
    
    Change-Id: I5aba64b26b6cbec850ea02316dd9f069400e857f
    BUG: 1499890
    Signed-off-by: Günther Deschner <gd>

Comment 3 Shyamsundar 2017-11-01 12:58:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.7, please open a new bug report.

glusterfs-3.10.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-November/000085.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.