Description of problem: Cockpit is accessible via Service UI even if it is disabled in Server role. It can be accessed under VMs provisioned via services and can be seen under My Services. Version-Release number of selected component (if applicable): Version: 5.9.0.2.20171010190026_0413a06 How reproducible: Steps to Reproduce: 1.Disable Cockpit server role or keep disabled 2.Provision a VM from service UI 3.'Web console' in VM Actual results: Expected results: Additional info:
We should attach this to the new roles you are doing.
Would it be possible to get an appliance exhibiting this issue? Quick glance at the code, it looks okayish, not having any luck creating a user without the product feature in question.
SUI Cockpit is now gated on the product feature `sui_vm_console`, will take a look at the vm at about the end of today and report back
Hi Vatsal! Was wondering if you could create an appliance with the latest nightly and give this another check, (above comment) Appliance you posted is before these product features were added, wanta make sure this issue is applicable after those parts of the code have were given a little love.
This is fixed by https://github.com/ManageIQ/manageiq-ui-service/pull/1165
Hey, it seemed to be working previously in 5.9.0.4, but in 5.9.0.5, the issue still seems reproducible
Hi Vatsal, can you provide the appliance on which you're seeing this?
Created attachment 1348956 [details] I just checked master, looks like this isn't an issue there, gonna close this one Thanks for the appliance!! It made verifying the issue extremely easy <3
Created attachment 1348961 [details] Woops wrong screen shot, attached is current master, closing this because it is fixed on current master
Created attachment 1348962 [details] Its also fixed on current Gaprindashvili
(In reply to Allen W from comment #15) > Created attachment 1348961 [details] > Woops wrong screen shot, attached is current master, closing this because it > is fixed on current master This should be moved to on_qa to verify
Hello Vatsal, I took a look at the appliance you provided (thanks for that). What user should we login as? If I login as "admin" all works like I would expect it to. Chris
Created attachment 1350097 [details] i proxied into this appliance with the latest g release and did not see this issue ChrisK thinking this should be closed, not seeing the bug, it might be that an older appliance
Yeah Hi Vatsal, Thanks for checking this out on a recent build, what you're seeing is not a bug, we gate the availability of console buttons on a flag supports_console? This indicates the ability of the vm to support any console. The individual buttons supports_cockpit? and supports_vnc_console? are second to supports_console? (doesn’t matter if they are true if supports_console? is false). Please ensure the vm supports either console, if you feel this is still a bug please direct it to the appropriate team. Following this up with a ss to show ya what we're getting.
Created attachment 1350560 [details] supports_console? is false, sooo the console buttons are disabled, behaving as expected
Looks like this might be a server issue, the method that checks the status of the console availability, https://bugzilla.redhat.com/show_bug.cgi?id=1510131 captures a similar issue, suspect console availability status reporting.
More fixes for this going on here: https://github.com/ManageIQ/manageiq-ui-service/pull/1280 Api handling this has been vastly improved! <3
Able to verify this on Version: 5.9.0.12.20171205180333_3e32b3d