Bug 1510131 - SUI "VM Console" button is not disabled for VMware 6.5 when it should be
Summary: SUI "VM Console" button is not disabled for VMware 6.5 when it should be
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Appliance
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: Beta 3
: 5.9.0
Assignee: Jillian Tullo
QA Contact: Kedar Kulkarni
URL:
Whiteboard: ssui:html5:console
Depends On: 1471158
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-06 18:12 UTC by Satoe Imaishi
Modified: 2021-06-10 13:30 UTC (History)
20 users (show)

Fixed In Version: 5.9.0.12
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1471158
Environment:
Last Closed: 2018-03-06 15:19:27 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 4 Allen W 2017-11-10 16:08:12 UTC
Hi Kedar!  Thanks for bringing this to our attention, this behavior now seems similar to behavior identified in https://bugzilla.redhat.com/show_bug.cgi?id=1501246

The SUI gates the availability of the console buttons on two flags.  The first and most important is `supports_console?`.  If this is false, even if the users group has roles that have the console product features, neither will be enabled.

The second flags are `supports_cockpit?` and `supports_vnc_console?` if either of these are false,  (while `supports_console?` is true) they will be disabled. 

As all the SUI does is respond to these flags, thinking this is server bug of sorts, as all the api does is call existing methods, so looking into the  function that sets those flags makes sense.


@ChrisK can you assign this to someone with experience in this area?

Comment 17 CFME Bot 2017-11-28 19:41:43 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1d3aa9fceb43ce0d7d452d16c6a7dd792622b3a8

commit 1d3aa9fceb43ce0d7d452d16c6a7dd792622b3a8
Author:     Jillian Tullo <jtullo>
AuthorDate: Thu Nov 16 10:19:59 2017 -0500
Commit:     Jillian Tullo <jtullo>
CommitDate: Mon Nov 27 13:22:31 2017 -0500

    Add supported_consoles attribute to VM
    
    In an effort to consolidate all of the console logic, it is being moved from the classic ui to the models themselves. This change utilizes the supports feature mixin to handle the logic for support methods and unsupported error reasons. Then based off of the change, a single attribute is added that will return all of the possible consoles with enablement, visibility, and appropriate message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 app/models/mixins/supports_feature_mixin.rb |   9 ++
 app/models/vm.rb                            |  58 ++++++++
 app/models/vm/operations.rb                 |  69 ++++++++-
 spec/models/vm/operations_spec.rb           | 216 ++++++++++++++++++++++++++++
 spec/models/vm_spec.rb                      |   7 +
 5 files changed, 357 insertions(+), 2 deletions(-)

Comment 19 CFME Bot 2017-11-29 20:25:14 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/af07c9a1cb5b4c94cdd468a58c739e6f583ea870

commit af07c9a1cb5b4c94cdd468a58c739e6f583ea870
Author:     Jason Frey <fryguy9>
AuthorDate: Tue Nov 28 14:37:34 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Nov 28 15:27:20 2017 -0500

    Merge pull request #16519 from jntullo/console_support
    
    Add supported_consoles to VM
    (cherry picked from commit 026070ff074e0ea87e3c515f378189b184f5dd28)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 app/models/container_group.rb                    |   1 +
 app/models/mixins/cockpit_support_mixin.rb       |  33 +++++
 app/models/mixins/supports_feature_mixin.rb      | 137 ++++++++++---------
 app/models/vm.rb                                 |  58 ++++++++
 app/models/vm/operations.rb                      |  57 +++++++-
 spec/models/mixins/cockpit_support_mixin_spec.rb | 113 ++++++++++++++++
 spec/models/vm/operations_spec.rb                | 163 +++++++++++++++++++++++
 spec/models/vm_spec.rb                           |   7 +
 8 files changed, 502 insertions(+), 67 deletions(-)
 create mode 100644 app/models/mixins/cockpit_support_mixin.rb
 create mode 100644 spec/models/mixins/cockpit_support_mixin_spec.rb

Comment 20 CFME Bot 2017-11-29 20:25:22 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/fec04f5d77faea25368fceddae4ae9bae43d48d7

commit fec04f5d77faea25368fceddae4ae9bae43d48d7
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Tue Nov 28 17:44:47 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Nov 29 09:17:34 2017 -0500

    Merge pull request #16544 from jntullo/rename_mks
    
    Rename mks to webmks
    (cherry picked from commit a3cfae4612ffb488585d15d0e726b624d053de49)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 app/models/vm.rb       | 4 ++--
 spec/models/vm_spec.rb | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comment 21 CFME Bot 2017-11-29 20:30:20 UTC
New commit detected on ManageIQ/manageiq-ui-service/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-service/commit/2d576999f64558929d9e6da437124a7e91219a2f

commit 2d576999f64558929d9e6da437124a7e91219a2f
Author:     Chris Kacerguis <chriskacerguis.github.com>
AuthorDate: Mon Nov 6 07:47:46 2017 -0600
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Nov 6 15:59:43 2017 -0500

    Merge pull request #1195 from AllenBW/BZ/#1471158-add-supports-vnc-console-flag
    
    BZ#1471158-Adds support for supports_vnc_console decorator
    (cherry picked from commit 3745df59512d1e45cab8dac27836cd58547398e0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 client/app/services/service-details/service-details.component.js | 4 ++--
 client/app/services/service-details/service-details.html         | 4 ++--
 client/app/services/services-state.service.js                    | 2 +-
 client/app/services/services-state.service.spec.js               | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

Comment 22 CFME Bot 2017-11-29 20:31:27 UTC
New commit detected on ManageIQ/manageiq-ui-service/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-service/commit/5e4d989aa07412d665e1fdf31726827649bf9b73

commit 5e4d989aa07412d665e1fdf31726827649bf9b73
Author:     Chris Kacerguis <chriskacerguis.github.com>
AuthorDate: Wed Nov 29 08:44:01 2017 -0600
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Nov 29 09:56:14 2017 -0500

    Merge pull request #1280 from AllenBW/bug/master/#0000-console_supported
    
    Update console behavior as per api changes
    (cherry picked from commit eb3dc98da96ed70a38cf23b1712486ef0c24d210)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 client/app/services/service-details/service-details.component.js | 4 ++--
 client/app/services/service-details/service-details.html         | 4 ++--
 client/app/services/services-state.service.js                    | 4 ++--
 client/app/services/services-state.service.spec.js               | 3 +--
 4 files changed, 7 insertions(+), 8 deletions(-)

Comment 23 CFME Bot 2017-11-29 20:48:21 UTC
New commit detected on ManageIQ/manageiq-api/gaprindashvili:
https://github.com/ManageIQ/manageiq-api/commit/a132cb400dce012823384dd670eada3c0ff4b901

commit a132cb400dce012823384dd670eada3c0ff4b901
Author:     Alberto Bellotti <abellotti.github.com>
AuthorDate: Fri Nov 3 08:30:54 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Nov 6 15:58:18 2017 -0500

    Merge pull request #167 from jntullo/bug/vnc_console
    
    Add decorator for VNC Console
    (cherry picked from commit 995751041d9f0d2667bc700f923de5796e93a024)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510131

 app/controllers/api/subcollections/vms.rb | 3 +++
 spec/requests/services_spec.rb            | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

Comment 24 Kedar Kulkarni 2017-12-11 23:40:04 UTC
verified in 5.9.0.12.20171205180333_3e32b3d


Note You need to log in before you can comment on or make changes to this bug.