Bug 1502841 - Containerized deployment should not succeed if osd_scenario is unset
Summary: Containerized deployment should not succeed if osd_scenario is unset
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: Ceph-Ansible
Version: 3.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: rc
: 3.1
Assignee: John Fulton
QA Contact: Vasishta
Depends On:
Blocks: 1548353
TreeView+ depends on / blocked
Reported: 2017-10-16 20:20 UTC by John Fulton
Modified: 2019-08-26 16:15 UTC (History)
14 users (show)

Fixed In Version: RHEL: ceph-ansible-3.1.0-0.1.beta3.el7cp
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-08-26 16:15:35 UTC

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github ceph ceph-ansible issues 2095 0 None None None 2017-10-23 13:35:24 UTC
Github ceph ceph-ansible pull 2097 0 None None None 2017-10-23 14:36:58 UTC

Description John Fulton 2017-10-16 20:20:49 UTC
A ceph-ansible site-docker.yml run [1][2] produced a deployment with 0 failures and 0 OSDs because the osd_scenario variable was not set. I think this should have failed. 

As per the "make sure an osd scenario was chosen" task in check_mandatory_vars.yml [3] the deployment will fail if an osd_scenario is not chosen. However, the when condition does not do this check for a containerized deployment. Why should this check not be done for a containerized deployment? If the code to check this is somewhere else, why wasn't it executed? 

Additional info:
- The logs show that both scenarios were skipped [4]. 
- If you search the --extra-vars input to ansible-playbook it will show no scenario was passed. This is an error on part of the process calling the playbook, but ceph-ansible should have failed that deployment request. 

[1] Resulting run: http://paste.openstack.org/show/623760/
[2] Playbook command with --extra-vars http://paste.openstack.org/show/623752/
[3] https://github.com/ceph/ceph-ansible/blob/b685aceede71a2dc872ce140ac636a7301f471f6/roles/ceph-osd/tasks/check_mandatory_vars.yml

2017-10-16 10:16:00,713 p=12340 u=mistral |  TASK [ceph-osd : include scenarios/collocated.yml] *****************************
2017-10-16 10:16:00,729 p=12340 u=mistral |  skipping: []
2017-10-16 10:16:00,735 p=12340 u=mistral |  TASK [ceph-osd : include scenarios/non-collocated.yml] *************************
2017-10-16 10:16:00,753 p=12340 u=mistral |  skipping: []

Comment 6 John Fulton 2017-10-24 16:55:51 UTC
Setting this to POST as the changes have merged upstream. 


Comment 9 Ken Dreyer (Red Hat) 2018-03-19 15:57:03 UTC
John would you please confirm this is fixed in v3.1.0beta3 (or v3.1.0beta4)?

Comment 10 John Fulton 2018-03-23 03:07:50 UTC
(In reply to Ken Dreyer (Red Hat) from comment #9)
> John would you please confirm this is fixed in v3.1.0beta3 (or v3.1.0beta4)?

I confirm this is fixed. I tested with v3.1.0beta4.

Note You need to log in before you can comment on or make changes to this bug.